diff options
| author | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
|---|---|---|
| committer | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
| commit | 1be510f9529cb082f802408b472a77d074b394c0 (patch) | |
| tree | b175f9d5fcb107576dabc768e7bd04d4a3e491a0 /zarb-ml/mageia-dev/2012-December/020705.html | |
| parent | fa5098cf210b23ab4f419913e28af7b1b07dafb2 (diff) | |
| download | archives-master.tar archives-master.tar.gz archives-master.tar.bz2 archives-master.tar.xz archives-master.zip | |
Diffstat (limited to 'zarb-ml/mageia-dev/2012-December/020705.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2012-December/020705.html | 140 |
1 files changed, 140 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2012-December/020705.html b/zarb-ml/mageia-dev/2012-December/020705.html new file mode 100644 index 000000000..3d4d56197 --- /dev/null +++ b/zarb-ml/mageia-dev/2012-December/020705.html @@ -0,0 +1,140 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6620%5D%20obsoleted%20by%20pod-syntax.t&In-Reply-To=%3CCAONrEta5WJEiiPvjYT9KJM49pDnsb4Yd45ki8Pu7-iQZSMRp_A%40mail.gmail.com%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="020692.html"> + <LINK REL="Next" HREF="020688.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t</H1> + <B>Thierry Vignaud</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6620%5D%20obsoleted%20by%20pod-syntax.t&In-Reply-To=%3CCAONrEta5WJEiiPvjYT9KJM49pDnsb4Yd45ki8Pu7-iQZSMRp_A%40mail.gmail.com%3E" + TITLE="[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t">thierry.vignaud at gmail.com + </A><BR> + <I>Mon Dec 10 01:17:01 CET 2012</I> + <P><UL> + <LI>Previous message: <A HREF="020692.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t +</A></li> + <LI>Next message: <A HREF="020688.html">[Mageia-dev] [changelog] [RPM] cauldron core/release mplayer-1.1-7.mga3 +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#20705">[ date ]</a> + <a href="thread.html#20705">[ thread ]</a> + <a href="subject.html#20705">[ subject ]</a> + <a href="author.html#20705">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 9 December 2012 17:21, Guillaume Rousse <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">guillomovitch at gmail.com</A>> wrote: +>><i> No, I want pod errors to be found prior submitting them. +</I>>><i> And I don't want to manually run several tests. +</I>>><i> Before all I had to do was to run "make test" and it reported me +</I>>><i> any errors before commiting. +</I>>><i> Now it doesn't anymore. +</I>><i> +</I>><i> make test TEST_AUTHOR=1 +</I>><i> or drop the conditional in the tests. +</I> +so what's the difference with the older test? +You lamented old test didn't work standalone if blib wasn't created +but eventually in both cases, you need to run "make test" + +>><i> Well, if that mean less quality testsuite and if you refuse to answer +</I>>><i> reviewing, +</I>>><i> I'll eventually revert those or at least put back the old working pod +</I>>><i> test. +</I>><i> +</I>><i> Just revert. Or try to show minimal interest in external contributions, +</I>><i> instead of plain hostility. +</I> +what? +you added tests w/o any doc nor useful commit ("initial import") +When I told you they overlap existing tests, you claim existing ones +don't work and you just wip them w/o communicating. +I then show you that: +1) old one works and do fine issues when there'se one before +committing or releasing +2) new ones silently don't work (only found by accident when looking +at "make test" output +3) you claim new ones work by passing magic undocumented env variable +when they don't + +So what's the interest of your new tests? +The only change is that I silently cannot see newly introduced errors. +What's the use to the maintainer? + +So I did show interest in external contributions and as usual I do peer review. +This has enabled others to take interest in various pieces of our tools. +But you failed to answer my questions when I made some observations and when +I showed you old tests worked whereas new ones don't. +Same when I asked you to add the needed BR to the spec file in order +to ensure next version upload would work. +Your only answer is to attack me whereas I'm pointing at actual facts. + +So please stop trolling aka personal attacks and explain to me how +disabling tests for maintainers +(aka making them not working w/o some magic +undocumented/uncommunicated variable) +is contributing? + +I just want pod-syntax.t to be always run. +So eventually the pod syntax new test is just the old one but less +readable and not working by default: +- some magic values testing in order not to be run +- using English in order to rename variables +- replacing use by require+import + +It would just have been simple to ask before, hasn't it? +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="020692.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t +</A></li> + <LI>Next message: <A HREF="020688.html">[Mageia-dev] [changelog] [RPM] cauldron core/release mplayer-1.1-7.mga3 +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#20705">[ date ]</a> + <a href="thread.html#20705">[ thread ]</a> + <a href="subject.html#20705">[ subject ]</a> + <a href="author.html#20705">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |