blob: 3d4d56197257414213efce93598b2e75744af8ec (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6620%5D%20obsoleted%20by%20pod-syntax.t&In-Reply-To=%3CCAONrEta5WJEiiPvjYT9KJM49pDnsb4Yd45ki8Pu7-iQZSMRp_A%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="020692.html">
<LINK REL="Next" HREF="020688.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t</H1>
<B>Thierry Vignaud</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6620%5D%20obsoleted%20by%20pod-syntax.t&In-Reply-To=%3CCAONrEta5WJEiiPvjYT9KJM49pDnsb4Yd45ki8Pu7-iQZSMRp_A%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t">thierry.vignaud at gmail.com
</A><BR>
<I>Mon Dec 10 01:17:01 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="020692.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</A></li>
<LI>Next message: <A HREF="020688.html">[Mageia-dev] [changelog] [RPM] cauldron core/release mplayer-1.1-7.mga3
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#20705">[ date ]</a>
<a href="thread.html#20705">[ thread ]</a>
<a href="subject.html#20705">[ subject ]</a>
<a href="author.html#20705">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 9 December 2012 17:21, Guillaume Rousse <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">guillomovitch at gmail.com</A>> wrote:
>><i> No, I want pod errors to be found prior submitting them.
</I>>><i> And I don't want to manually run several tests.
</I>>><i> Before all I had to do was to run "make test" and it reported me
</I>>><i> any errors before commiting.
</I>>><i> Now it doesn't anymore.
</I>><i>
</I>><i> make test TEST_AUTHOR=1
</I>><i> or drop the conditional in the tests.
</I>
so what's the difference with the older test?
You lamented old test didn't work standalone if blib wasn't created
but eventually in both cases, you need to run "make test"
>><i> Well, if that mean less quality testsuite and if you refuse to answer
</I>>><i> reviewing,
</I>>><i> I'll eventually revert those or at least put back the old working pod
</I>>><i> test.
</I>><i>
</I>><i> Just revert. Or try to show minimal interest in external contributions,
</I>><i> instead of plain hostility.
</I>
what?
you added tests w/o any doc nor useful commit ("initial import")
When I told you they overlap existing tests, you claim existing ones
don't work and you just wip them w/o communicating.
I then show you that:
1) old one works and do fine issues when there'se one before
committing or releasing
2) new ones silently don't work (only found by accident when looking
at "make test" output
3) you claim new ones work by passing magic undocumented env variable
when they don't
So what's the interest of your new tests?
The only change is that I silently cannot see newly introduced errors.
What's the use to the maintainer?
So I did show interest in external contributions and as usual I do peer review.
This has enabled others to take interest in various pieces of our tools.
But you failed to answer my questions when I made some observations and when
I showed you old tests worked whereas new ones don't.
Same when I asked you to add the needed BR to the spec file in order
to ensure next version upload would work.
Your only answer is to attack me whereas I'm pointing at actual facts.
So please stop trolling aka personal attacks and explain to me how
disabling tests for maintainers
(aka making them not working w/o some magic
undocumented/uncommunicated variable)
is contributing?
I just want pod-syntax.t to be always run.
So eventually the pod syntax new test is just the old one but less
readable and not working by default:
- some magic values testing in order not to be run
- using English in order to rename variables
- replacing use by require+import
It would just have been simple to ask before, hasn't it?
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="020692.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</A></li>
<LI>Next message: <A HREF="020688.html">[Mageia-dev] [changelog] [RPM] cauldron core/release mplayer-1.1-7.mga3
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#20705">[ date ]</a>
<a href="thread.html#20705">[ thread ]</a>
<a href="subject.html#20705">[ subject ]</a>
<a href="author.html#20705">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
