[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t

Mon Dec 10 01:17:01 CET 2012

On 9 December 2012 17:21, Guillaume Rousse <guillomovitch at gmail.com> wrote:
+>> No, I want pod errors to be found prior submitting them.
+>> And I don't want to manually run several tests.
+>> Before all I had to do was to run "make test" and it reported me
+>> any errors before commiting.
+>> Now it doesn't anymore.
+>
+> make test TEST_AUTHOR=1
+> or drop the conditional in the tests.
+
+so what's the difference with the older test?
+You lamented old test didn't work standalone if blib wasn't created
+but eventually in both cases, you need to run "make test"
+
+>> Well, if that mean less quality testsuite and if you refuse to answer
+>> reviewing,
+>> I'll eventually revert those or at least put back the old working pod
+>> test.
+>
+> Just revert. Or try to show minimal interest in external contributions,
+> instead of plain hostility.
+
+what?
+you added tests w/o any doc nor useful commit ("initial import")
+When I told you they overlap existing tests, you claim existing ones
+don't work and you just wip them w/o communicating.
+I then show you that:
+1) old one works and do fine issues when there'se one before
+committing or releasing
+2) new ones silently don't work (only found by accident when looking
+at "make test" output
+3) you claim new ones work by passing magic undocumented env variable
+when they don't
+
+So what's the interest of your new tests?
+The only change is that I silently cannot see newly introduced errors.
+What's the use to the maintainer?
+
+So I did show interest in external contributions and as usual I do peer review.
+This has enabled others to take interest in various pieces of our tools.
+But you failed to answer my questions when I made some observations and when
+I showed you old tests worked whereas new ones don't.
+Same when I asked you to add the needed BR to the spec file in order
+to ensure next version upload would work.
+Your only answer is to attack me whereas I'm pointing at actual facts.
+
+So please stop trolling aka personal attacks and explain to me how
+disabling tests for maintainers
+(aka making them not working w/o some magic
+undocumented/uncommunicated variable)
+is contributing?
+
+I just want pod-syntax.t to be always run.
+So eventually the pod syntax new test is just the old one but less
+readable and not working by default:
+- some magic values testing in order not to be run
+- using English in order to rename variables
+- replacing use by require+import
+
+It would just have been simple to ask before, hasn't it?
+