blob: d57c6cb72c48a86d58f3f8eb9c4a74d437be888f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6416%5D%20Initial%20commit%20of%20Admin%0A%09Panel.&In-Reply-To=%3C50992FB7.2030607%40gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="019815.html">
<LINK REL="Next" HREF="019816.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.</H1>
<B>Matteo Pasotti</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6416%5D%20Initial%20commit%20of%20Admin%0A%09Panel.&In-Reply-To=%3C50992FB7.2030607%40gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.">matteo.pasotti at gmail.com
</A><BR>
<I>Tue Nov 6 16:41:43 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="019815.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI>Next message: <A HREF="019816.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19817">[ date ]</a>
<a href="thread.html#19817">[ thread ]</a>
<a href="subject.html#19817">[ subject ]</a>
<a href="author.html#19817">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/11/2012 16:26, Nicolas Lécureuil wrote:
>>><i> +sub require_root_capability { + return 0 if(!$>); + return 1;
</I>>>><i> +}
</I>>><i>
</I>>><i> Perl best practice: use english name for magic variables, for
</I>>><i> readability:
</I>><i>
</I>><i> why rewrite this function ? this exist in common.pm already
</I>Hello Nicolas,
yes, the function already exists but common.pm uses MDK::Common that
apanel currently doesn't needs. Consider then that we are using pkexec
and not consolehelper. I haven't found other ways at that time.
However, I kept that "code structure" to be able to easily switch
apanel to the common module if needed (or maybe support both the
backends).
Any suggestion is more than welcome :)
Regards,
- --
Matteo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - <A HREF="http://enigmail.mozdev.org/">http://enigmail.mozdev.org/</A>
iQEcBAEBAgAGBQJQmS+3AAoJED3LowjDDWbNkGoH+wTvtJl7gFJeqOGa1qljhySj
lzflQ4ALxDcUh3JZrCs8b4iRmVvc13vzqG/r5Y9jcmLrPzWyUFIKAm/RR6ey7JC1
9+rVTwq+kybG6z0kNX5ntqgA8OZdF56cH6tQ7WP5pXr+uYOZmmaQ5Eaqa0QuKcxe
56okyaCJ9QTIHAxv/zIUdZ1hlivScPt5yN1k+VNFnuXLAArnZ0vGTxc9kvyVzkMq
yv+VRqBJcO+4l3oVf3a40ZBTIpxt2AuiVf41lJSWBTLlARQyM61Sy4n+xQjTSl7G
o0Rhlb+GDiftPXSfxoFQrG5B1XgsDfsauFC6IB4eqCnp5/gs3va4McelkYgH+xk=
=+rP3
-----END PGP SIGNATURE-----
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="019815.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI>Next message: <A HREF="019816.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19817">[ date ]</a>
<a href="thread.html#19817">[ thread ]</a>
<a href="subject.html#19817">[ subject ]</a>
<a href="author.html#19817">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|