[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.

[Matteo Pasotti]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/11/2012 16:26, Nicolas Lécureuil wrote:
>>> +sub require_root_capability { +	return 0 if(!$>); +	return 1; 
>>> +}
>> 
>> Perl best practice: use english name for magic variables, for
>> readability:
> 
> why rewrite this function ? this exist in common.pm already
Hello Nicolas,
yes, the function already exists but common.pm uses MDK::Common that
apanel currently doesn't needs. Consider then that we are using pkexec
 and not consolehelper. I haven't found other ways at that time.
However, I kept that "code structure" to be able to easily switch
apanel to the common module if needed (or maybe support both the
backends).

Any suggestion is more than welcome :)
Regards,
- -- 
Matteo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJQmS+3AAoJED3LowjDDWbNkGoH+wTvtJl7gFJeqOGa1qljhySj
lzflQ4ALxDcUh3JZrCs8b4iRmVvc13vzqG/r5Y9jcmLrPzWyUFIKAm/RR6ey7JC1
9+rVTwq+kybG6z0kNX5ntqgA8OZdF56cH6tQ7WP5pXr+uYOZmmaQ5Eaqa0QuKcxe
56okyaCJ9QTIHAxv/zIUdZ1hlivScPt5yN1k+VNFnuXLAArnZ0vGTxc9kvyVzkMq
yv+VRqBJcO+4l3oVf3a40ZBTIpxt2AuiVf41lJSWBTLlARQyM61Sy4n+xQjTSl7G
o0Rhlb+GDiftPXSfxoFQrG5B1XgsDfsauFC6IB4eqCnp5/gs3va4McelkYgH+xk=
=+rP3
-----END PGP SIGNATURE-----