1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [4149] (create_display_box) fix crashing on calling a method on a non blessed reference
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4149%5D%20%28create_display_box%29%20fix%0A%20crashing%20on%20calling%20a%20method%20on%20a%20non%20blessed%20reference&In-Reply-To=%3CCA%2BCX%2BbgAS2jG3d%2BfqShw1TSA0h5pEvZhp1VS%3DNesht8R8ReAzw%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="014773.html">
<LINK REL="Next" HREF="014715.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [4149] (create_display_box) fix crashing on calling a method on a non blessed reference</H1>
<B>Pascal Terjan</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4149%5D%20%28create_display_box%29%20fix%0A%20crashing%20on%20calling%20a%20method%20on%20a%20non%20blessed%20reference&In-Reply-To=%3CCA%2BCX%2BbgAS2jG3d%2BfqShw1TSA0h5pEvZhp1VS%3DNesht8R8ReAzw%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [4149] (create_display_box) fix crashing on calling a method on a non blessed reference">pterjan at gmail.com
</A><BR>
<I>Tue Apr 24 01:47:31 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="014773.html">[Mageia-dev] Freeze push: php
</A></li>
<LI>Next message: <A HREF="014715.html">[Mageia-dev] [soft-commits] [4149] (create_display_box) fix crashing on calling a method on a non blessed reference
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#14709">[ date ]</a>
<a href="thread.html#14709">[ thread ]</a>
<a href="subject.html#14709">[ subject ]</a>
<a href="author.html#14709">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Fri, Apr 20, 2012 at 19:22, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
><i> Revision 4149 Author tv Date 2012-04-20 20:22:16 +0200 (Fri, 20 Apr 2012)
</I>><i>
</I>><i> Log Message
</I>><i>
</I>><i> (create_display_box) fix crashing on calling a method on a non blessed
</I>><i> reference
</I>><i>
</I>><i> Modified Paths
</I>><i>
</I>><i> drakx/trunk/perl-install/fs/partitioning_wizard.pm
</I>><i>
</I>><i> Modified: drakx/trunk/perl-install/fs/partitioning_wizard.pm
</I>><i> ===================================================================
</I>><i> --- drakx/trunk/perl-install/fs/partitioning_wizard.pm 2012-04-20 18:22:13
</I>><i> UTC (rev 4148)
</I>><i> +++ drakx/trunk/perl-install/fs/partitioning_wizard.pm 2012-04-20 18:22:16
</I>><i> UTC (rev 4149)
</I>><i> @@ -287,7 +287,8 @@
</I>><i>
</I>><i> sub create_display_box {
</I>><i> my ($kind, $resize, $fill_empty, $button) = @_;
</I>><i> - my @parts = fs::get::hds_fstab_and_holes($kind->{val});
</I>><i> + # perl_checker: require UNIVERSAL
</I>><i> + my @parts = fs::get::hds_fstab_and_holes($kind->{val}) if
</I>><i> UNIVERSAL::can($kind->{val}, 'first_usable_sector,');
</I>><i>
</I>><i> my $totalsectors = $kind->{val}{totalsectors};
</I>><i>
</I>><i>
</I>
This breaks "Use free space" display (nothing is displayed, only empty space).
Reverting this commit fixed it but I need to sleep now so I did not
try to understand.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="014773.html">[Mageia-dev] Freeze push: php
</A></li>
<LI>Next message: <A HREF="014715.html">[Mageia-dev] [soft-commits] [4149] (create_display_box) fix crashing on calling a method on a non blessed reference
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#14709">[ date ]</a>
<a href="thread.html#14709">[ thread ]</a>
<a href="subject.html#14709">[ subject ]</a>
<a href="author.html#14709">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
