[Mageia-dev] [soft-commits] [4149] (create_display_box) fix crashing on calling a method on a non blessed reference

[Pascal Terjan]

On Fri, Apr 20, 2012 at 19:22,  <root at mageia.org> wrote:
> Revision 4149 Author tv Date 2012-04-20 20:22:16 +0200 (Fri, 20 Apr 2012)
>
> Log Message
>
> (create_display_box) fix crashing on calling a method on a non blessed
> reference
>
> Modified Paths
>
> drakx/trunk/perl-install/fs/partitioning_wizard.pm
>
> Modified: drakx/trunk/perl-install/fs/partitioning_wizard.pm
> ===================================================================
> --- drakx/trunk/perl-install/fs/partitioning_wizard.pm	2012-04-20 18:22:13
> UTC (rev 4148)
> +++ drakx/trunk/perl-install/fs/partitioning_wizard.pm	2012-04-20 18:22:16
> UTC (rev 4149)
> @@ -287,7 +287,8 @@
>
>  sub create_display_box {
>      my ($kind, $resize, $fill_empty, $button) = @_;
> -    my @parts = fs::get::hds_fstab_and_holes($kind->{val});
> +    # perl_checker: require UNIVERSAL
> +    my @parts = fs::get::hds_fstab_and_holes($kind->{val}) if
> UNIVERSAL::can($kind->{val}, 'first_usable_sector,');
>
>      my $totalsectors = $kind->{val}{totalsectors};
>
>

This breaks "Use free space" display (nothing is displayed, only empty space).
Reverting this commit fixed it but I need to sleep now so I did not
try to understand.