diff options
Diffstat (limited to 'zarb-ml/mageia-dev/20110511/004620.html')
| -rw-r--r-- | zarb-ml/mageia-dev/20110511/004620.html | 112 |
1 files changed, 112 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/20110511/004620.html b/zarb-ml/mageia-dev/20110511/004620.html new file mode 100644 index 000000000..7ef0e2efe --- /dev/null +++ b/zarb-ml/mageia-dev/20110511/004620.html @@ -0,0 +1,112 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did ) + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5B1266%5D%20add%20missing%20function%20%28%20and%20no%20titi%2C%0A%20perl_checker%20didn%27%20t%20notice%20this%20one%2C%20but%20pterjan%20checker%20did%20%29&In-Reply-To=%3CBANLkTikhnh9EPqYNKjWZ7z91dFUbwqJE0Q%40mail.gmail.com%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="004615.html"> + <LINK REL="Next" HREF="004622.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did )</H1> + <B>Thierry Vignaud</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5B1266%5D%20add%20missing%20function%20%28%20and%20no%20titi%2C%0A%20perl_checker%20didn%27%20t%20notice%20this%20one%2C%20but%20pterjan%20checker%20did%20%29&In-Reply-To=%3CBANLkTikhnh9EPqYNKjWZ7z91dFUbwqJE0Q%40mail.gmail.com%3E" + TITLE="[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did )">thierry.vignaud at gmail.com + </A><BR> + <I>Wed May 11 10:26:58 CEST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="004615.html">[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did ) +</A></li> + <LI>Next message: <A HREF="004622.html">[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did ) +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#4620">[ date ]</a> + <a href="thread.html#4620">[ thread ]</a> + <a href="subject.html#4620">[ subject ]</a> + <a href="author.html#4620">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 11 May 2011 07:28, Michael scherer <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">misc at zarb.org</A>> wrote: +>><i> > add missing function ( and no titi, perl_checker didn't notice this one, but +</I>>><i> > pterjan checker did ) +</I>>><i> +</I>>><i> you lie: +</I>><i> +</I>><i> Or maybe I misued perl_checker :/ +</I>><i> +</I>><i> How do you check, just perl_checker file ? +</I> +You didn't misued it but you are not used to it :-) +So you failed to see at end of log that it was aborting +due to some core perl modules not following +proper perl_checker style. +Thus it didn't completed its checks on the file. + +So I blacklisted some more modules: +<A HREF="http://svnweb.mageia.org/soft/build_system/iurt/trunk/.perl_checker?r1=17&r2=1272">http://svnweb.mageia.org/soft/build_system/iurt/trunk/.perl_checker?r1=17&r2=1272</A> + +BTW, note that, in the previous years, I already run perl_checker +on iurt and added comments about dubious stuff in the code... + +eg dead code: +793 # FIXME: (tv) kill this dead code or use it!! +794 my $_s = sub { +795 if ($run{main}) { +796 plog("dumping cache..."); +797 dump_cache_par(\%run); +798 $Data::Dumper::Indent = 0; +799 $Data::Dumper::Terse = 1; +800 plog("Running environment:\n", Data::Dumper->Dump([\%run]), "\n"); +801 plog("Configuration:\n", Data::Dumper->Dump([$config]), "\n"); +802 } +803 exit(); +804 }; + +eg supposed to be doing stuff for arches but not actually using arch value +(aka a look that is equivalent to one single assignment): +1425 foreach my $arch (@{$config->{supported_arch}}) { #FIXME: (tv) +this loop looks suspiciously broken +1426 $ok &&= $cache->{queue}{$srpm}; +1427 } + +and the like +</PRE> + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="004615.html">[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did ) +</A></li> + <LI>Next message: <A HREF="004622.html">[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did ) +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#4620">[ date ]</a> + <a href="thread.html#4620">[ thread ]</a> + <a href="subject.html#4620">[ subject ]</a> + <a href="author.html#4620">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |