diff options
| author | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
|---|---|---|
| committer | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
| commit | 1be510f9529cb082f802408b472a77d074b394c0 (patch) | |
| tree | b175f9d5fcb107576dabc768e7bd04d4a3e491a0 /zarb-ml/mageia-dev/attachments/20120404/d21fc6fd | |
| parent | fa5098cf210b23ab4f419913e28af7b1b07dafb2 (diff) | |
| download | archives-master.tar archives-master.tar.gz archives-master.tar.bz2 archives-master.tar.xz archives-master.zip | |
Diffstat (limited to 'zarb-ml/mageia-dev/attachments/20120404/d21fc6fd')
| -rw-r--r-- | zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment-0001.html | 23 | ||||
| -rw-r--r-- | zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment.html | 23 |
2 files changed, 46 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment-0001.html b/zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment-0001.html new file mode 100644 index 000000000..2a774f30b --- /dev/null +++ b/zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment-0001.html @@ -0,0 +1,23 @@ +<br><br><div class="gmail_quote">On Wed, Apr 4, 2012 at 09:01, Thierry Vignaud <span dir="ltr"><<a href="mailto:thierry.vignaud@gmail.com">thierry.vignaud@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> + +<div class="im">On 4 April 2012 01:01, <<a href="mailto:root@mageia.org">root@mageia.org</a>> wrote:<br> +> Revision 3909 Author pterjan Date 2012-04-04 01:01:59 +0200 (Wed, 04 Apr<br> +> 2012)<br> +><br> +> Log Message<br> +><br> +> Drop check_chroot<br> +<br> +</div>A minor comment: it hasn't actually been dropped<br> +I think a better changelog would have been:<br> +<br> +"(check_chroot) merge it in check_build_chroot()"<br></blockquote><div> </div><div>Indeed, I'll improve log messages</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> + + +Also, you didn't comment the call to create_build_chroot() instead<br> +of to create_chroot().<br></blockquote><div> </div><div>Indeed, this was an extension of the change I amended before commit when I noticed the call with those options that I was moving had a dedicated function.</div><div> + +I should probably have done another commit</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> +Not that it matters a lot since create_build_chroot() got killed a little<br> +later but it would make history easier to read in 6 months (which it<br> +is already not for previous years :-( )<br></blockquote><div><br></div></div> diff --git a/zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment.html b/zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment.html new file mode 100644 index 000000000..2a774f30b --- /dev/null +++ b/zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment.html @@ -0,0 +1,23 @@ +<br><br><div class="gmail_quote">On Wed, Apr 4, 2012 at 09:01, Thierry Vignaud <span dir="ltr"><<a href="mailto:thierry.vignaud@gmail.com">thierry.vignaud@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> + +<div class="im">On 4 April 2012 01:01, <<a href="mailto:root@mageia.org">root@mageia.org</a>> wrote:<br> +> Revision 3909 Author pterjan Date 2012-04-04 01:01:59 +0200 (Wed, 04 Apr<br> +> 2012)<br> +><br> +> Log Message<br> +><br> +> Drop check_chroot<br> +<br> +</div>A minor comment: it hasn't actually been dropped<br> +I think a better changelog would have been:<br> +<br> +"(check_chroot) merge it in check_build_chroot()"<br></blockquote><div> </div><div>Indeed, I'll improve log messages</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> + + +Also, you didn't comment the call to create_build_chroot() instead<br> +of to create_chroot().<br></blockquote><div> </div><div>Indeed, this was an extension of the change I amended before commit when I noticed the call with those options that I was moving had a dedicated function.</div><div> + +I should probably have done another commit</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> +Not that it matters a lot since create_build_chroot() got killed a little<br> +later but it would make history easier to read in 6 months (which it<br> +is already not for previous years :-( )<br></blockquote><div><br></div></div> |