diff options
Diffstat (limited to 'perl-install/fsedit.pm')
| -rw-r--r-- | perl-install/fsedit.pm | 484 | 
1 files changed, 261 insertions, 223 deletions
| diff --git a/perl-install/fsedit.pm b/perl-install/fsedit.pm index fd2f89e04..d209b0196 100644 --- a/perl-install/fsedit.pm +++ b/perl-install/fsedit.pm @@ -1,8 +1,9 @@ -package fsedit; # $Id$ +package fsedit;  use diagnostics;  use strict;  use vars qw(%suggestions); +use feature 'state';  #-######################################################################################  #- misc imports @@ -10,42 +11,65 @@ use vars qw(%suggestions);  use common;  use partition_table;  use partition_table::raw; +use fs::get;  use fs::type; +use fs::loopback; +use fs::proc_partitions;  use detect_devices;  use devices; -use loopback;  use log;  use fs; +# min_hd_size: only suggest this partition if the hd size is bigger than that  %suggestions = (    N_("simple") => [ -    { mntpoint => "/",     size => 300 << 11, fs_type => 'ext3', ratio => 5, maxsize => 6000 << 11 }, -    { mntpoint => "swap",  size =>  64 << 11, fs_type => 'swap', ratio => 1, maxsize => 1100 << 11 }, -    { mntpoint => "/home", size => 300 << 11, fs_type => 'ext3', ratio => 3 }, +    { mntpoint => "/",     size => MB(300), fs_type => defaultFS(), ratio => 6, maxsize => MB(51500) }, +    { mntpoint => "swap",  size => MB(256), fs_type => 'swap', ratio => 1, maxsize => MB(4096) }, +    { mntpoint => "/home", size => MB(300), fs_type => defaultFS(), ratio => 12, min_hd_size => MB(51200) },    ], N_("with /usr") => [ -    { mntpoint => "/",     size => 250 << 11, fs_type => 'ext3', ratio => 1, maxsize => 2000 << 11 }, -    { mntpoint => "swap",  size =>  64 << 11, fs_type => 'swap', ratio => 1, maxsize => 1100 << 11 }, -    { mntpoint => "/usr",  size => 300 << 11, fs_type => 'ext3', ratio => 4, maxsize => 4000 << 11 }, -    { mntpoint => "/home", size => 100 << 11, fs_type => 'ext3', ratio => 3 }, +    { mntpoint => "/",     size => MB(250), fs_type => defaultFS(), ratio => 1, maxsize => MB(8000) }, +    { mntpoint => "swap",  size =>  MB(64), fs_type => 'swap', ratio => 1, maxsize => MB(4000) }, +    { mntpoint => "/usr",  size => MB(300), fs_type => defaultFS(), ratio => 4, maxsize => MB(8000) }, +    { mntpoint => "/home", size => MB(100), fs_type => defaultFS(), ratio => 3, min_hd_size => MB(10000) },    ], N_("server") => [ -    { mntpoint => "/",     size => 150 << 11, fs_type => 'ext3', ratio => 1, maxsize =>  800 << 11 }, -    { mntpoint => "swap",  size =>  64 << 11, fs_type => 'swap', ratio => 2, maxsize => 1600 << 11 }, -    { mntpoint => "/usr",  size => 300 << 11, fs_type => 'ext3', ratio => 4, maxsize => 4000 << 11 }, -    { mntpoint => "/var",  size => 200 << 11, fs_type => 'ext3', ratio => 3 }, -    { mntpoint => "/home", size => 150 << 11, fs_type => 'ext3', ratio => 3 }, -    { mntpoint => "/tmp",  size => 150 << 11, fs_type => 'ext3', ratio => 2, maxsize => 1000 << 11 }, +    { mntpoint => "/",     size => MB(150), fs_type => defaultFS(), ratio => 1, maxsize => MB(8000) }, +    { mntpoint => "swap",  size =>  MB(64), fs_type => 'swap', ratio => 2, maxsize => MB(4000) }, +    { mntpoint => "/usr",  size => MB(300), fs_type => defaultFS(), ratio => 4, maxsize => MB(8000) }, +    { mntpoint => "/var",  size => MB(200), fs_type => defaultFS(), ratio => 3 }, +    { mntpoint => "/home", size => MB(150), fs_type => defaultFS(), ratio => 3, min_hd_size => MB(10000) }, +    { mntpoint => "/tmp",  size => MB(150), fs_type => defaultFS(), ratio => 2, maxsize => MB(4000) },    ],  ); -foreach (values %suggestions) { -    if (arch() =~ /ia64/) { -	@$_ = ({ mntpoint => "/boot/efi", size => 50 << 11, pt_type => 0xef, ratio => 1, maxsize => 150 << 11 }, @$_); +my %bck_suggestions = %suggestions; + +sub init_mntpnt_suggestions { +    my ($all_hds, $o_target, $o_force) = @_; + +    my $device = $o_target ? $o_target->{device} : 'all'; +    state $last_device; +    return if $device eq $last_device && !$o_force; +    $last_device = $device; + +    #- If installing on a removable device, assume that the user wants that device to be self-bootable. +    my $is_removable = $o_target && $o_target->{is_removable}; +    my @fstab = $is_removable ? partition_table::get_normal_parts($o_target) : fs::get::fstab($all_hds); + +    my $mntpoint; +    # only suggests /boot/EFI if there's not already one: +    require fs::any; +    if (is_uefi()) { +	if (!any { isESP($_) } @fstab) { +	    $mntpoint = { mntpoint => "/boot/EFI", size => MB(100), pt_type => 0xef, ratio => 1, maxsize => MB(300) }; +	} +    } +    foreach (keys %suggestions) { +	$suggestions{$_} = [ if_($mntpoint, $mntpoint), @{$bck_suggestions{$_}} ];      }  }  my @suggestions_mntpoints = ( -    "/var/ftp", "/var/www", "/boot", -    arch() =~ /sparc/ ? "/mnt/sunos" : arch() =~ /ppc/ ? "/mnt/macos" : "/mnt/windows", -    #- RedHat also has /usr/local and /opt +    "/var/ftp", "/var/www", "/boot", '/usr/local', '/opt', +   "/mnt/windows",  );  #-###################################################################################### @@ -58,11 +82,11 @@ sub recompute_loopbacks {  }  sub raids { -    my ($hds) = @_; +    my ($hds, $raw_hds) = @_;      my @parts = fs::get::hds_fstab(@$hds); -    my @l = grep { isRawRAID($_) } @parts or return []; +    my @l = grep { isRawRAID($_) } ( @parts, @$raw_hds ) or return [];      log::l("looking for raids in " . join(' ', map { $_->{device} } @l)); @@ -71,9 +95,29 @@ sub raids {      raid::get_existing(@l);  } +sub dmcrypts { +    my ($all_hds) = @_; + +    my @parts = fs::get::fstab($all_hds); + +    my @l = grep { fs::type::isRawLUKS($_) } @parts or return; + +    log::l("using dm-crypt from " . join(' ', map { $_->{device} } @l)); +     +    require fs::dmcrypt; +    fs::dmcrypt::read_crypttab($all_hds); + +    fs::dmcrypt::get_existing(@l); +} +  sub lvms {      my ($all_hds) = @_;      my @pvs = grep { isRawLVM($_) } fs::get::fstab($all_hds) or return; +    scan_pvs(@pvs); +} + +sub scan_pvs { +    my (@pvs) = @_;      log::l("looking for vgs in " . join(' ', map { $_->{device} } @pvs)); @@ -83,7 +127,7 @@ sub lvms {      my @lvms;      foreach (@pvs) { -	my $name = lvm::get_vg($_) or next; +	my $name = lvm::pv_to_vg($_) or next;  	my $lvm = find { $_->{VG_name} eq $name } @lvms;  	if (!$lvm) {  	    $lvm = new lvm($name); @@ -97,6 +141,42 @@ sub lvms {      @lvms;  } +sub handle_dmraid { +    my ($drives, $o_in) = @_; + +    @$drives > 1 or return; + +    devices::make($_->{device}) foreach @$drives; + +    require fs::dmraid;  +    eval { fs::dmraid::init() } or log::l("dmraid::init failed"), return; + +    my @vgs = fs::dmraid::vgs(); +    log::l(sprintf('dmraid: ' . join(' ', map { "$_->{device} [" . join(' ', @{$_->{disks}}) . "]" } @vgs))); + +    if ($o_in && @vgs && $::isInstall) { +	@vgs = grep { +	    $o_in->ask_yesorno('', N("BIOS software RAID detected on disks %s. Activate it?", join(' ', @{$_->{disks}})), 1); +	} @vgs or do { +	    fs::dmraid::call_dmraid('-an'); +	    return; +	}; +    } +    if (!$::isInstall) { +	fs::dmraid::migrate_device_names($_) foreach @vgs; +    } +    log::l("using dmraid on " . join(' ', map { $_->{device} } @vgs)); + +    my @used_hds = map { +	my $part = fs::get::device2part($_, $drives) or log::l("handle_dmraid: can't find $_ in known drives"); +	if_($part, $part); +    } map { @{$_->{disks}} } @vgs; + +    @$drives = difference2($drives, \@used_hds); + +    push @$drives, @vgs; +} +  sub get_hds {      my ($o_flags, $o_in) = @_;      my $flags = $o_flags || {}; @@ -104,9 +184,11 @@ sub get_hds {      my @drives = detect_devices::hds(); +    #- replace drives used in dmraid by the merged name +    handle_dmraid(\@drives, $o_in) if !$flags->{nodmraid}; +      foreach my $hd (@drives) {  	$hd->{file} = devices::make($hd->{device}); -	$hd->{prefix} ||= $hd->{device};      }      @drives = partition_table::raw::get_geometries(@drives); @@ -115,9 +197,25 @@ sub get_hds {      foreach my $hd (@drives) {  	$hd->{readonly} = $flags->{readonly}; +	#- We only create RAID components in disk partitions, but users may have used +	#- mdadm directly to create them on raw disk devices. Detect that now, before +	#- looking for a partition table (which is likely to fail badly - mga#26707). +	if (my $type = fs::type::type_subpart_from_magic($hd)) { +	    if (isRawRAID($type)) { +		#- Add the necessary information to the raw device to allow the RAID +		#- array to be properly characterised in diskdrake. +		put_in_hash($hd, $type); +		$hd->{size} = $hd->{totalsectors}; +		push @raw_hds, $hd; +		next; +	    } +	} +  	eval { partition_table::raw::test_for_bad_drives($hd) if !$flags->{no_bad_drives} };  	if (my $err = $@) { +	    log::l("test_for_bad_drives returned $err");  	    if ($err =~ /write error:/) {  +		log::l("setting $hd->{device} readonly");  		$hd->{readonly} = 1;  	    } elsif ($err =~ /read error:/) {  		next; @@ -128,14 +226,11 @@ sub get_hds {  	}  	if ($flags->{clearall} || member($hd->{device}, @{$flags->{clear} || []})) { -	    partition_table::raw::zero_MBR_and_dirty($hd); +	    my $lvms = []; #- temporary one, will be re-created later in get_hds() +	    partition_table_clear_and_initialize($lvms, $hd, $o_in);  	} else {  	    my $handle_die_and_cdie = sub { -		if ($hd->{readonly}) { -		    log::l("using /proc/partitions since diskdrake failed :("); -		    use_proc_partitions($hd); -		    1; -		} elsif (my $type = fs::type::type_subpart_from_magic($hd)) { +		if (my $type = fs::type::type_subpart_from_magic($hd)) {  		    #- non partitioned drive?  		    if (exists $hd->{usb_description} && $type->{fs_type}) {  			#- USB keys @@ -143,16 +238,13 @@ sub get_hds {  			push @raw_hds, $hd;  			$hd = '';  			1; -		    } elsif ($type->{pt_type} == 0x8e) { -			#- LVM on full disk -			my $part = { size => $hd->{totalsectors}, device => $hd->{device}, %$type }; -			bless $hd, 'partition_table::raw'; -			$hd->{readonly} = $hd->{getting_rid_of_readonly_allowed} = 1; -			$hd->{primary}{normal} = [ $part ]; -			1;  		    } else {  			0;  		    } +		} elsif ($hd->{readonly}) { +		    log::l("using /proc/partitions since diskdrake failed :("); +		    fs::proc_partitions::use_($hd); +		    1;  		} else {  		    0;  		} @@ -163,8 +255,15 @@ sub get_hds {  		    partition_table::read($hd);  		    if (listlength(partition_table::get_normal_parts($hd)) == 0) {  			$handled = 1 if $handle_die_and_cdie->(); -		    } else { -			compare_with_proc_partitions($hd) if $::isInstall; +		    } elsif ($::isInstall) { +			if (fs::type::is_dmraid($hd)) { +			    if (my $p = find { ! -e "/dev/$_->{device}" } partition_table::get_normal_parts($hd)) { +				#- dmraid should have created the device, so it means we don't agree +				die sprintf(q(bad dmraid (missing partition %s), you may try rebooting install with option "nodmraid"), $p->{device}); +			    } +			} else { +			    fs::proc_partitions::compare($hd) if !detect_devices::is_xbox(); +			}  		    }  		} sub {  		    my $err = $@; @@ -181,7 +280,7 @@ sub get_hds {  		    #- already handled in cdie handler above  		} elsif ($handle_die_and_cdie->()) {  		} elsif ($o_in && $o_in->ask_yesorno(N("Error"),  -N("I can not read the partition table of device %s, it's too corrupted for me :( +N("I cannot read the partition table of device %s, it's too corrupted for me :(  I can try to go on, erasing over bad partitions (ALL DATA will be lost!).  The other solution is to not allow DrakX to modify the partition table.  (the error is %s) @@ -192,7 +291,7 @@ Do you agree to lose all the partitions?  		} else {  		    #- using it readonly  		    log::l("using /proc/partitions since diskdrake failed :("); -		    use_proc_partitions($hd); +		    fs::proc_partitions::use_($hd);  		}  	    }  	    $hd or next; @@ -203,29 +302,21 @@ Do you agree to lose all the partitions?  	my @parts = partition_table::get_normal_parts($hd); +	# fix installer failures due to udev's race when run too early: +	run_program::run('udevadm', 'settle'); +  	# checking the magic of the filesystem, do not rely on pt_type -	foreach (grep { member($_->{fs_type}, 'vfat', 'ntfs', 'ext2') || $_->{pt_type} == 0x100 } @parts) { +	foreach (@parts) {  	    if (my $type = fs::type::type_subpart_from_magic($_)) { -                if ($type->{fs_type}) { -                    #- keep {pt_type} -		    $_->{fs_type} = $type->{fs_type}; -                } else { -                    put_in_hash($_, $type);  -                } +                $type->{pt_type} = $_->{pt_type}; #- keep {pt_type} +                put_in_hash($_, $type);   	    } else {  		$_->{bad_fs_type_magic} = 1;  	    }  	} -	 -	foreach (@parts) { -	    my $label = -	      member($_->{fs_type}, qw(ext2 ext3)) ? -		c::get_ext2_label(devices::make($_->{device})) : -		''; -	    $_->{device_LABEL} = $label if $label; -	}  	if ($hd->{usb_media_type}) { +	    $hd->{is_removable} = 1;  	    $_->{is_removable} = 1 foreach @parts;  	} @@ -233,66 +324,21 @@ Do you agree to lose all the partitions?      }      #- detect raids before LVM allowing LVM on raid -    my $raids = raids(\@hds); +    my $raids = raids(\@hds, \@raw_hds);      my $all_hds = { %{ fs::get::empty_all_hds() }, hds => \@hds, raw_hds => \@raw_hds, lvms => [], raids => $raids };      $all_hds->{lvms} = [ lvms($all_hds) ]; -    fs::get_major_minor(fs::get::fstab($all_hds)); - -    $all_hds; -} - -sub read_proc_partitions { -    my ($hds) = @_; - -    my @all = devices::read_proc_partitions_raw(); -    my ($parts, $disks) = partition { $_->{dev} =~ /\d$/ && $_->{dev} !~ /^(sr|scd)/ } @all; +    fs::get_major_minor([ fs::get::fstab($all_hds) ]); -    my $devfs_like = any { $_->{dev} =~ m|/disc$| } @$disks; +    # must be done after getting major/minor +    $all_hds->{dmcrypts} = [ dmcrypts($all_hds) ]; +    # allow lvm on dmcrypt +    $all_hds->{lvms} = [ lvms($all_hds) ]; -    my %devfs2normal = map { -	my (undef, $major, $minor) = devices::entry($_->{device}); -	my $disk = find { $_->{major} == $major && $_->{minor} == $minor } @$disks; -	$disk->{dev} => $_->{device}; -    } @$hds; +    $_->{faked_device} = 0 foreach fs::get::fstab($all_hds); -    my $prev_part; -    foreach my $part (@$parts) { -	my $dev; -	if ($devfs_like) { -	    $dev = -e "/dev/$part->{dev}" ? $part->{dev} : sprintf("0x%x%02x", $part->{major}, $part->{minor}); -	    $part->{rootDevice} = $devfs2normal{dirname($part->{dev}) . '/disc'}; -	} else { -	    $dev = $part->{dev}; -	    if (my $hd = find { $part->{dev} =~ /^\Q$_->{device}\E./ } @$hds) { -		put_in_hash($part, partition_table::hd2minimal_part($hd)); -	    } -	} -	undef $prev_part if $prev_part && ($prev_part->{rootDevice} || '') ne ($part->{rootDevice} || ''); - -	$part->{device} = $dev; -	$part->{size} *= 2;	# from KB to sectors -	$part->{start} = $prev_part ? $prev_part->{start} + $prev_part->{size} : 0; -	put_in_hash($part, fs::type::type_subpart_from_magic($part)); -	$prev_part = $part; -	delete $part->{dev}; # cleanup -    } -    @$parts; -} - -sub is_same_hd { -    my ($hd1, $hd2) = @_; -    if ($hd1->{major} && $hd2->{major}) { -	$hd1->{major} == $hd2->{major} && $hd1->{minor} == $hd2->{minor}; -    } elsif (my ($s1) = $hd1->{device} =~ m|https?://(.+?)/*$|) { -	my ($s2) = $hd2->{device} =~ m|https?://(.+?)/*$|; -	$s1 eq $s2; -    } else { -	$hd1->{devfs_device} && $hd2->{devfs_device} && $hd1->{devfs_device} eq $hd2->{devfs_device} -	  || $hd1->{device_LABEL} && $hd2->{device_LABEL} && $hd1->{device_LABEL} eq $hd2->{device_LABEL} -	  || $hd1->{device} && $hd2->{device} && $hd1->{device} eq $hd2->{device}; -    } +    $all_hds;  }  #- are_same_partitions() do not look at the device name since things may have changed @@ -309,22 +355,28 @@ sub is_one_big_fat_or_NT {      @$hds == 1 or return 0;      my @l = fs::get::hds_fstab(@$hds); -    @l == 1 && isFat_or_NTFS($l[0]) && fs::get::hds_free_space(@$hds) < 10 << 11; +    @l == 1 && isFat_or_NTFS($l[0]) && fs::get::hds_free_space(@$hds) < MB(10);  }  sub computeSize { -    my ($part, $best, $all_hds, $suggestions) = @_; +    my ($part, $best, $all_hds, $suggestions, $o_target) = @_;      my $max = $part->{maxsize} || $part->{size};      return min($max, $best->{size}) unless $best->{ratio}; -    my $free_space = fs::get::free_space($all_hds); -    my @l = my @L = grep {  -	if ($free_space >= $_->{size}) { -	    $free_space -= $_->{size}; +    my %free_space; +    $free_space{$_->{rootDevice}} += $_->{size} foreach fs::get::holes($all_hds); + +    my @l = my @L = grep { +	my @possible = $_->{hd} ? $_->{hd} : keys %free_space; +	my $size = $_->{size}; +	if (my $dev = find { $free_space{$_} >= $size } @possible) { +	    $free_space{$dev} -= $size;  	    1;  	} else { 0 } } @$suggestions; +    my $free_space = $o_target && $free_space{$o_target->{device}} || $best->{hd} && $free_space{$best->{hd}} || sum(values %free_space); +      my $cylinder_size_maxsize_adjusted;      my $tot_ratios = 0;      while (1) { @@ -350,11 +402,11 @@ sub computeSize {      }      my $size = int min($max, $best->{size} + $free_space * ($tot_ratios && $best->{ratio} / $tot_ratios));      #- verify other entry can fill the hole -    (any { $_->{size} < $max - $size } @L) ? $size : $max; +    (any { $_->{size} <= $max - $size } @L) ? $size : $max;  }  sub suggest_part { -    my ($part, $all_hds, $o_suggestions) = @_; +    my ($part, $all_hds, $o_suggestions, $o_target) = @_;      my $suggestions = $o_suggestions || $suggestions{server} || $suggestions{simple};      #- suggestions now use {fs_type}, but still keep compatibility @@ -362,13 +414,26 @@ sub suggest_part {  	fs::type::set_pt_type($_, $_->{pt_type}) if !exists $_->{fs_type};      } -    my $has_swap = any { isSwap($_) } fs::get::fstab($all_hds); +    my $hd = fs::get::part2hd($part, $all_hds); +    my $hd_size = $hd && $hd->{totalsectors}; # nb: no $hd if $part is /dev/mdX +    my @fstab = $hd->{is_removable} ? partition_table::get_normal_parts($hd) : fs::get::fstab($all_hds); +    my $has_swap = any { isSwap($_) } @fstab;      my @local_suggestions = -      grep { !fs::get::has_mntpoint($_->{mntpoint}, $all_hds) || isSwap($_) && !$has_swap } +      grep { $::auto_install || !$_->{mntpoint} && !$_->{VG_name} || !fs::get::has_mntpoint($_->{mntpoint}, $all_hds) || isSwap($_) && !$has_swap } +      grep { !$_->{min_hd_size} || !$hd_size || $_->{min_hd_size} <= $hd_size }        grep { !$_->{hd} || $_->{hd} eq $part->{rootDevice} }  	@$suggestions; +    #- this allows specifying the size using a relative size. +    #- one should rather use {ratio} instead +    foreach (@local_suggestions) { +	if ($_->{percent_size} && $_->{percent_size} =~ /(.+?)%?$/) { +	    $_->{size} = $1 / 100 * $hd_size; +	    log::l("in suggestion, setting size=$_->{size} for percent_size=$_->{percent_size}"); +	} +    } +      my ($best) =        grep { !$_->{maxsize} || $part->{size} <= $_->{maxsize} }        grep { $_->{size} <= ($part->{maxsize} || $part->{size}) } @@ -379,11 +444,12 @@ sub suggest_part {      $part->{mntpoint} = $best->{mntpoint};      fs::type::set_type_subpart($part, $best) if !isTrueFS($best) || !isTrueFS($part); -    $part->{size} = computeSize($part, $best, $all_hds, \@local_suggestions); -    foreach ('options', 'lv_name', 'encrypt_key') { +    $part->{size} = computeSize($part, $best, $all_hds, \@local_suggestions, $o_target); +    foreach ('options', 'lv_name', 'encrypt_key', 'primaryOrExtended', +	     'device_LABEL', 'prefer_device_LABEL', 'device_UUID', 'prefer_device_UUID', 'prefer_device') {  	$part->{$_} = $best->{$_} if $best->{$_};      } -    1; +    $best;  }  sub suggestions_mntpoint { @@ -402,30 +468,29 @@ sub check_mntpoint {      $mntpoint =~ m|[\x7f-\xff]| and cdie N("Mount points should contain only alphanumerical characters");      fs::get::mntpoint2part($mntpoint, [ grep { $_ ne $part } fs::get::really_all_fstab($all_hds) ]) and die N("There is already a partition with mount point %s\n", $mntpoint); -    cdie N("You've selected a software RAID partition as root (/). +    if ($mntpoint eq "/" && (isLUKS($part) || isRawLUKS($part)) && !fs::get::has_mntpoint("/boot", $all_hds)) { +	cdie N("You've selected an encrypted partition as root (/).  No bootloader is able to handle this without a /boot partition. -Please be sure to add a /boot partition") if $mntpoint eq "/" && isRAID($part) && !fs::get::has_mntpoint("/boot", $all_hds); -    die N("You can not use a LVM Logical Volume for mount point %s", $mntpoint) -      if $mntpoint eq '/boot' && isLVM($part); -    cdie N("You've selected a LVM Logical Volume as root (/). -The bootloader is not able to handle this without a /boot partition. -Please be sure to add a /boot partition") if $mntpoint eq "/" && isLVM($part) && !fs::get::has_mntpoint("/boot", $all_hds); -    cdie N("You may not be able to install lilo (since lilo does not handle a LV on multiple PVs)") -      if 0; # arch() =~ /i.86/ && $mntpoint eq '/' && isLVM($hd) && @{$hd->{disks} || []} > 1; +Please be sure to add a separate /boot partition"); +    } + +    if ($mntpoint eq "/boot" && (isLUKS($part) || isRawLUKS($part)))  { +	die N("You cannot use an encrypted filesystem for mount point %s", "/boot"); +    }      cdie N("This directory should remain within the root filesystem")        if member($mntpoint, qw(/root));      die N("This directory should remain within the root filesystem") -      if member($mntpoint, qw(/bin /dev /etc /lib /sbin /mnt)); -    die N("You need a true filesystem (ext2/ext3, reiserfs, xfs, or jfs) for this mount point\n") +      if member($mntpoint, qw(/bin /dev /etc /lib /sbin /mnt /media)); +    die N("You need a true filesystem (ext2/3/4, reiserfs, xfs, or jfs) for this mount point\n")        if !isTrueLocalFS($part) && $mntpoint eq '/'; -    die N("You need a true filesystem (ext2/ext3, reiserfs, xfs, or jfs) for this mount point\n") -      if !isTrueFS($part) && member($mntpoint, fs::type::directories_needed_to_boot()); -    die N("You can not use an encrypted file system for mount point %s", $mntpoint) +    die N("You need a true filesystem (ext2/3/4, reiserfs, xfs, or jfs) for this mount point\n") . $mntpoint +      if !isTrueFS($part) && member($mntpoint, '/home', fs::type::directories_needed_to_boot_not_ESP()); +    die N("You cannot use an encrypted filesystem for mount point %s", $mntpoint)        if $part->{options} =~ /encrypted/ && member($mntpoint, qw(/ /usr /var /boot));      local $part->{mntpoint} = $mntpoint; -    loopback::check_circular_mounts($part, $all_hds); +    fs::loopback::check_circular_mounts($part, $all_hds);  }  sub add { @@ -442,30 +507,42 @@ sub add {      } else {  	partition_table::add($hd, $part, $options->{primaryOrExtended});      } +    fs::get_major_minor([ $part ]);  }  sub allocatePartitions { -    my ($all_hds, $to_add) = @_; +    my ($all_hds, $to_add, $o_hd) = @_; -    foreach my $part_ (fs::get::holes($all_hds)) { +    my @to_add = @$to_add; +  +    foreach my $part_ (fs::get::holes($all_hds, 'non_readonly')) {  	my ($start, $size, $dev) = @$part_{"start", "size", "rootDevice"}; -	my $part; -	while (suggest_part($part = { start => $start, size => 0, maxsize => $size, rootDevice => $dev },  -			    $all_hds, $to_add)) { +	next if $o_hd && (($o_hd->{device} || $o_hd->{VG_name}) ne $dev); +	my ($part, $suggested); +	while ($suggested = suggest_part($part = { start => $start, size => 0, maxsize => $size, rootDevice => $dev },  +					 $all_hds, \@to_add, $o_hd)) {  	    my $hd = fs::get::part2hd($part, $all_hds); -	    add($hd, $part, $all_hds, {}); +	    add($hd, $part, $all_hds, { primaryOrExtended => $part->{primaryOrExtended} });  	    $size -= $part->{size} + $part->{start} - $start;  	    $start = $part->{start} + $part->{size}; + 	    @to_add = grep { $_ != $suggested } @to_add;  	}      }  }  sub auto_allocate { -    my ($all_hds, $o_suggestions) = @_; +    my ($all_hds, $o_suggestions, $o_target) = @_;      my $before = listlength(fs::get::fstab($all_hds)); +    #- Make sure we don't finish with more than one /boot/EFI mount point +    if (is_uefi()) { +        delete $_->{mntpoint} foreach grep { $_->{mntpoint} eq '/boot/EFI' } fs::get::fstab($all_hds); +    } + +    auto_allocate_bios_boot_parts($all_hds, $o_target) if !is_uefi(); +      my $suggestions = $o_suggestions || $suggestions{simple}; -    allocatePartitions($all_hds, $suggestions); +    allocatePartitions($all_hds, $suggestions, $o_target);      if ($o_suggestions) {  	auto_allocate_raids($all_hds, $suggestions); @@ -487,6 +564,28 @@ sub auto_allocate {  	    die N("Nothing to do");  	}      } + +    #- Don't suggest mount points on other drives when installing on a removable disk +    return if $o_target && $o_target->{is_removable}; + +    my @fstab = fs::get::fstab($all_hds); +    fs::mount_point::suggest_mount_points_always(\@fstab); +} + +sub auto_allocate_bios_boot_parts { +    my ($all_hds, $o_hd) = @_; +    foreach my $hd (@{$all_hds->{hds}}) { +	# skip if not the selected device +	next if $o_hd && ($o_hd->{device} ne $hd->{device}); +	# skip non-GPT disks +	next if ($hd->{pt_table_type} || partition_table::default_type($hd)) ne 'gpt'; +	# check if a BIOS boot partition already exists +	my @parts = map { partition_table::get_normal_parts($_) } $hd; +	next if any { isBIOS_GRUB($_) } @parts; +	# try to allocate a BIOS boot partition +	my $suggest = { mntpoint => "", size => MB(1), pt_type => 'BIOS_GRUB', ratio => 1, maxsize => MB(2) }; +	allocatePartitions($all_hds, [ $suggest ], $hd); +    }  }  sub auto_allocate_raids { @@ -541,99 +640,38 @@ sub auto_allocate_vgs {      1;  } -sub undo_prepare { -    my ($all_hds) = @_; -    require Data::Dumper; -    $Data::Dumper::Purity = 1; -    foreach (@{$all_hds->{hds}}) { -	my @h = @$_{@partition_table::fields2save}; -	push @{$_->{undo}}, Data::Dumper->Dump([\@h], ['$h']); -    } -} -sub undo { -    my ($all_hds) = @_; -    foreach (@{$all_hds->{hds}}) { -	my $code = pop @{$_->{undo}} or next; -	my $h; eval $code; -	@$_{@partition_table::fields2save} = @$h; - -	if ($_->{hasBeenDirty}) { -	    partition_table::will_tell_kernel($_, 'force_reboot'); #- next action needing write_partitions will force it. We can not do it now since more undo may occur, and we must not needReboot now -	} -    } -     -} -  sub change_type {      my ($type, $hd, $part) = @_;      $type->{pt_type} != $part->{pt_type} || $type->{fs_type} ne $part->{fs_type} or return;      fs::type::check($type->{fs_type}, $hd, $part); +    delete $part->{device_UUID};      $hd->{isDirty} = 1;      $part->{mntpoint} = '' if isSwap($part) && $part->{mntpoint} eq "swap"; -    $part->{mntpoint} = '' if isRawLVM($type) || isRawRAID($type); +    $part->{mntpoint} = '' if fs::type::cannotBeMountable($part);      set_isFormatted($part, 0);      fs::type::set_type_subpart($part, $type);      fs::mount_options::rationalize($part);      1;  } -sub rescuept($) { -    my ($hd) = @_; -    my ($ext, @hd); - -    my $dev = devices::make($hd->{device}); -    open(my $F, "rescuept $dev|"); -    local $_; -    while (<$F>) { -	my ($st, $si, $id) = /start=\s*(\d+),\s*size=\s*(\d+),\s*Id=\s*(\d+)/ or next; -	my $part = { start => $st, size => $si }; -	fs::type::set_pt_type($part, hex($id)); -	if (isExtended($part)) { -	    $ext = $part; -	} else { -	    push @hd, $part; -	} -    } -    close $F or die "rescuept failed"; - -    partition_table::raw::zero_MBR($hd); -    foreach (@hd) { -	my $b = partition_table::verifyInside($_, $ext); -	if ($b) { -	    $_->{start}--; -	    $_->{size}++; -	} -	local $_->{notFormatted}; - -	partition_table::add($hd, $_, ($b ? 'Extended' : 'Primary'), 1); -    } -} - -sub compare_with_proc_partitions { -    my ($hd) = @_; +=item partition_table_clear_and_initialize($lvms, $hd, $o_in, $o_type, $b_warn) = @_; -    my @l1 = partition_table::get_normal_parts($hd); -    my @l2 = grep { $_->{rootDevice} eq $hd->{device} } read_proc_partitions([$hd]); +wrapper around partition_table::initialize() but which also create a singleton VG +automatically (so that it's easier for the user) -    #- /proc/partitions includes partition with type "empty" and a non-null size -    #- so add them for comparison -    my ($len1, $len2) = (int(@l1) + $hd->{primary}{nb_special_empty}, int(@l2)); +=cut -    if ($len1 != $len2 && arch() ne 'ppc') { -	die sprintf( -		    "/proc/partitions does not agree with drakx %d != %d:\n%s\n", $len1, $len2, -		    "/proc/partitions: " . join(", ", map { "$_->{device} ($_->{rootDevice})" } @l2)); +sub partition_table_clear_and_initialize { +    my ($lvms, $hd, $o_in, $o_type, $b_warn) = @_; +    partition_table::initialize($hd, $o_type); +    if ($hd->isa('partition_table::lvm')) { +	if ($b_warn && $o_in) { +	    $o_in->ask_okcancel_('', N("ALL existing partitions and their data will be lost on drive %s", partition_table::description($hd))) or return; +	} +	require lvm; +	lvm::check($o_in ? $o_in->do_pkgs : do_pkgs_standalone->new) if $::isStandalone; +	lvm::create_singleton_vg($lvms, fs::get::hds_fstab($hd));      } -    $len2; -} - -sub use_proc_partitions { -    my ($hd) = @_; - -    partition_table::raw::zero_MBR($hd); -    $hd->{readonly} = 1; -    $hd->{getting_rid_of_readonly_allowed} = 1; -    $hd->{primary} = { normal => [ grep { $_->{rootDevice} eq $hd->{device} } read_proc_partitions([$hd]) ] };  }  1; | 
