1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
|
<?php
/**
*
* @package testing
* @copyright (c) 2008 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/
require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
require_once dirname(__FILE__) . '/../../phpBB/includes/utf/utf_tools.php';
class phpbb_request_var_test extends phpbb_test_case
{
/**
* Makes sure request_var has its standard behaviour.
*/
protected function setUp()
{
parent::setUp();
request_var(false, false, false, false, false);
}
/**
* @dataProvider request_variables
*/
public function test_post($variable_value, $default, $multibyte, $expected)
{
$variable_name = 'name';
$this->unset_variables($variable_name);
$_POST[$variable_name] = $variable_value;
$_REQUEST[$variable_name] = $variable_value;
$result = request_var($variable_name, $default, $multibyte);
$label = 'Requesting POST variable, converting from ' . gettype($variable_value) . ' to ' . gettype($default) . (($multibyte) ? ' multibyte' : '');
$this->assertEquals($expected, $result, $label);
}
/**
* @dataProvider request_variables
*/
public function test_get($variable_value, $default, $multibyte, $expected)
{
$variable_name = 'name';
$this->unset_variables($variable_name);
$_GET[$variable_name] = $variable_value;
$_REQUEST[$variable_name] = $variable_value;
$result = request_var($variable_name, $default, $multibyte);
$label = 'Requesting GET variable, converting from ' . gettype($variable_value) . ' to ' . gettype($default) . (($multibyte) ? ' multibyte' : '');
$this->assertEquals($expected, $result, $label);
}
/**
* @dataProvider request_variables
*/
public function test_cookie($variable_value, $default, $multibyte, $expected)
{
$variable_name = 'name';
$this->unset_variables($variable_name);
$_GET[$variable_name] = false;
$_POST[$variable_name] = false;
$_REQUEST[$variable_name] = false;
$_COOKIE[$variable_name] = $variable_value;
$result = request_var($variable_name, $default, $multibyte, true);
$label = 'Requesting COOKIE variable, converting from ' . gettype($variable_value) . ' to ' . gettype($default) . (($multibyte) ? ' multibyte' : '');
$this->assertEquals($expected, $result, $label);
}
/**
* Helper for unsetting globals
*/
private function unset_variables($var)
{
unset($_GET[$var], $_POST[$var], $_REQUEST[$var], $_COOKIE[$var]);
}
/**
* @dataProvider deep_access
* Only possible with 3.1.x (later)
*/
public function test_deep_multi_dim_array_access($path, $default, $expected)
{
$this->unset_variables('var');
// cannot set $_REQUEST directly because in phpbb_request implementation
// $_REQUEST = $_POST + $_GET
$_POST['var'] = array(
0 => array(
'b' => array(
true => array(
5 => 'c',
6 => 'd',
),
),
),
2 => array(
3 => array(
false => 5,
),
),
);
$result = request_var($path, $default);
$this->assertEquals($expected, $result, 'Testing deep access to multidimensional input arrays: ' . $path);
}
public static function deep_access()
{
return array(
// array(path, default, expected result)
array(array('var', 0, 'b', true, 5), '', 'c'),
array(array('var', 0, 'b', true, 6), '', 'd'),
array(array('var', 2, 3, false), 0, 5),
array(array('var', 0, 'b', true), array(0 => ''), array(5 => 'c', 6 => 'd')),
);
}
public static function request_variables()
{
return array(
// strings
array('abc', '', false, 'abc'),
array(' some spaces ', '', true, 'some spaces'),
array("\r\rsome\rcarriage\r\rreturns\r", '', true, "some\ncarriage\n\nreturns"),
array("\n\nsome\ncarriage\n\nreturns\n", '', true, "some\ncarriage\n\nreturns"),
array("\r\n\r\nsome\r\ncarriage\r\n\r\nreturns\r\n", '', true, "some\ncarriage\n\nreturns"),
array("we\xC2\xA1rd\xE1\x9A\x80ch\xCE\xB1r\xC2\xADacters", '', true, "we\xC2\xA1rd\xE1\x9A\x80ch\xCE\xB1r\xC2\xADacters"),
array("we\xC2\xA1rd\xE1\x9A\x80ch\xCE\xB1r\xC2\xADacters", '', false, "we??rd???ch??r??acters"),
array("Some <html> \"entities\" like &", '', true, "Some <html> "entities" like &"),
// integers
array('1234', 0, false, 1234),
array('abc', 12, false, 0),
array('324abc', 0, false, 324),
// string to array
array('123', array(0), false, array()),
array('123', array(''), false, array()),
// 1 dimensional arrays
array(
// input:
array('123', 'abc'),
// default:
array(''),
false,
// expected:
array('123', 'abc')
),
array(
// input:
array('123', 'abc'),
// default:
array(999),
false,
// expected:
array(123, 0)
),
array(
// input:
array('xyz' => '123', 'abc' => 'abc'),
// default:
array('' => ''),
false,
// expected:
array('xyz' => '123', 'abc' => 'abc')
),
array(
// input:
array('xyz' => '123', 'abc' => 'abc'),
// default:
array('' => 0),
false,
// expected:
array('xyz' => 123, 'abc' => 0)
),
// 2 dimensional arrays
array(
// input:
'',
// default:
array(array(0)),
false,
// expected:
array()
),
array(
// input:
array(
'xyz' => array('123', 'def'),
'abc' => 'abc'
),
// default:
array('' => array('')),
false,
// expected:
array(
'xyz' => array('123', 'def'),
'abc' => array()
)
),
array(
// input:
array(
'xyz' => array('123', 'def'),
'abc' => 'abc'
),
// default:
array('' => array(0)),
false,
// expected:
array(
'xyz' => array(123, 0),
'abc' => array()
)
),
array(
// input:
array(
0 => array(0 => array(3, '4', 'ab'), 1 => array()),
1 => array(array(3, 4)),
),
// default:
array(0 => array(0 => array(0))),
false,
// expected:
array(
0 => array(0 => array(3, 4, 0), 1 => array()),
1 => array(array(3, 4))
)
),
array(
// input:
array(
'ü' => array(array('c' => 'd')),
'ä' => array(4 => array('a' => 2, 'ö' => 3)),
),
// default:
array('' => array(0 => array('' => 0))),
false,
// expected:
array(
'??' => array(4 => array('a' => 2, '??' => 3)),
)
),
array(
// input:
array(
'ü' => array(array('c' => 'd')),
'ä' => array(4 => array('a' => 2, 'ö' => 3)),
),
// default:
array('' => array(0 => array('' => 0))),
true,
// expected:
array(
'ü' => array(array('c' => 0)),
'ä' => array(4 => array('a' => 2, 'ö' => 3)),
)
),
);
}
}
|
