1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
|
<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
class phpbb_request_test extends phpbb_test_case
{
/** @var \phpbb\request\type_cast_helper_interface */
private $type_cast_helper;
/** @var \phpbb\request\request */
private $request;
protected function setUp()
{
// populate super globals
$_POST['test'] = 1;
$_GET['test'] = 2;
$_COOKIE['test'] = 3;
$_REQUEST['test'] = 3;
$_GET['unset'] = '';
$_FILES['test'] = array(
'name' => 'file',
'tmp_name' => 'tmp',
'size' => 256,
'type' => 'application/octet-stream',
'error' => UPLOAD_ERR_OK,
);
$_SERVER['HTTP_HOST'] = 'example.com';
$_SERVER['HTTP_ACCEPT'] = 'application/json';
$_SERVER['HTTP_SOMEVAR'] = '<value>';
$this->type_cast_helper = $this->getMock('\phpbb\request\type_cast_helper_interface');
$this->request = new \phpbb\request\request($this->type_cast_helper);
}
public function test_toggle_super_globals()
{
$this->assertTrue($this->request->super_globals_disabled(), 'Superglobals were not disabled');
$this->request->enable_super_globals();
$this->assertFalse($this->request->super_globals_disabled(), 'Superglobals were not enabled');
$this->assertEquals(1, $_POST['test'], 'Checking $_POST after enable_super_globals');
$this->assertEquals(2, $_GET['test'], 'Checking $_GET after enable_super_globals');
$this->assertEquals(3, $_COOKIE['test'], 'Checking $_COOKIE after enable_super_globals');
$this->assertEquals(3, $_REQUEST['test'], 'Checking $_REQUEST after enable_super_globals');
$this->assertEquals(256, $_FILES['test']['size']);
$_POST['x'] = 2;
$this->assertEquals($_POST, $GLOBALS['_POST'], 'Checking whether $_POST can still be accessed via $GLOBALS[\'_POST\']');
}
public function test_server()
{
$this->assertEquals('example.com', $this->request->server('HTTP_HOST'));
}
public function test_server_escaping()
{
$this->type_cast_helper
->expects($this->once())
->method('recursive_set_var')
->with(
$this->anything(),
'',
true
);
$this->request->server('HTTP_SOMEVAR');
}
public function test_header()
{
$this->assertEquals('application/json', $this->request->header('Accept'));
}
public function test_header_escaping()
{
$this->type_cast_helper
->expects($this->once())
->method('recursive_set_var')
->with(
$this->anything(),
'',
true
);
$this->request->header('SOMEVAR');
}
public function test_file()
{
$file = $this->request->file('test');
$this->assertEquals('file', $file['name']);
$this->assertEquals('tmp', $file['tmp_name']);
$this->assertEquals(256, $file['size']);
$this->assertEquals('application/octet-stream', $file['type']);
$this->assertEquals(UPLOAD_ERR_OK, $file['error']);
}
public function test_file_not_exists()
{
$file = $this->request->file('404');
$this->assertTrue(is_array($file));
$this->assertTrue(empty($file));
}
/**
* Checks that directly accessing $_POST will trigger
* an error.
*/
public function test_disable_post_super_global()
{
$this->setExpectedTriggerError(E_USER_ERROR);
$_POST['test'] = 3;
}
public function test_is_set_post()
{
$this->assertTrue($this->request->is_set_post('test'));
$this->assertFalse($this->request->is_set_post('unset'));
}
public function test_is_ajax_without_ajax()
{
$this->assertFalse($this->request->is_ajax());
}
public function test_is_ajax_with_ajax()
{
$this->request->enable_super_globals();
$_SERVER['HTTP_X_REQUESTED_WITH'] = 'XMLHttpRequest';
$this->request = new \phpbb\request\request($this->type_cast_helper);
$this->assertTrue($this->request->is_ajax());
}
public function data_is_secure()
{
return array(
array(
array(
'HTTPS' => 'on',
),
true,
),
array(
array(
'HTTPS' => '1',
),
true,
),
array(
array(
'HTTPS' => 'yes',
),
true,
),
array(
array(
'HTTPS' => 1,
),
true,
),
array(
array(
'HTTPS' => 'off',
),
false,
),
array(
array(
'HTTPS' => '0',
),
false,
),
array(
array(
'HTTPS' => 0,
),
false,
),
array(
array(
'HTTPS' => '',
),
false,
),
array(
array(
'HTTPS' => 'off',
'HTTP_X_FORWARDED_PROTO' => 'https',
),
true,
),
array(
array(
'HTTPS' => 'on',
'HTTP_X_FORWARDED_PROTO' => 'http',
),
true,
),
array(
array(
'HTTPS' => 'off',
'HTTP_X_FORWARDED_PROTO' => 'http',
),
false,
),
array(
array(
'HTTP_X_FORWARDED_PROTO' => 'http',
),
false,
),
array(
array(
'HTTP_X_FORWARDED_PROTO' => 'https',
),
true,
),
array(
array(
'HTTPS' => 'on',
'HTTP_X_FORWARDED_PROTO' => 'http',
),
true,
),
);
}
/**
* @dataProvider data_is_secure
*/
public function test_is_secure($server_data, $expected)
{
$this->assertFalse($this->request->is_secure());
$this->request->enable_super_globals();
$_SERVER = $server_data;
$this->request = new \phpbb\request\request($this->type_cast_helper);
$this->assertSame($expected, $this->request->is_secure());
}
public function test_variable_names()
{
$expected = array('test', 'unset');
$result = $this->request->variable_names();
$this->assertEquals($expected, $result);
}
/**
* Makes sure super globals work properly after these tests
*/
protected function tearDown()
{
$this->request->enable_super_globals();
}
}
|
