1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
|
<?php
/**
*
* @package testing
* @copyright (c) 2008 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
require_once dirname(__FILE__) . '/../../phpBB/includes/utf/utf_tools.php';
class phpbb_dbal_select_test extends phpbb_database_test_case
{
public function getDataSet()
{
return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/three_users.xml');
}
public function return_on_error_select_data()
{
return array(
array('phpbb_users', "username_clean = 'bertie'", array(array('username_clean' => 'bertie'))),
array('phpbb_users', 'username_clean syntax_error', false),
);
}
/**
* @dataProvider return_on_error_select_data
*/
public function test_return_on_error_select($table, $where, $expected)
{
$db = $this->new_dbal();
$db->sql_return_on_error(true);
$result = $db->sql_query('SELECT username_clean
FROM ' . $table . '
WHERE ' . $where . '
ORDER BY user_id ASC');
$db->sql_return_on_error(false);
$this->assertEquals($expected, $db->sql_fetchrowset($result));
}
public function fetchrow_data()
{
return array(
array('', array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
array('user_id = 2', array(array('username_clean' => 'foobar'))),
array("username_clean = 'bertie'", array(array('username_clean' => 'bertie'))),
array("username_clean = 'phpBB'", array()),
);
}
/**
* @dataProvider fetchrow_data
*/
public function test_fetchrow($where, $expected)
{
$db = $this->new_dbal();
$result = $db->sql_query('SELECT username_clean
FROM phpbb_users
' . (($where) ? ' WHERE ' . $where : '') . '
ORDER BY user_id ASC');
$ary = array();
while ($row = $db->sql_fetchrow($result))
{
$ary[] = $row;
}
$db->sql_freeresult($result);
$this->assertEquals($expected, $ary);
}
/**
* @dataProvider fetchrow_data
*/
public function test_fetchrowset($where, $expected)
{
$db = $this->new_dbal();
$result = $db->sql_query('SELECT username_clean
FROM phpbb_users
' . (($where) ? ' WHERE ' . $where : '') . '
ORDER BY user_id ASC');
$this->assertEquals($expected, $db->sql_fetchrowset($result));
$db->sql_freeresult($result);
}
public function fetchfield_data()
{
return array(
array('', array('barfoo', 'foobar', 'bertie')),
array('user_id = 2', array('foobar')),
);
}
/**
* @dataProvider fetchfield_data
*/
public function test_fetchfield($where, $expected)
{
$db = $this->new_dbal();
$result = $db->sql_query('SELECT username_clean
FROM phpbb_users
' . (($where) ? ' WHERE ' . $where : '') . '
ORDER BY user_id ASC');
$ary = array();
while ($row = $db->sql_fetchfield('username_clean'))
{
$ary[] = $row;
}
$db->sql_freeresult($result);
$this->assertEquals($expected, $ary);
}
public function query_limit_data()
{
return array(
array(0, 0, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
array(0, 1, array(array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
array(1, 0, array(array('username_clean' => 'barfoo'))),
array(1, 2, array(array('username_clean' => 'bertie'))),
array(2, 0, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array(2, 2, array(array('username_clean' => 'bertie'))),
array(2, 5, array()),
array(10, 1, array(array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
array(10, 5, array()),
);
}
/**
* @dataProvider query_limit_data
*/
public function test_query_limit($total, $offset, $expected)
{
$db = $this->new_dbal();
$result = $db->sql_query_limit('SELECT username_clean
FROM phpbb_users
ORDER BY user_id ASC', $total, $offset);
$ary = array();
while ($row = $db->sql_fetchrow($result))
{
$ary[] = $row;
}
$db->sql_freeresult($result);
$this->assertEquals($expected, $ary);
}
public function like_expression_data()
{
// * = any_char; # = one_char
return array(
array('barfoo', array(array('username_clean' => 'barfoo'))),
array('bar', array()),
array('bar*', array(array('username_clean' => 'barfoo'))),
array('*bar*', array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('b*r', array()),
array('b*e', array(array('username_clean' => 'bertie'))),
array('#b*e', array()),
array('b####e', array(array('username_clean' => 'bertie'))),
);
}
/**
* @dataProvider like_expression_data
*/
public function test_like_expression($like_expression, $expected)
{
$db = $this->new_dbal();
$like_expression = str_replace('*', $db->any_char, $like_expression);
$like_expression = str_replace('#', $db->one_char, $like_expression);
$where = ($like_expression) ? 'username_clean ' . $db->sql_like_expression($like_expression) : '';
$result = $db->sql_query('SELECT username_clean
FROM phpbb_users
' . (($where) ? ' WHERE ' . $where : '') . '
ORDER BY user_id ASC');
$this->assertEquals($expected, $db->sql_fetchrowset($result));
$db->sql_freeresult($result);
}
public function in_set_data()
{
return array(
array('user_id', 3, false, false, array(array('username_clean' => 'bertie'))),
array('user_id', 3, false, true, array(array('username_clean' => 'bertie'))),
array('user_id', 3, true, false, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('user_id', 3, true, true, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('username_clean', 'bertie', false, false, array(array('username_clean' => 'bertie'))),
array('username_clean', 'bertie', false, true, array(array('username_clean' => 'bertie'))),
array('username_clean', 'bertie', true, false, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('username_clean', 'bertie', true, true, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('user_id', array(3), false, false, array(array('username_clean' => 'bertie'))),
array('user_id', array(3), false, true, array(array('username_clean' => 'bertie'))),
array('user_id', array(3), true, false, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('user_id', array(3), true, true, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'))),
array('user_id', array(1, 3), false, false, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'bertie'))),
array('user_id', array(1, 3), false, true, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'bertie'))),
array('user_id', array(1, 3), true, false, array(array('username_clean' => 'foobar'))),
array('user_id', array(1, 3), true, true, array(array('username_clean' => 'foobar'))),
array('username_clean', '', false, false, array()),
array('username_clean', '', false, true, array()),
array('username_clean', '', true, false, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
array('username_clean', '', true, true, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
array('user_id', array(), false, true, array()),
array('user_id', array(), true, true, array(array('username_clean' => 'barfoo'),
array('username_clean' => 'foobar'),
array('username_clean' => 'bertie'))),
// These here would throw errors and therefor $result should be false.
// Removing for now because SQLite accepts empty IN() syntax
/*array('user_id', array(), false, false, false, true),
array('user_id', array(), true, false, false, true),*/
);
}
/**
* @dataProvider in_set_data
*/
public function test_in_set($field, $array, $negate, $allow_empty_set, $expected, $catch_error = false)
{
$db = $this->new_dbal();
if ($catch_error)
{
$db->sql_return_on_error(true);
}
$result = $db->sql_query('SELECT username_clean
FROM phpbb_users
WHERE ' . $db->sql_in_set($field, $array, $negate, $allow_empty_set) . '
ORDER BY user_id ASC');
if ($catch_error)
{
$db->sql_return_on_error(false);
}
$this->assertEquals($expected, $db->sql_fetchrowset($result));
$db->sql_freeresult($result);
}
public function build_array_data()
{
return array(
array(array('username_clean' => 'barfoo'), array(array('username_clean' => 'barfoo'))),
array(array('username_clean' => 'barfoo', 'user_id' => 1), array(array('username_clean' => 'barfoo'))),
array(array('username_clean' => 'barfoo', 'user_id' => 2), array()),
// These here would throw errors and therefor $result should be false.
array(array(), false, true),
array('no_array', false, true),
array(0, false, true),
);
}
/**
* @dataProvider build_array_data
*/
public function test_build_array($assoc_ary, $expected, $catch_error = false)
{
$db = $this->new_dbal();
if ($catch_error)
{
$db->sql_return_on_error(true);
}
$sql = 'SELECT username_clean
FROM phpbb_users
WHERE ' . $db->sql_build_array('SELECT', $assoc_ary) . '
ORDER BY user_id ASC';
$result = $db->sql_query($sql);
if ($catch_error)
{
$db->sql_return_on_error(false);
}
$this->assertEquals($expected, $db->sql_fetchrowset($result));
$db->sql_freeresult($result);
}
public function test_nested_transactions()
{
$db = $this->new_dbal();
// nested transactions should work on systems that do not require
// buffering of nested transactions, so ignore the ones that need
// buffering
if ($db->sql_buffer_nested_transactions())
{
return;
}
$sql = 'SELECT user_id FROM phpbb_users ORDER BY user_id ASC';
$result1 = $db->sql_query($sql);
$db->sql_transaction('begin');
$result2 = $db->sql_query($sql);
$row = $db->sql_fetchrow($result2);
$db->sql_transaction('commit');
$this->assertEquals('1', $row['user_id']);
}
/**
* fix for PHPBB3-10307
*/
public function test_sql_fetchrow_returns_false_when_empty()
{
$db = $this->new_dbal();
$sql = 'SELECT * FROM (SELECT 1) AS TBL WHERE 1 = 0';
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$db->sql_freeresult($result);
$this->assertSame(false, $row);
}
public function test_get_row_count()
{
$this->assertSame(
3,
(int) $this->new_dbal()->get_row_count('phpbb_users'),
"Failed asserting that user table has exactly 3 rows."
);
}
public function test_get_estimated_row_count()
{
$actual = $this->new_dbal()->get_estimated_row_count('phpbb_users');
if (is_string($actual) && isset($actual[0]) && $actual[0] === '~')
{
$actual = substr($actual, 1);
}
$this->assertGreaterThan(
1,
$actual,
"Failed asserting that estimated row count of user table is greater than 1."
);
}
}
|