aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [feature/template-engine] Check return value of display() in assign_display().Oleg Pudeyev2011-05-011-1/+5
| | | | | | If display() failed, propagate the failure out of assign_display(). PHPBB3-9726
* [feature/template-engine] Removed $this from new phpbb_template_compile calls.Oleg Pudeyev2011-04-261-3/+3
| | | | | | The compile class no longer takes template as a parameter. PHPBB3-9726
* [feature/template-engine] Fix negative variable expressionsIgor Wiedler2011-04-254-13/+9
| | | | | | | | | | | | | compile_tag_if had the flawed approach of adding an isset statement for all variables to the beginning of the if. This fails for negative expressions, and checking those takes a considerable effort. The easier solution is to make the variable expression itself conditional, defaulting to null if it is not set. Thanks to naderman for the solution. PHPBB3-9726
* [feature/template-engine] Added a test for reuse of loop identifiers.Oleg Pudeyev2011-04-252-0/+16
| | | | | | | | | This currently does not pass, thus it is commented out. The reuse appears implausible in the same file, however it may be also done across template files where it is much harder to detect. PHPBB3-9726
* [feature/template-engine] Corrected miscompilation of loop size constructs.Oleg Pudeyev2011-04-253-1/+47
| | | | PHPBB3-9726
* [feature/template-engine] Created a script to compile templates.Oleg Pudeyev2011-04-241-0/+24
| | | | | | | Script takes path to template as the only argument and outputs the compiled template to standard output. PHPBB3-9726
* [feature/template-engine] Corrected an off-by-one error in nested namespaces.Oleg Pudeyev2011-04-244-4/+29
| | | | | | | | This error resulted in a dot from the namespace being placed into variable reference in compiled template code, thus creating bogus compiled template code. PHPBB3-9726
* [feature/template-engine] Added a test for multilevel references in loops.Oleg Pudeyev2011-04-242-0/+24
| | | | | | | | | This currently fails. This test is a reduced version of permission_mask template in acp, which is not correctly compiled by the current template engine code. PHPBB3-9726
* [feature/template-engine] Deleted silencing of notices.Oleg Pudeyev2011-04-242-3/+5
| | | | | | | The code is now supposed to be notice-free, therefore there is no need to have the notices silenced. PHPBB3-9726
* [feature/template-engine] Deleted $template from phpbb_template_compile class.Oleg Pudeyev2011-04-243-96/+74
| | | | | | | | | | | | | phpbb_template_compile is now much simpler. It takes complete file paths as inputs, either source template path or source template path and output compiled template path. The number of methods also went down to two - compile template and returned compiled text or compile and write to file. phpbb_compile class is responsible for determining source and compiled paths. It already had all the data necessary for this, now the code is in the same place as the data it uses. PHPBB3-9726
* [ticket/9924] Pass template instance into $template->display hookIgor Wiedler2011-04-241-1/+1
| | | | | | | This is a cherry-pick of 053cf790a93e9cfb521f484901d79c72783f868f which appears to have been partially reverted here. PHPBB3-9924
* [feature/template-engine] Removed a useless space.Oleg Pudeyev2011-04-241-1/+1
| | | | PHPBB3-9726
* [feature/template-engine] Delete class_exists checks, rely on autoloading.Oleg Pudeyev2011-04-241-10/+0
| | | | PHPBB3-9726
* [feature/template-engine] Allow leading underscores in variable names.Oleg Pudeyev2011-04-243-3/+33
| | | | | | Subsilver uses ._file in overall_header. PHPBB3-9726
* [feature/template-engine] Fix recompilation logic.Oleg Pudeyev2011-04-242-11/+14
| | | | | | | | | Do not change $recompile from true to false - any recompilation condition alone is sufficient to force recompilation. Also uncomment the nonexistent file test which passes with this fix. PHPBB3-9726
* [feature/template-engine] Adjust path in includephp template.Oleg Pudeyev2011-04-241-1/+1
| | | | | | Now that tests are run from top level the '..' is wrong. PHPBB3-9726
* [feature/template-engine] Delete ?>, add newline at EOF.Oleg Pudeyev2011-04-232-3/+1
| | | | PHPBB3-9726
* [feature/template-engine] Improved template engine.Marek A. Ruszczynski2011-04-233-877/+1204
| | | | PHPBB3-9726
* [feature/template-engine] Update tests.Marek A. Ruszczynski2011-04-235-55/+30
| | | | PHPBB3-9726
* Merge branch 'develop-olympus' into developAndreas Fischer2011-04-231-1/+1
|\ | | | | | | | | * develop-olympus: [ticket/10147] Corrected a typo in includes/functions_template.php.
| * Merge branch 'ticket/p/10147' into develop-olympusAndreas Fischer2011-04-231-1/+1
| |\ | | | | | | | | | | | | * ticket/p/10147: [ticket/10147] Corrected a typo in includes/functions_template.php.
| | * [ticket/10147] Corrected a typo in includes/functions_template.php.Oleg Pudeyev2011-04-231-1/+1
| | | | | | | | | | | | PHPBB3-10147
* | | Merge branch 'develop-olympus' into developAndreas Fischer2011-04-221-1/+11
|\ \ \ | |/ / | | | | | | | | | | | | | | | * develop-olympus: [ticket/10141] Save a hash lookup when value is not in cache. [ticket/10141] Split double-assignment into conditional and unconditional part. [ticket/10141] Use a cache in $auth->_fill_acl() for better performance.
| * | Merge branch 'ticket/p/10141' into develop-olympusAndreas Fischer2011-04-221-1/+11
| |\ \ | | |/ | |/| | | | | | | | | | | | | * ticket/p/10141: [ticket/10141] Save a hash lookup when value is not in cache. [ticket/10141] Split double-assignment into conditional and unconditional part. [ticket/10141] Use a cache in $auth->_fill_acl() for better performance.
| | * [ticket/10141] Save a hash lookup when value is not in cache.Oleg Pudeyev2011-04-211-3/+7
| | | | | | | | | | | | PHPBB3-10141
| | * [ticket/10141] Split double-assignment into conditional and unconditional part.Andreas Fischer2011-04-221-7/+5
| | | | | | | | | | | | PHPBB3-10141
| | * [ticket/10141] Use a cache in $auth->_fill_acl() for better performance.Bart van Bragt2011-04-211-2/+10
| | | | | | | | | | | | | | | | | | | | | Many sequences being converted are the same. Use a local cache to convert each sequence once, speeding up the function. PHPBB3-10141
* | | Merge branch 'develop-olympus' into developOleg Pudeyev2011-04-221-1/+1
|\ \ \ | |/ / | | | | | | | | | * develop-olympus: [ticket/10137] Remove unintended space at end of PHP_URL_FOPEN_SUPPORT_EXPLAIN.
| * | Merge branch 'ticket/bantu/10137' into develop-olympusOleg Pudeyev2011-04-221-1/+1
| |\ \ | | | | | | | | | | | | | | | | * ticket/bantu/10137: [ticket/10137] Remove unintended space at end of PHP_URL_FOPEN_SUPPORT_EXPLAIN.
| | * | [ticket/10137] Remove unintended space at end of PHP_URL_FOPEN_SUPPORT_EXPLAIN.Andreas Fischer2011-04-221-1/+1
| | |/ | | | | | | | | | PHPBB3-10137
* | | Merge branch 'develop-olympus' into developOleg Pudeyev2011-04-222-2/+2
|\ \ \ | |/ / | | | | | | | | | | | | * develop-olympus: [ticket/10105] Update AIM express link. [ticket/10105] Update AIM application download link.
| * | Merge branch 'ticket/bantu/10105' into develop-olympusOleg Pudeyev2011-04-222-2/+2
| |\ \ | | |/ | |/|
| | * [ticket/10105] Update AIM express link.Andreas Fischer2011-04-222-2/+2
| | | | | | | | | | | | PHPBB3-10105
| | * [ticket/10105] Update AIM application download link.Andreas Fischer2011-04-222-2/+2
| |/ | | | | | | PHPBB3-10105
* | Merge branch 'ticket/bantu/10139' into developOleg Pudeyev2011-04-212-34/+34
|\ \
| * | [ticket/10139] Make signatures of set_atomic() consistent by using $new_value.Andreas Fischer2011-04-191-3/+3
| | | | | | | | | | | | PHPBB3-10139
| * | [ticket/10139] Rename $cache to $use_cache to avoid confusion with cache objectAndreas Fischer2011-04-192-32/+32
|/ / | | | | | | PHPBB3-10139
* | Merge branch 'ticket/erikfrerejean/10006' into developOleg Pudeyev2011-04-194-0/+57
|\ \
| * | [ticket/10006] Remove unneeded if statementsErik Frèrejean2011-04-182-10/+0
| | | | | | | | | | | | | | | | | | Remove some of the additional `if (isset)` checks PHPBB3-10006
| * | [ticket/10006] Remove return valuesErik Frèrejean2011-04-182-11/+4
| | | | | | | | | | | | | | | | | | Remove some unneeded return values PHPBB3-10006
| * | [ticket/10006] More testingErik Frèrejean2011-04-181-2/+5
| | | | | | | | | | | | | | | | | | Change the DB test to test agains new cache/config mock objects PHPBB3-10006
| * | [ticket/10006] Tweak the tests a bitErik Frèrejean2011-04-182-2/+5
| | | | | | | | | | | | PHPBB3-10006
| * | [ticket/10006] Add phpbb_config::deleteErik Frèrejean2011-04-184-0/+68
| | | | | | | | | | | | | | | | | | Add the missing `phpbb_config::delete` method to the config class PHPBB3-10006
* | | Merge branch 'ticket/p/7252' into developAndreas Fischer2011-04-181-1/+0
|\ \ \ | | | | | | | | | | | | | | | | * ticket/p/7252: [ticket/7252] Removed an outdated comment pertaining to PHP 4.x.
| * | | [ticket/7252] Removed an outdated comment pertaining to PHP 4.x.Oleg Pudeyev2011-04-171-1/+0
|/ / / | | | | | | | | | PHPBB3-7252
* | | Merge branch 'develop-olympus' into developOleg Pudeyev2011-04-171-25/+26
|\ \ \ | | |/ | |/| | | | | | | * develop-olympus: [ticket/10109] Fix "Undefined Index" errors when copying a topic.
| * | Merge branch 'ticket/nickvergessen/10109' into develop-olympusOleg Pudeyev2011-04-171-25/+26
| |\ \ | | | | | | | | | | | | | | | | * ticket/nickvergessen/10109: [ticket/10109] Fix "Undefined Index" errors when copying a topic.
| | * | [ticket/10109] Fix "Undefined Index" errors when copying a topic.Joas Schilling2011-04-071-25/+26
| | | | | | | | | | | | | | | | PHPBB3-10109
* | | | Merge branch 'develop-olympus' into developOleg Pudeyev2007-01-031-15/+20
|\ \ \ \ | |/ / / | | | / | |_|/ |/| | | | | | | | | | | * develop-olympus: [ticket/10117] Add one more missed 'u' modifier, add code comment [ticket/10115] Switch UTF-8 mode on for the rest of BBCodes [ticket/10117] Make smilies to be correctly parsed within unicode text. [ticket/10115] Make some text oriented BBCodes to properly handle unicode.
| * | Merge branch 'ticket/rxu/10117' into develop-olympusOleg Pudeyev2011-04-171-2/+7
| |\ \ | | | | | | | | | | | | | | | | | | | | * ticket/rxu/10117: [ticket/10117] Add one more missed 'u' modifier, add code comment [ticket/10117] Make smilies to be correctly parsed within unicode text.