diff options
| author | Andreas Fischer <bantu@phpbb.com> | 2011-04-22 00:15:05 +0200 |
|---|---|---|
| committer | Andreas Fischer <bantu@phpbb.com> | 2011-04-22 00:20:09 +0200 |
| commit | b1367bce488d0acea00a5ebf8725d0cde5515655 (patch) | |
| tree | c5edcec4644ccf19a2c012e57877ed237917106e | |
| parent | 11dd4b54fa1f3a15448271061e51907e3ba5c79d (diff) | |
| download | forums-b1367bce488d0acea00a5ebf8725d0cde5515655.tar forums-b1367bce488d0acea00a5ebf8725d0cde5515655.tar.gz forums-b1367bce488d0acea00a5ebf8725d0cde5515655.tar.bz2 forums-b1367bce488d0acea00a5ebf8725d0cde5515655.tar.xz forums-b1367bce488d0acea00a5ebf8725d0cde5515655.zip | |
[ticket/10141] Split double-assignment into conditional and unconditional part.
PHPBB3-10141
| -rw-r--r-- | phpBB/includes/auth.php | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/phpBB/includes/auth.php b/phpBB/includes/auth.php index 22fafd7b7f..4b13c6be7f 100644 --- a/phpBB/includes/auth.php +++ b/phpBB/includes/auth.php @@ -126,15 +126,13 @@ class auth while ($subseq = substr($seq, $i, 6)) { - if (isset($seq_cache[$subseq])) + if (!isset($seq_cache[$subseq])) { - $this->acl[$f] .= $seq_cache[$subseq]; - } - else - { - // We put the original bitstring into the acl array - $this->acl[$f] .= ($seq_cache[$subseq] = str_pad(base_convert($subseq, 36, 2), 31, 0, STR_PAD_LEFT)); + $seq_cache[$subseq] = str_pad(base_convert($subseq, 36, 2), 31, 0, STR_PAD_LEFT); } + + // We put the original bitstring into the acl array + $this->acl[$f] .= $seq_cache[$subseq]; $i += 6; } } |