Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | [ticket/11495] Fix comments and package docs | Joas Schilling | 2013-04-25 | 9 | -11/+11 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use constructor arguments over properties in implementation | Joas Schilling | 2013-04-25 | 2 | -22/+47 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix failing unit tests | Joas Schilling | 2013-04-25 | 5 | -5/+5 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove add/remove from the interface | Joas Schilling | 2013-04-25 | 2 | -23/+13 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove fixing function from tree interface | Joas Schilling | 2013-04-25 | 2 | -29/+24 |
| | | | | | | The fixing function is implementation dependent. PHPBB3-11495 | ||||
* | [ticket/11495] Remove tests for add/remove we make them protected later | Joas Schilling | 2013-04-25 | 2 | -196/+101 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Move tests to tree/ directory | Joas Schilling | 2013-04-25 | 7 | -12/+12 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Move classes to tree/ as they all implement a tree | Joas Schilling | 2013-04-25 | 4 | -7/+7 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Replace fixtures content with manual calls | Joas Schilling | 2013-04-25 | 2 | -110/+25 |
| | | | | | | Should be easier to maintain PHPBB3-11495 | ||||
* | [ticket/11495] Explain use of set_subset_zero on remove_subset() | Joas Schilling | 2013-04-25 | 1 | -2/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use default exceptions | Joas Schilling | 2013-04-25 | 3 | -38/+18 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Explain what "given item" means | Joas Schilling | 2013-04-25 | 2 | -4/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Split get_branch_data into multiple methods | Joas Schilling | 2013-04-25 | 3 | -61/+128 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Rename set_parent to change_parent() | Joas Schilling | 2013-04-25 | 3 | -15/+17 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Explain whether move_children prepends/appends/overwrittes | Joas Schilling | 2013-04-25 | 1 | -0/+3 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Rename fix function to regenerate_left_right_ids() | Joas Schilling | 2013-04-25 | 3 | -9/+21 |
| | | | | | | | | | | | | | | | This method regenerates the left/right ids for the nested set based on the parent/child relations. This function executes three queries per item, so it should only be called, when the set has one of the following problems: - The set has a duplicated value inside the left/right id chain - The set has a missing value inside the left/right id chain - The set has items that do not have a left/right is set When regenerating the items, the items are sorted by parent id and their current left id, so the current child/parent relationships are kept and running the function on a working set will not change any orders. PHPBB3-11495 | ||||
* | [ticket/11495] Explain move() more | Joas Schilling | 2013-04-25 | 1 | -0/+4 |
| | | | | | | | | An item is only moved up/down within the same parent. If the delta is larger then the number of children, the item is moved to the top/bottom of the list of children within this parent. PHPBB3-11495 | ||||
* | [ticket/11495] Do not compare to null anymore (left over from item class) | Joas Schilling | 2013-04-25 | 1 | -2/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use item ids instead of requiring all data | Joas Schilling | 2013-04-19 | 3 | -60/+141 |
| | | | | | | | The data is grabbed again in most cases anyway, so it just makes the system easier to use. PHPBB3-11495 | ||||
* | [ticket/11495] Cast some values to int | Joas Schilling | 2013-04-19 | 1 | -5/+5 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use item_id only as parameter for delete() and remove() | Joas Schilling | 2013-04-19 | 3 | -14/+15 |
| | | | | | | The data is acquired again anyway PHPBB3-11495 | ||||
* | [ticket/11495] Use item_id only as parameter for get_branch_data() | Joas Schilling | 2013-04-19 | 3 | -17/+10 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix Spacing and lowercase on docs | Joas Schilling | 2013-04-19 | 2 | -7/+7 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove acquire locks from forum implementation | Joas Schilling | 2013-04-18 | 1 | -63/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Acquire locks for operations that manipulate the tree | Joas Schilling | 2013-04-18 | 1 | -9/+66 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove item class as its no longer required | Joas Schilling | 2013-04-18 | 2 | -6/+0 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Manually specify the table columns | Joas Schilling | 2013-04-18 | 1 | -2/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Move nestedset default values to new method | Joas Schilling | 2013-04-18 | 1 | -8/+21 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix column variable names | Joas Schilling | 2013-04-18 | 2 | -7/+7 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove item class from unit tests | Joas Schilling | 2013-04-18 | 4 | -71/+18 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove item classes | Joas Schilling | 2013-04-18 | 3 | -171/+0 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use array directly instead of phpbb_nestedset_item_interface | Joas Schilling | 2013-04-18 | 3 | -103/+97 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix description of get_sql_where | Joas Schilling | 2013-04-17 | 1 | -3/+1 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use unique properties for the column names | Joas Schilling | 2013-04-17 | 2 | -102/+95 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add unit tests for the implemented functions | Joas Schilling | 2013-04-16 | 8 | -0/+1259 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add forum implementation of nestedset | Joas Schilling | 2013-04-16 | 3 | -0/+169 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add abstract implementation of the interface | Joas Schilling | 2013-04-16 | 2 | -0/+714 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add basic interface with nestedset operations | Joas Schilling | 2013-04-16 | 2 | -0/+192 |
| | | | | PHPBB3-11495 | ||||
* | Merge remote-tracking branch 'nickvergessen/ticket/11491' into develop | Andreas Fischer | 2013-04-15 | 1 | -10/+24 |
|\ | | | | | | | | | | | | | | | | | | | | | * nickvergessen/ticket/11491: [ticket/11491] Copy files back only if we saved them previously [ticket/11491] Only copy files from phpBB/ext/ the directory exists [ticket/11491] Correctly remove the store/temp_ext/ directory after use [ticket/11491] Fix path to the ext/ folder [ticket/11491] Add extension_acp_test.php to functional group [ticket/11491] Fix class name of functional test [ticket/11491] Move file to correct directory | ||||
| * | [ticket/11491] Copy files back only if we saved them previously | Joas Schilling | 2013-04-12 | 1 | -3/+9 |
| | | | | | | | | PHPBB3-11491 | ||||
| * | [ticket/11491] Only copy files from phpBB/ext/ the directory exists | Joas Schilling | 2013-04-12 | 1 | -4/+9 |
| | | | | | | | | PHPBB3-11491 | ||||
| * | [ticket/11491] Correctly remove the store/temp_ext/ directory after use | Joas Schilling | 2013-04-12 | 1 | -2/+2 |
| | | | | | | | | PHPBB3-11491 | ||||
| * | [ticket/11491] Fix path to the ext/ folder | Joas Schilling | 2013-04-12 | 1 | -1/+1 |
| | | | | | | | | PHPBB3-11491 | ||||
| * | [ticket/11491] Add extension_acp_test.php to functional group | Joas Schilling | 2013-04-12 | 1 | -0/+3 |
| | | | | | | | | PHPBB3-11491 | ||||
| * | [ticket/11491] Fix class name of functional test | Joas Schilling | 2013-04-12 | 1 | -1/+1 |
| | | | | | | | | PHPBB3-11491 | ||||
| * | [ticket/11491] Move file to correct directory | Joas Schilling | 2013-04-12 | 1 | -0/+0 |
| | | | | | | | | PHPBB3-11491 | ||||
* | | Merge branch 'develop-olympus' into develop | Andreas Fischer | 2013-04-15 | 1 | -0/+3 |
|\ \ | | | | | | | | | | | | | | | | * develop-olympus: [ticket/11493] add checks for Notice and Warning [ticket/11493] add check for phpBB Debug in functional tests | ||||
| * \ | Merge remote-tracking branch 'dhruvgoel92/ticket/11493' into develop-olympus | Andreas Fischer | 2013-04-15 | 1 | -0/+3 |
| |\ \ | | | | | | | | | | | | | | | | | | | | | * dhruvgoel92/ticket/11493: [ticket/11493] add checks for Notice and Warning [ticket/11493] add check for phpBB Debug in functional tests | ||||
| | * | | [ticket/11493] add checks for Notice and Warning | Dhruv | 2013-04-15 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | PHPBB3-11493 | ||||
| | * | | [ticket/11493] add check for phpBB Debug in functional tests | Dhruv | 2013-04-15 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | PHPBB3-11493 |