diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2013-04-25 16:23:47 +0200 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2013-04-25 16:24:31 +0200 |
| commit | c72f5bf48704675b673e1eae26c9bf9471fc72ed (patch) | |
| tree | 8b83924956f21961bffab03c8aee31fd0c894c57 | |
| parent | 804f139be0534691fc1c8f6ddaf7ebc68a7d0a1c (diff) | |
| download | forums-c72f5bf48704675b673e1eae26c9bf9471fc72ed.tar forums-c72f5bf48704675b673e1eae26c9bf9471fc72ed.tar.gz forums-c72f5bf48704675b673e1eae26c9bf9471fc72ed.tar.bz2 forums-c72f5bf48704675b673e1eae26c9bf9471fc72ed.tar.xz forums-c72f5bf48704675b673e1eae26c9bf9471fc72ed.zip | |
[ticket/11495] Explain use of set_subset_zero on remove_subset()
PHPBB3-11495
| -rw-r--r-- | phpBB/includes/nestedset/base.php | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/phpBB/includes/nestedset/base.php b/phpBB/includes/nestedset/base.php index da6c056313..cb06a0dabe 100644 --- a/phpBB/includes/nestedset/base.php +++ b/phpBB/includes/nestedset/base.php @@ -603,8 +603,10 @@ abstract class phpbb_nestedset_base implements phpbb_nestedset_interface * Remove a subset from the nested set * * @param array $subset_items Subset of items to remove - * @param array $bounding_item Item containing the right bound of the subset - * @param bool $set_subset_zero Should the parent, left and right id of the item be set to 0, or kept unchanged? + * @param array $bounding_item Item containing the right bound of the subset + * @param bool $set_subset_zero Should the parent, left and right id of the items be set to 0, or kept unchanged? + * In case of removing an item from the tree, we should the values to 0 + * In case of moving an item, we shouldkeep the original values, in order to allow "+ diff" later * @param bool $table_already_locked Is the table already locked, or should we acquire a new lock? * @return null */ |