aboutsummaryrefslogtreecommitdiffstats
path: root/tests/uploads
diff options
context:
space:
mode:
Diffstat (limited to 'tests/uploads')
-rw-r--r--tests/uploads/fileupload_test.php31
1 files changed, 18 insertions, 13 deletions
diff --git a/tests/uploads/fileupload_test.php b/tests/uploads/fileupload_test.php
index d5cd3d891b..2b3c17b8e0 100644
--- a/tests/uploads/fileupload_test.php
+++ b/tests/uploads/fileupload_test.php
@@ -55,33 +55,38 @@ class phpbb_fileupload_test extends phpbb_test_case
$user = null;
}
- public function test_common_checks()
+ public function test_common_checks_invalid_extension()
{
- // Test 1: Valid file
- $upload = new fileupload('', array('jpg'), 1000);
+ $upload = new fileupload('', array('png'), 100);
$file = $this->gen_valid_filespec();
$upload->common_checks($file);
- $this->assertEquals(0, sizeof($file->error));
+ $this->assertEquals('DISALLOWED_EXTENSION', $file->error[0]);
+ }
- // Test 2: File too large
+ public function test_common_checks_invalid_filename()
+ {
$upload = new fileupload('', array('jpg'), 100);
$file = $this->gen_valid_filespec();
- $file->filesize = 1000;
+ $file->realname = 'invalid?';
$upload->common_checks($file);
- $this->assertEquals('WRONG_FILESIZE', $file->error[0]);
+ $this->assertEquals('INVALID_FILENAME', $file->error[0]);
+ }
- // Test 3: Invalid filename
+ public function test_common_checks_too_large()
+ {
$upload = new fileupload('', array('jpg'), 100);
$file = $this->gen_valid_filespec();
- $file->realname = 'invalid?';
+ $file->filesize = 1000;
$upload->common_checks($file);
- $this->assertEquals('INVALID_FILENAME', $file->error[0]);
+ $this->assertEquals('WRONG_FILESIZE', $file->error[0]);
+ }
- // Test 4: Invalid extension
- $upload = new fileupload('', array('png'), 100);
+ public function test_common_checks_valid_file()
+ {
+ $upload = new fileupload('', array('jpg'), 1000);
$file = $this->gen_valid_filespec();
$upload->common_checks($file);
- $this->assertEquals('DISALLOWED_EXTENSION', $file->error[0]);
+ $this->assertEquals(0, sizeof($file->error));
}
public function test_local_upload()