aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB
diff options
context:
space:
mode:
Diffstat (limited to 'phpBB')
-rw-r--r--phpBB/docs/CHANGELOG.html1
-rw-r--r--phpBB/includes/ucp/ucp_groups.php12
-rw-r--r--phpBB/language/en/groups.php6
3 files changed, 17 insertions, 2 deletions
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index 8931b8f347..328c0b9098 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -118,6 +118,7 @@
<li>[Fix] Handle generation of form tokens when maximum time is set to -1</li>
<li>[Fix] Correctly delete unapproved posts without deleting the topic (Bug #15120)</li>
<li>[Fix] Respect signature permissions in posting (Bug #16029)</li>
+ <li>[Fix] Users allowed to resign only from open and freely open groups (Bug #19355)</li>
</ul>
diff --git a/phpBB/includes/ucp/ucp_groups.php b/phpBB/includes/ucp/ucp_groups.php
index a4fc818343..d6e7a30176 100644
--- a/phpBB/includes/ucp/ucp_groups.php
+++ b/phpBB/includes/ucp/ucp_groups.php
@@ -127,6 +127,18 @@ class ucp_groups
}
list(, $row) = each($row);
+ $sql = 'SELECT group_type
+ FROM ' . GROUPS_TABLE . '
+ WHERE group_id = ' . $group_id;
+ $result = $db->sql_query($sql);
+ $group_type = (int) $db->sql_fetchfield('group_type');
+ $db->sql_freeresult($result);
+
+ if ($group_type != GROUP_OPEN && $group_type != GROUP_FREE)
+ {
+ trigger_error($user->lang['CANNOT_RESIGN_GROUP'] . $return_page);
+ }
+
if (confirm_box(true))
{
group_user_del($group_id, $user->data['user_id']);
diff --git a/phpBB/language/en/groups.php b/phpBB/language/en/groups.php
index 7cee799535..9f72d4070f 100644
--- a/phpBB/language/en/groups.php
+++ b/phpBB/language/en/groups.php
@@ -40,8 +40,10 @@ $lang = array_merge($lang, array(
'ALREADY_IN_GROUP' => 'You are already a member of the selected group.',
'ALREADY_IN_GROUP_PENDING' => 'You already requested joining the selected group.',
- 'CHANGED_DEFAULT_GROUP' => 'Successfully changed default group.',
-
+ 'CANNOT_JOIN_GROUP' => 'You are not able to join this group. You are only able to join open and freely open groups.',
+ 'CANNOT_RESIGN_GROUP' => 'You are not able to resign from this group. You are only able to resign from open and freely open groups.',
+ 'CHANGED_DEFAULT_GROUP' => 'Successfully changed default group.',
+
'GROUP_AVATAR' => 'Group avatar',
'GROUP_CHANGE_DEFAULT' => 'Are you sure you want to change your default membership to the group ā€œ%sā€?',
'GROUP_CLOSED' => 'Closed',