1 files changed, 174 insertions, 45 deletions
diff --git a/phpBB/includes/message_parser.php b/phpBB/includes/message_parser.php
index 166738bbfc..afaed8cb82 100644
--- a/phpBB/includes/message_parser.php
+++ b/phpBB/includes/message_parser.php
@@ -83,7 +83,7 @@ class parse_message
 		$warn_msg .= (($warn_msg != '') ? '<br />' : '') . $this->html($message, $html);
 		$warn_msg .= (($warn_msg != '') ? '<br />' : '') . $this->bbcode($message, $bbcode, $uid);
 		$warn_msg .= (($warn_msg != '') ? '<br />' : '') . $this->emoticons($message, $smilies);
-		$warn_msg .= (($warn_msg != '') ? '<br />' : '') . $this->magic_url($message, trim($url));
+		$warn_msg .= (($warn_msg != '') ? '<br />' : '') . $this->magic_url($message, $url);
 		$warn_msg .= (($warn_msg != '') ? '<br />' : '') . $this->attach($_FILE);
 
 		return $warn_msg;
@@ -207,7 +207,7 @@ class parse_message
 			$message = str_replace('\"', '"', substr(preg_replace('#(\>(((?>([^><]+|(?R)))*)\<))#se', "preg_replace(\$censors['match'], \$censors['replace'], '\\0')", '>' . $message . '<'), 1, -1));
 		}
 
-		$message = nl2br($message);
+		$message = str_replace("\n", "<br />", $message);
 
 		/* Signature
 		$user_sig = ($sig && $signature != '' && $config['allow_sig']) ? $row['user_sig'] : '';
@@ -240,7 +240,7 @@ class parse_message
 	}
 
 	// Submit Post
-	function submit_post($mode, $message, $subject, $username, $topic_type, $bbcode_uid, $poll, $misc_info)
+	function submit_post($mode, $message, $subject, $username, $topic_type, $bbcode_uid, $poll, $post_data)
 	{
 		global $db, $auth, $user, $config, $phpEx, $SID, $template;
 
@@ -250,15 +250,15 @@ class parse_message
 		$db->sql_transaction();
 
 		// Initial Topic table info
-		if ( ($mode == 'post') || ($mode == 'edit' && $misc_info['topic_first_post_id'] == $misc_info['post_id']))
+		if ( ($mode == 'post') || ($mode == 'edit' && $post_data['topic_first_post_id'] == $post_data['post_id']))
 		{
 			$topic_sql = array(
-				'forum_id' 					=> $misc_info['forum_id'],
+				'forum_id' 					=> $post_data['forum_id'],
 				'topic_title' 				=> stripslashes($subject),
 				'topic_time'				=> $current_time,
 				'topic_type'				=> $topic_type,
-				'topic_approved'			=> (($misc_info['enable_moderate']) && !$auth->acl_gets('f_ignorequeue', 'm_', 'a_', $misc_info['forum_id'])) ? 0 : 1, 
-				'icon_id'					=> $misc_info['icon_id'],
+				'topic_approved'			=> (($post_data['enable_moderate']) && !$auth->acl_gets('f_ignorequeue', 'm_', 'a_', $post_data['forum_id'])) ? 0 : 1, 
+				'icon_id'					=> $post_data['icon_id'],
 				'topic_poster'				=> intval($user->data['user_id']), 
 				'topic_first_poster_name'	=> ($username != '') ? stripslashes($username) : (($user->data['user_id'] == ANONYMOUS) ? '' : stripslashes($user->data['username'])), 
 			);
@@ -271,44 +271,44 @@ class parse_message
 					'poll_length'			=> $poll['poll_length'] * 3600
 				));
 			}
-			$sql = ($mode == 'post') ? 'INSERT INTO ' . TOPICS_TABLE . ' ' . $db->sql_build_array('INSERT', $topic_sql) : 'UPDATE ' . TOPICS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $topic_sql) . ' WHERE topic_id = ' . $misc_info['topic_id'];
+			$sql = ($mode == 'post') ? 'INSERT INTO ' . TOPICS_TABLE . ' ' . $db->sql_build_array('INSERT', $topic_sql) : 'UPDATE ' . TOPICS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $topic_sql) . ' WHERE topic_id = ' . $post_data['topic_id'];
 			$db->sql_query($sql);
 
-			$misc_info['topic_id'] = ($mode == 'post') ? $db->sql_nextid() : $misc_info['topic_id'];
+			$post_data['topic_id'] = ($mode == 'post') ? $db->sql_nextid() : $post_data['topic_id'];
 		}
 
 		// Post table info
 		$post_sql = array(
-			'topic_id' 			=> $misc_info['topic_id'],
-			'forum_id' 			=> $misc_info['forum_id'],
-			'poster_id' 		=> ($mode == 'edit') ? $misc_info['poster_id'] : intval($user->data['user_id']),
+			'topic_id' 			=> $post_data['topic_id'],
+			'forum_id' 			=> $post_data['forum_id'],
+			'poster_id' 		=> ($mode == 'edit') ? $post_data['poster_id'] : intval($user->data['user_id']),
 			'post_username'		=> ($username != '') ? stripslashes($username) : '', 
 			'post_subject'		=> stripslashes($subject),
-			'icon_id'			=> $misc_info['icon_id'], 
+			'icon_id'			=> $post_data['icon_id'], 
 			'poster_ip' 		=> $user->ip,
 			'post_time' 		=> $current_time,
-			'post_approved' 	=> ($misc_info['enable_moderate'] && !$auth->acl_gets('f_ignorequeue', 'm_', 'a_', $misc_info['forum_id'])) ? 0 : 1,
-			'post_edit_time' 	=> ($mode == 'edit' && $misc_info['poster_id'] == $user->data['user_id']) ? $current_time : 0,
-			'enable_sig' 		=> $misc_info['enable_html'],
-			'enable_bbcode' 	=> $misc_info['enable_bbcode'],
-			'enable_html' 		=> $misc_info['enable_html'],
-			'enable_smilies' 	=> $misc_info['enable_smilies'],
-			'enable_magic_url' 	=> $misc_info['enable_urls'],
+			'post_approved' 	=> ($post_data['enable_moderate'] && !$auth->acl_gets('f_ignorequeue', 'm_', 'a_', $post_data['forum_id'])) ? 0 : 1,
+			'post_edit_time' 	=> ($mode == 'edit' && $post_data['poster_id'] == $user->data['user_id']) ? $current_time : 0,
+			'enable_sig' 		=> $post_data['enable_html'],
+			'enable_bbcode' 	=> $post_data['enable_bbcode'],
+			'enable_html' 		=> $post_data['enable_html'],
+			'enable_smilies' 	=> $post_data['enable_smilies'],
+			'enable_magic_url' 	=> $post_data['enable_urls'],
 			'bbcode_uid'		=> $bbcode_uid,
 		);
 
-		if ($mode != 'edit' || $misc_info['message_md5'] != $misc_info['post_checksum'])
+		if ($mode != 'edit' || $post_data['message_md5'] != $post_data['post_checksum'])
 		{
 			$post_sql = array_merge($post_sql, array(
-				'post_checksum' => $misc_info['message_md5'],
+				'post_checksum' => $post_data['message_md5'],
 				'post_text' 	=> stripslashes($message), 
 				'post_encoding' => $user->lang['ENCODING'] 
 			));
 		}
-		$sql = ($mode == 'edit' && $misc_info['poster_id'] == intval($user->data['user_id'])) ? 'UPDATE ' . POSTS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $post_sql) . ' , post_edit_count = post_edit_count + 1 WHERE post_id = ' . $misc_info['post_id'] : 'INSERT INTO ' . POSTS_TABLE . ' ' . $db->sql_build_array('INSERT', $post_sql);
+		$sql = ($mode == 'edit' && $post_data['poster_id'] == intval($user->data['user_id'])) ? 'UPDATE ' . POSTS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $post_sql) . ' , post_edit_count = post_edit_count + 1 WHERE post_id = ' . $post_data['post_id'] : 'INSERT INTO ' . POSTS_TABLE . ' ' . $db->sql_build_array('INSERT', $post_sql);
 		$db->sql_query($sql);
 
-		$misc_info['post_id'] = ($mode == 'edit') ? $misc_info['post_id'] : $db->sql_nextid();
+		$post_data['post_id'] = ($mode == 'edit') ? $post_data['post_id'] : $db->sql_nextid();
 
 		// poll options
 		if (!empty($poll['poll_options']))
@@ -317,7 +317,7 @@ class parse_message
 			if (!empty($poll['poll_start']) && $mode == 'edit')
 			{
 				$sql = "SELECT * FROM " . POLL_OPTIONS_TABLE . " 
-					WHERE topic_id = " . $misc_info['topic_id'] . "
+					WHERE topic_id = " . $post_data['topic_id'] . "
 					ORDER BY poll_option_id";
 				$result = $db->sql_query($sql);
 
@@ -332,7 +332,7 @@ class parse_message
 					if (empty($cur_poll_options[$i]))
 					{
 						$sql = "INSERT INTO " . POLL_OPTIONS_TABLE . "  (topic_id, poll_option_text)
-							VALUES (" . $misc_info['topic_id'] . ", '" . $db->sql_escape($poll['poll_options'][$i]) . "')";
+							VALUES (" . $post_data['topic_id'] . ", '" . $db->sql_escape($poll['poll_options'][$i]) . "')";
 						$db->sql_query($sql);
 					}
 					else if ($poll['poll_options'][$i] != $cur_poll_options[$i])
@@ -347,9 +347,9 @@ class parse_message
 		}
 
 		// Fulltext parse
-		if ($mode != 'edit' || $misc_info['message_md5'] != $misc_info['post_checksum'])
+		if ($mode != 'edit' || $post_data['message_md5'] != $post_data['post_checksum'])
 		{
-			$result = $search->add($mode, $misc_info['post_id'], $message, $subject);
+			$result = $search->add($mode, $post_data['post_id'], $message, $subject);
 		}
 
 		// Sync forums, topics and users ...
@@ -357,11 +357,11 @@ class parse_message
 		{
 			// Update forums: last post info, topics, posts ... we need to update
 			// each parent too ...
-			$forum_ids = $misc_info['forum_id'];
-			if (!empty($misc_info['forum_parents']))
+			$forum_ids = $post_data['forum_id'];
+			if (!empty($post_data['forum_parents']))
 			{
-				$misc_info['forum_parents'] = unserialize($misc_info['forum_parents']);
-				foreach ($misc_info['forum_parents'] as $parent_forum_id => $parent_name)
+				$post_data['forum_parents'] = unserialize($post_data['forum_parents']);
+				foreach ($post_data['forum_parents'] as $parent_forum_id => $parent_name)
 				{
 					$forum_ids .= ', ' . $parent_forum_id;
 				}
@@ -369,7 +369,7 @@ class parse_message
 
 			$forum_topics_sql = ($mode == 'post') ? ', forum_topics = forum_topics + 1' : '';
 			$forum_sql = array(
-				'forum_last_post_id' 	=> $misc_info['post_id'],
+				'forum_last_post_id' 	=> $post_data['post_id'],
 				'forum_last_post_time' 	=> $current_time,
 				'forum_last_poster_id' 	=> intval($user->data['user_id']),
 				'forum_last_poster_name'=> ($user->data['user_id'] == ANONYMOUS) ? stripslashes($username) : $user->data['username'],
@@ -380,7 +380,7 @@ class parse_message
 
 			// Update topic: first/last post info, replies
 			$topic_sql = array(
-				'topic_last_post_id' 	=> $misc_info['post_id'],
+				'topic_last_post_id' 	=> $post_data['post_id'],
 				'topic_last_post_time' 	=> $current_time,
 				'topic_last_poster_id' 	=> intval($user->data['user_id']),
 				'topic_last_poster_name'=> ($username != '') ? stripslashes($username) : (($user->data['user_id'] == ANONYMOUS) ? '' : stripslashes($user->data['username'])),
@@ -389,16 +389,16 @@ class parse_message
 			if ($mode == 'post')
 			{
 				$topic_sql = array_merge($topic_sql, array(
-					'topic_first_post_id' 		=> $misc_info['post_id'],
+					'topic_first_post_id' 		=> $post_data['post_id'],
 				));
 			}
 
 			$topic_replies_sql = ($mode == 'reply') ? ', topic_replies = topic_replies + 1' : '';
-			$sql = 'UPDATE ' . TOPICS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $topic_sql) . $topic_replies_sql . ' WHERE topic_id = ' . $misc_info['topic_id'];
+			$sql = 'UPDATE ' . TOPICS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $topic_sql) . $topic_replies_sql . ' WHERE topic_id = ' . $post_data['topic_id'];
 			$db->sql_query($sql);
 
 			// Update user post count ... if appropriate
-			if (!empty($misc_info['enable_post_count']) && $user->data['user_id'] != ANONYMOUS)
+			if (!empty($post_data['enable_post_count']) && $user->data['user_id'] != ANONYMOUS)
 			{
 				$sql = 'UPDATE ' . USERS_TABLE . '
 					SET user_posts = user_posts + 1
@@ -416,34 +416,163 @@ class parse_message
 		}
 
 		// Topic Notification
-		if ((!$misc_info['notify_set']) && ($misc_info['notify']))
+		if ((!$post_data['notify_set']) && ($post_data['notify']))
 		{
 			$sql = "INSERT INTO " . TOPICS_WATCH_TABLE . " (user_id, topic_id)
-				VALUES (" . $user->data['user_id'] . ", " . $misc_info['topic_id'] . ")";
+				VALUES (" . $user->data['user_id'] . ", " . $post_data['topic_id'] . ")";
 			$db->sql_query($sql);
 		}
-		else if (($misc_info['notify_set']) && (!$misc_info['notify']))
+		else if (($post_data['notify_set']) && (!$post_data['notify']))
 		{
 			$sql = "DELETE FROM " . TOPICS_WATCH_TABLE . "
 				WHERE user_id = " . $user->data['user_id'] . "
-					AND topic_id = " . $misc_info['topic_id'];
+					AND topic_id = " . $post_data['topic_id'];
 			$db->sql_query($sql);
 		}
 		
 		// Mark this topic as read and posted to.
 		$mark_mode = ($mode == 'reply' || $mode == 'quote') ? 'post' : 'topic';
-		markread($mark_mode, $misc_info['forum_id'], $misc_info['topic_id'], $misc_info['post_id']);
+		markread($mark_mode, $post_data['forum_id'], $post_data['topic_id'], $post_data['post_id']);
 
 		$db->sql_transaction('commit');
 
 		$template->assign_vars(array(
-			'META' => '<meta http-equiv="refresh" content="5; url=viewtopic.' . $phpEx . $SID . '&amp;f=' . $misc_info['forum_id'] . '&amp;p=' . $misc_info['post_id'] . '#' . $misc_info['post_id'] . '">')
+			'META' => '<meta http-equiv="refresh" content="5; url=viewtopic.' . $phpEx . $SID . '&amp;f=' . $post_data['forum_id'] . '&amp;p=' . $post_data['post_id'] . '#' . $post_data['post_id'] . '">')
 		);
 
-		$message = (!empty($misc_info['enable_moderate'])) ? 'POST_STORED_MOD' : 'POST_STORED';
-		$message = $user->lang[$message] . '<br /><br />' . sprintf($user->lang['VIEW_MESSAGE'], '<a href="viewtopic.' . $phpEx . $SID .'&p=' . $misc_info['post_id'] . '#' . $misc_info['post_id'] . '">', '</a>') . '<br /><br />' . sprintf($user->lang['RETURN_FORUM'], '<a href="viewforum.' . $phpEx . $SID .'&amp;f=' . $misc_info['forum_id'] . '">', '</a>');
+		$message = (!empty($post_data['enable_moderate'])) ? 'POST_STORED_MOD' : 'POST_STORED';
+		$message = $user->lang[$message] . '<br /><br />' . sprintf($user->lang['VIEW_MESSAGE'], '<a href="viewtopic.' . $phpEx . $SID .'&p=' . $post_data['post_id'] . '#' . $post_data['post_id'] . '">', '</a>') . '<br /><br />' . sprintf($user->lang['RETURN_FORUM'], '<a href="viewforum.' . $phpEx . $SID .'&amp;f=' . $post_data['forum_id'] . '">', '</a>');
 		trigger_error($message);
 	}
+
+	// Delete Post. Please be sure user have the correct Permissions before calling this function
+	function delete_post($mode, $post_id, $topic_id, $forum_id, $post_data)
+	{
+		global $db, $template, $user, $phpEx, $SID;
+
+		$search = new fulltext_search();
+
+		$sql = "DELETE FROM " . POSTS_TABLE . " 
+		WHERE post_id = " . $post_id;
+		$db->sql_query($sql);
+
+		// User tries to delete the post twice ? Exit... we do not want the topics table screwed up.
+		if ($db->sql_affectedrows() == 0)
+		{
+			return ($user->lang['ALREADY_DELETED']);
+		}
+
+		$forum_sql = array();
+		$topic_sql = array();
+		$user_sql = array();
+
+		$forum_update_sql = '';
+		$user_update_sql = '';
+		$topic_update_sql = 'topic_replies = topic_replies - 1';
+
+		// Only one post... delete topic
+		if ($post_data['topic_first_post_id'] == $post_data['topic_last_post_id'])
+		{
+			$sql = "DELETE FROM " . TOPICS_TABLE . " 
+			WHERE topic_id = " . $topic_id . "
+			OR topic_moved_id = " . $topic_id;
+			$db->sql_query($sql);
+
+			$sql = "DELETE FROM " . TOPICS_WATCH_TABLE . "
+			WHERE topic_id = " . $topic_id;
+			$db->sql_query($sql);
+
+			$forum_update_sql .= ($forum_update_sql != '') ? ', ' : '';
+			$forum_update_sql .= 'forum_topics = forum_topics - 1';
+		}
+
+		// Update Post Statistics
+		if ($post_data['enable_post_count'])
+		{
+			$forum_update_sql .= ($forum_update_sql != '') ? ', ' : '';
+			$forum_update_sql .= 'forum_posts = forum_posts - 1';
+
+			$user_update_sql .= ($user_update_sql != '') ? ', ' : '';
+			$user_update_sql .= 'user_posts = user_posts - 1';
+		}
+
+		// TODO: delete common words... maybe just call search_tidy ?
+//		$search->del_words($post_id);
+
+		$sql = "SELECT p.post_id, p.poster_id, p.post_username, u.username FROM " . POSTS_TABLE . " p, " . USERS_TABLE . " u
+		WHERE p.topic_id = " . $topic_id . " AND p.poster_id = u.user_id AND p.post_approved = 1
+		ORDER BY p.post_time DESC LIMIT 1";
+
+		$result = $db->sql_query($sql);
+		$row = $db->sql_fetchrow($result);
+
+		// If Post is first post, but not the only post... make next post the topic starter one. ;)
+		if (($post_data['topic_first_post_id'] != $post_data['topic_last_post_id']) && ($post_id == $post_data['topic_first_post_id']))
+		{
+			$topic_sql = array(
+				'topic_first_post_id' => intval($row['post_id']),
+				'topic_first_poster_name' => ( intval($row['poster_id']) == ANONYMOUS) ? trim($row['post_username']) : trim($row['username'])
+			);
+		}
+
+		$post_data['next_post_id'] = intval($row['post_id']);
+
+		// Update Forum, Topic and User with the gathered Informations
+		if (($forum_update_sql != '') || (count($forum_sql) > 0))
+		{
+			$sql = 'UPDATE ' . FORUMS_TABLE . ' SET ' . ( (count($forum_sql) > 0) ? $db->sql_build_array('UPDATE', $forum_sql) : '') . 
+			( ($forum_update_sql != '') ? ((count($forum_sql) > 0) ? ', ' . $forum_update_sql : $forum_update_sql) : '') . ' 
+			WHERE forum_id = ' . $forum_id;
+
+			$db->sql_query($sql);
+		}
+
+		if (($topic_update_sql != '') || (count($topic_sql) > 0))
+		{
+			$sql = 'UPDATE ' . TOPICS_TABLE . ' SET ' . ( (count($topic_sql) > 0) ? $db->sql_build_array('UPDATE', $topic_sql) : '') . 
+			( ($topic_update_sql != '') ? ((count($topic_sql) > 0) ? ', ' . $topic_update_sql : $topic_update_sql) : '') . ' 
+			WHERE topic_id = ' . $topic_id;
+
+			$db->sql_query($sql);
+		}
+
+		if (($user_update_sql != '') || (count($user_sql) > 0))
+		{
+			$sql = 'UPDATE ' . USERS_TABLE . ' SET ' . ( (count($user_sql) > 0) ? $db->sql_build_array('UPDATE', $user_sql) : '') . 
+			( ($user_update_sql != '') ? ((count($user_sql) > 0) ? ', ' . $user_update_sql : $user_update_sql) : '') . ' 
+			WHERE user_id = ' . $post_data['user_id'];
+
+			$db->sql_query($sql);
+		}
+
+		// Update Forum stats...
+		if ($post_data['topic_first_post_id'] != $post_data['topic_last_post_id'])
+		{
+			update_last_post_information('topic', $topic_id);
+		}
+		update_last_post_information('forum', $forum_id);
+
+		if ($post_data['topic_first_post_id'] == $post_data['topic_last_post_id'])
+		{
+			$meta_info = '<meta http-equiv="refresh" content="5; url=viewforum.' . $phpEx . $SID . '&amp;f=' . $forum_id . '">';
+			$message = $user->lang['DELETED'];
+		}
+		else
+		{
+			$meta_info = '<meta http-equiv="refresh" content="5; url=viewtopic.' . $phpEx . $SID . '&amp;f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;p=' . $post_data['next_post_id'] . '#' . $post_data['next_post_id'] . '">';
+			$message = $user->lang['DELETED'] . '<br /><br />' . sprintf($user->lang['RETURN_TOPIC'], '<a href="viewtopic.' . $phpEx . $SID . '&amp;f=' . $forum_id . '&amp;t=' . $topic_id . '&amp;p=' . $post_data['next_post_id'] . '#' . $post_data['next_post_id'] . '">', '</a>');
+		}
+
+		$template->assign_vars(array(
+			'META' => $meta_info)
+		);
+
+		$message .= '<br /><br />' . sprintf($user->lang['RETURN_FORUM'], '<a href="viewforum.' . $phpEx . $SID . '&amp;f=' . $forum_id . '">', '</a>');
+
+		trigger_error($message);
+
+		return;
+	}
 }
 
 // Parses a given message and updates/maintains the fulltext tables