1 files changed, 75 insertions, 120 deletions
diff --git a/phpBB/includes/db/mssql.php b/phpBB/includes/db/mssql.php
index cb6b5123c0..636ce1e90c 100644
--- a/phpBB/includes/db/mssql.php
+++ b/phpBB/includes/db/mssql.php
@@ -24,7 +24,9 @@ if (!defined('SQL_LAYER'))
 */
 class dbal_mssql extends dbal
 {
-
+	/**
+	* Connect to server
+	*/
 	function sql_connect($sqlserver, $sqluser, $sqlpassword, $database, $port = false, $persistency = false)
 	{
 		$this->persistency = $persistency;
@@ -46,29 +48,9 @@ class dbal_mssql extends dbal
 		return ($this->db_connect_id) ? $this->db_connect_id : $this->sql_error('');
 	}
 
-	function sql_close()
-	{
-		if (!$this->db_connect_id)
-		{
-			return false;
-		}
-
-		if ($this->transaction)
-		{
-			@mssql_query('COMMIT', $this->db_connect_id);
-		}
-
-		if (sizeof($this->open_queries))
-		{
-			foreach ($this->open_queries as $i_query_id => $query_id)
-			{
-				@mssql_free_result($query_id);
-			}
-		}
-
-		return @mssql_close($this->db_connect_id);
-	}
-
+	/**
+	* sql transaction
+	*/
 	function sql_transaction($status = 'begin')
 	{
 		switch ($status)
@@ -100,7 +82,9 @@ class dbal_mssql extends dbal
 		return $result;
 	}
 
-	// Base query method
+	/**
+	* Base query method
+	*/
 	function sql_query($query = '', $cache_ttl = 0)
 	{
 		if ($query != '')
@@ -133,7 +117,6 @@ class dbal_mssql extends dbal
 				{
 					$this->open_queries[(int) $this->query_result] = $this->query_result;
 					$cache->sql_save($query, $this->query_result, $cache_ttl);
-					// sql_freeresult called within sql_save()
 				}
 				else if (strpos($query, 'SELECT') !== false && $this->query_result)
 				{
@@ -153,6 +136,9 @@ class dbal_mssql extends dbal
 		return ($this->query_result) ? $this->query_result : false;
 	}
 
+	/**
+	* Build LIMIT query
+	*/
 	function sql_query_limit($query, $total, $offset = 0, $cache_ttl = 0) 
 	{ 
 		if ($query != '') 
@@ -178,10 +164,10 @@ class dbal_mssql extends dbal
 		} 
 	}
 
-	// Other query methods
-	//
-	// NOTE :: Want to remove _ALL_ reliance on sql_numrows from core code ...
-	//         don't want this here by a middle Milestone
+	/**
+	* Return number of rows
+	* Not used within core code
+	*/
 	function sql_numrows($query_id = false)
 	{
 		if (!$query_id)
@@ -189,15 +175,20 @@ class dbal_mssql extends dbal
 			$query_id = $this->query_result;
 		}
 
-//		return (isset($this->limit_offset[$query_id])) ? @mssql_num_rows($query_id) - $this->limit_offset[$query_id] : @mssql_num_rows($query_id);
 		return ($query_id) ? @mssql_num_rows($query_id) : false;
 	}
 
+	/**
+	* Return number of affected rows
+	*/
 	function sql_affectedrows()
 	{
 		return ($this->db_connect_id) ? @mssql_rows_affected($this->db_connect_id) : false;
 	}
 
+	/**
+	* Fetch current row
+	*/
 	function sql_fetchrow($query_id = false)
 	{
 		global $cache;
@@ -214,6 +205,7 @@ class dbal_mssql extends dbal
 
 		$row = @mssql_fetch_array($query_id, MSSQL_ASSOC);
 		
+		// I hope i am able to remove this later... hopefully only a PHP or MSSQL bug
 		if ($row)
 		{
 			foreach ($row as $key => $value)
@@ -225,30 +217,11 @@ class dbal_mssql extends dbal
 		return $row;
 	}
 
-	function sql_fetchrowset($query_id = false)
-	{
-		if (!$query_id)
-		{
-			$query_id = $this->query_result;
-		}
-
-		if ($query_id)
-		{
-			unset($this->rowset[$query_id]);
-			unset($this->row[$query_id]);
-
-			$result = array();
-			while ($this->rowset[$query_id] = $this->sql_fetchrow($query_id))
-			{
-				$result[] = $this->rowset[$query_id];
-			}
-			return $result;
-		}
-
-		return false;
-	}
-
-	function sql_fetchfield($field, $rownum = -1, $query_id = false)
+	/**
+	* Fetch field
+	* if rownum is false, the current row is used, else it is pointing to the row (zero-based)
+	*/
+	function sql_fetchfield($field, $rownum = false, $query_id = false)
 	{
 		if (!$query_id)
 		{
@@ -257,41 +230,22 @@ class dbal_mssql extends dbal
 
 		if ($query_id)
 		{
-			if ($rownum > -1)
+			if ($rownum !== false)
 			{
-//				(!empty($this->limit_offset[$query_id])) ? @mssql_data_seek($query_id, ($this->limit_offset[$query_id] + $rownum)) : @mssql_data_seek($query_id, $rownum);
-				@mssql_data_seek($query_id, $rownum);
-				$row = @mssql_fetch_array($query_id, MSSQL_ASSOC);
-				$result = isset($row[$field]) ? $row[$field] : false;
+				$this->sql_rowseek($rownum, $query_id);
 			}
-			else
-			{
-				if (empty($this->row[$query_id]) && empty($this->rowset[$query_id]))
-				{
-					if ($this->row[$query_id] = $this->sql_fetchrow($query_id))
-					{
-						$result = $this->row[$query_id][$field];
-					}
-				}
-				else
-				{
-					if ($this->rowset[$query_id])
-					{
-						$result = $this->rowset[$query_id][$field];
-					}
-					elseif ($this->row[$query_id])
-					{
-						$result = $this->row[$query_id][$field];
-					}
-				}
-			}
-
-			return $result;
+			
+			$row = $this->sql_fetchrow($query_id);
+			return isset($row[$field]) ? $row[$field] : false;
 		}
-
+	
 		return false;
 	}
 
+	/**
+	* Seek to given row number
+	* rownum is zero-based
+	*/
 	function sql_rowseek($rownum, $query_id = false)
 	{
 		if (!$query_id)
@@ -299,16 +253,12 @@ class dbal_mssql extends dbal
 			$query_id = $this->query_result;
 		}
 
-		if (isset($this->current_row[$query_id]))
-		{
-//			(!empty($this->limit_offset[$query_id])) ? @mssql_data_seek($query_id, ($this->limit_offset[$query_id] + $rownum)) : @mssql_data_seek($query_id, $rownum);
-			@mssql_data_seek($query_id, $rownum);
-			return true;
-		}
-
-		return false;
+		return ($query_id) ? @mssql_data_seek($query_id, $rownum) : false;
 	}
 
+	/**
+	* Get last inserted id after insert statement
+	*/
 	function sql_nextid()
 	{
 		$result_id = @mssql_query('SELECT @@IDENTITY', $this->db_connect_id);
@@ -316,13 +266,19 @@ class dbal_mssql extends dbal
 		{
 			if (@mssql_fetch_array($result_id, MSSQL_ASSOC))
 			{
-				return @mssql_result($result_id, 1);	
+				$id = @mssql_result($result_id, 1);	
+				@mssql_free_result($result_id);
+				return $id;
 			}
+			@mssql_free_result($result_id);
 		}
 
 		return false;
 	}
 
+	/**
+	* Free sql result
+	*/
 	function sql_freeresult($query_id = false)
 	{
 		if (!$query_id)
@@ -333,20 +289,25 @@ class dbal_mssql extends dbal
 		if (isset($this->open_queries[$query_id]))
 		{
 			unset($this->open_queries[$query_id]);
-			unset($this->result_rowset[$query_id]);
-
 			return @mssql_free_result($query_id);
 		}
 
 		return false;
 	}
 
+	/**
+	* Escape string used in sql query
+	*/
 	function sql_escape($msg)
 	{
 		return str_replace("'", "''", str_replace('\\', '\\\\', $msg));
 	}
 
-	function db_sql_error()
+	/**
+	* return sql error array
+	* @private
+	*/
+	function _sql_error()
 	{
 		return array(
 			'message'	=> @mssql_get_last_message($this->db_connect_id),
@@ -354,22 +315,25 @@ class dbal_mssql extends dbal
 		);
 	}
 
-	function _sql_report($mode, $query = '')
+	/**
+	* Close sql connection
+	* @private
+	*/
+	function _sql_close()
 	{
-		global $cache, $starttime, $phpbb_root_path;
-		static $curtime, $query_hold, $html_hold;
-		static $sql_report = '';
-		static $cache_num_queries = 0;
+		return @mssql_close($this->db_connect_id);
+	}
 
+	/**
+	* Build db-specific report
+	* @private
+	*/
+	function _sql_report($mode, $query = '')
+	{
 		switch ($mode)
 		{
 			case 'start':
-				$query_hold = $query;
-				$html_hold = '';
-
-				$curtime = explode(' ', microtime());
-				$curtime = $curtime[0] + $curtime[1];
-				break;
+			break;
 
 			case 'fromcache':
 				$endtime = explode(' ', microtime());
@@ -380,23 +344,14 @@ class dbal_mssql extends dbal
 				{
 					// Take the time spent on parsing rows into account
 				}
+				@mssql_free_result($result);
+
 				$splittime = explode(' ', microtime());
 				$splittime = $splittime[0] + $splittime[1];
 
-				$time_cache = $endtime - $curtime;
-				$time_db = $splittime - $endtime;
-				$color = ($time_db > $time_cache) ? 'green' : 'red';
-
-				$sql_report .= '<hr width="100%"/><br /><table class="bg" width="100%" cellspacing="1" cellpadding="4" border="0"><tr><th>Query results obtained from the cache</th></tr><tr><td class="row1"><textarea style="font-family:\'Courier New\',monospace;width:100%" rows="5">' . preg_replace('/\t(AND|OR)(\W)/', "\$1\$2", htmlspecialchars(preg_replace('/[\s]*[\n\r\t]+[\n\r\s\t]*/', "\n", $query))) . '</textarea></td></tr></table><p align="center">';
-
-				$sql_report .= 'Before: ' . sprintf('%.5f', $curtime - $starttime) . 's | After: ' . sprintf('%.5f', $endtime - $starttime) . 's | Elapsed [cache]: <b style="color: ' . $color . '">' . sprintf('%.5f', ($time_cache)) . 's</b> | Elapsed [db]: <b>' . sprintf('%.5f', $time_db) . 's</b></p>';
+				$this->sql_report('record_fromcache', $query, $endtime, $splittime);
 
-				// Pad the start time to not interfere with page timing
-				$starttime += $time_db;
-
-				@mssql_free_result($result);
-				$cache_num_queries++;
-				break;
+			break;
 		}
 	}