diff options
| -rw-r--r-- | phpBB/phpbb/di/service_collection.php | 7 | ||||
| -rw-r--r-- | phpBB/phpbb/di/service_collection_iterator.php | 7 |
2 files changed, 14 insertions, 0 deletions
diff --git a/phpBB/phpbb/di/service_collection.php b/phpBB/phpbb/di/service_collection.php index 6a2e62a553..ebf933d338 100644 --- a/phpBB/phpbb/di/service_collection.php +++ b/phpBB/phpbb/di/service_collection.php @@ -38,6 +38,12 @@ class service_collection extends \ArrayObject return new service_collection_iterator($this->container, $this); } + // Because of a PHP issue we have to redefine offsetExists + // (even <ith a call to the parent): + // https://bugs.php.net/bug.php?id=66834 + // https://bugs.php.net/bug.php?id=67067 + // But it triggers a sniffer issue that we have to skip + // @codingStandardsIgnoreStart /** * {@inheritdoc} */ @@ -45,6 +51,7 @@ class service_collection extends \ArrayObject { return parent::offsetExists($index); } + // @codingStandardsIgnoreEnd /** * {@inheritdoc} diff --git a/phpBB/phpbb/di/service_collection_iterator.php b/phpBB/phpbb/di/service_collection_iterator.php index a6cb0e6c3e..7870174c08 100644 --- a/phpBB/phpbb/di/service_collection_iterator.php +++ b/phpBB/phpbb/di/service_collection_iterator.php @@ -49,6 +49,12 @@ class service_collection_iterator extends \ArrayIterator return $task; } + // Because of a PHP issue we have to redefine offsetExists + // (even <ith a call to the parent): + // https://bugs.php.net/bug.php?id=66834 + // https://bugs.php.net/bug.php?id=67067 + // But it triggers a sniffer issue that we have to skip + // @codingStandardsIgnoreStart /** * {@inheritdoc} */ @@ -56,6 +62,7 @@ class service_collection_iterator extends \ArrayIterator { parent::offsetExists($index); } + // @codingStandardsIgnoreEnd /** * {@inheritdoc} |