diff options
| -rw-r--r-- | phpBB/adm/style/acp_users_overview.html | 4 | ||||
| -rw-r--r-- | phpBB/includes/acp/acp_users.php | 7 | ||||
| -rw-r--r-- | phpBB/includes/ucp/ucp_profile.php | 7 | ||||
| -rw-r--r-- | phpBB/includes/ucp/ucp_register.php | 9 | ||||
| -rw-r--r-- | phpBB/install/install_install.php | 23 | ||||
| -rw-r--r-- | phpBB/language/en/common.php | 2 | ||||
| -rw-r--r-- | phpBB/language/en/install.php | 1 | ||||
| -rw-r--r-- | phpBB/language/en/ucp.php | 4 | ||||
| -rw-r--r-- | phpBB/styles/prosilver/template/ucp_profile_reg_details.html | 6 | ||||
| -rw-r--r-- | phpBB/styles/prosilver/template/ucp_register.html | 4 | ||||
| -rw-r--r-- | phpBB/styles/subsilver2/template/ucp_profile_reg_details.html | 6 | ||||
| -rw-r--r-- | phpBB/styles/subsilver2/template/ucp_register.html | 4 | ||||
| -rw-r--r-- | tests/test_framework/phpbb_functional_test_case.php | 3 | 
13 files changed, 9 insertions, 71 deletions
diff --git a/phpBB/adm/style/acp_users_overview.html b/phpBB/adm/style/acp_users_overview.html index 9237e45daf..1f10e7f66e 100644 --- a/phpBB/adm/style/acp_users_overview.html +++ b/phpBB/adm/style/acp_users_overview.html @@ -46,10 +46,6 @@  	<dd><input class="text medium" type="text" id="user_email" name="user_email" value="{USER_EMAIL}" autocomplete="off" /></dd>  </dl>  <dl> -	<dt><label for="email_confirm">{L_CONFIRM_EMAIL}:</label><br /><span>{L_CONFIRM_EMAIL_EXPLAIN}</span></dt> -	<dd><input class="text medium" type="text" id="email_confirm" name="email_confirm" value="" autocomplete="off" /></dd> -</dl> -<dl>  	<dt><label for="new_password">{L_NEW_PASSWORD}:</label><br /><span>{L_CHANGE_PASSWORD_EXPLAIN}</span></dt>  	<dd><input type="password" id="new_password" name="new_password" value="" autocomplete="off" /></dd>  </dl> diff --git a/phpBB/includes/acp/acp_users.php b/phpBB/includes/acp/acp_users.php index a282ef1d7f..97f4b1b5fd 100644 --- a/phpBB/includes/acp/acp_users.php +++ b/phpBB/includes/acp/acp_users.php @@ -756,7 +756,6 @@ class acp_users  						'username'			=> utf8_normalize_nfc(request_var('user', $user_row['username'], true)),  						'user_founder'		=> request_var('user_founder', ($user_row['user_type'] == USER_FOUNDER) ? 1 : 0),  						'email'				=> strtolower(request_var('user_email', $user_row['user_email'])), -						'email_confirm'		=> strtolower(request_var('email_confirm', '')),  						'new_password'		=> request_var('new_password', '', true),  						'password_confirm'	=> request_var('password_confirm', '', true),  					); @@ -788,7 +787,6 @@ class acp_users  								array('string', false, 6, 60),  								array('email', $user_row['user_email'])  							), -							'email_confirm'		=> array('string', true, 6, 60)  						);  					} @@ -799,11 +797,6 @@ class acp_users  						$error[] = 'NEW_PASSWORD_ERROR';  					} -					if ($data['email'] != $user_row['user_email'] && $data['email_confirm'] != $data['email']) -					{ -						$error[] = 'NEW_EMAIL_ERROR'; -					} -  					if (!check_form_key($form_name))  					{  						$error[] = 'FORM_INVALID'; diff --git a/phpBB/includes/ucp/ucp_profile.php b/phpBB/includes/ucp/ucp_profile.php index d0df70d2f5..9d81503f0a 100644 --- a/phpBB/includes/ucp/ucp_profile.php +++ b/phpBB/includes/ucp/ucp_profile.php @@ -46,7 +46,6 @@ class ucp_profile  				$data = array(  					'username'			=> utf8_normalize_nfc(request_var('username', $user->data['username'], true)),  					'email'				=> strtolower(request_var('email', $user->data['user_email'])), -					'email_confirm'		=> strtolower(request_var('email_confirm', '')),  					'new_password'		=> request_var('new_password', '', true),  					'cur_password'		=> request_var('cur_password', '', true),  					'password_confirm'	=> request_var('password_confirm', '', true), @@ -65,7 +64,6 @@ class ucp_profile  						'email'				=> array(  							array('string', false, 6, 60),  							array('email')), -						'email_confirm'		=> array('string', true, 6, 60),  					);  					if ($auth->acl_get('u_chgname') && $config['allow_namechange']) @@ -78,11 +76,6 @@ class ucp_profile  					$error = validate_data($data, $check_ary); -					if ($auth->acl_get('u_chgemail') && $data['email'] != $user->data['user_email'] && $data['email_confirm'] != $data['email']) -					{ -						$error[] = ($data['email_confirm']) ? 'NEW_EMAIL_ERROR' : 'NEW_EMAIL_CONFIRM_EMPTY'; -					} -  					if ($auth->acl_get('u_chgpasswd') && $data['new_password'] && $data['password_confirm'] != $data['new_password'])  					{  						$error[] = ($data['password_confirm']) ? 'NEW_PASSWORD_ERROR' : 'NEW_PASSWORD_CONFIRM_EMPTY'; diff --git a/phpBB/includes/ucp/ucp_register.php b/phpBB/includes/ucp/ucp_register.php index 91729c7844..5d85029e62 100644 --- a/phpBB/includes/ucp/ucp_register.php +++ b/phpBB/includes/ucp/ucp_register.php @@ -99,7 +99,6 @@ class ucp_register  				$s_hidden_fields = array_merge($s_hidden_fields, array(  					'username'			=> utf8_normalize_nfc(request_var('username', '', true)),  					'email'				=> strtolower(request_var('email', '')), -					'email_confirm'		=> strtolower(request_var('email_confirm', '')),  					'lang'				=> $user->lang_name,  					'tz'				=> request_var('tz', (float) $config['board_timezone']),  				)); @@ -172,7 +171,6 @@ class ucp_register  			'new_password'		=> request_var('new_password', '', true),  			'password_confirm'	=> request_var('password_confirm', '', true),  			'email'				=> strtolower(request_var('email', '')), -			'email_confirm'		=> strtolower(request_var('email_confirm', '')),  			'lang'				=> basename(request_var('lang', $user->lang_name)),  			'tz'				=> request_var('tz', (float) $timezone),  		); @@ -191,7 +189,6 @@ class ucp_register  				'email'				=> array(  					array('string', false, 6, 60),  					array('email')), -				'email_confirm'		=> array('string', false, 6, 60),  				'tz'				=> array('num', false, -14, 14),  				'lang'				=> array('language_iso_name'),  			)); @@ -236,11 +233,6 @@ class ucp_register  				{  					$error[] = $user->lang['NEW_PASSWORD_ERROR'];  				} - -				if ($data['email'] != $data['email_confirm']) -				{ -					$error[] = $user->lang['NEW_EMAIL_ERROR']; -				}  			}  			if (!sizeof($error)) @@ -455,7 +447,6 @@ class ucp_register  			'PASSWORD'			=> $data['new_password'],  			'PASSWORD_CONFIRM'	=> $data['password_confirm'],  			'EMAIL'				=> $data['email'], -			'EMAIL_CONFIRM'		=> $data['email_confirm'],  			'L_REG_COND'				=> $l_reg_cond,  			'L_USERNAME_EXPLAIN'		=> $user->lang($config['allow_name_chars'] . '_EXPLAIN', $user->lang('CHARACTERS', (int) $config['min_name_chars']), $user->lang('CHARACTERS', (int) $config['max_name_chars'])), diff --git a/phpBB/install/install_install.php b/phpBB/install/install_install.php index df9e47ddec..4663b5204e 100644 --- a/phpBB/install/install_install.php +++ b/phpBB/install/install_install.php @@ -689,7 +689,7 @@ class install_install extends module  			$error = array();  			// Check the entered email address and password -			if ($data['admin_name'] == '' || $data['admin_pass1'] == '' || $data['admin_pass2'] == '' || $data['board_email1'] == '' || $data['board_email2'] == '') +			if ($data['admin_name'] == '' || $data['admin_pass1'] == '' || $data['admin_pass2'] == '' || $data['board_email'] == '')  			{  				$error[] = $lang['INST_ERR_MISSING_DATA'];  			} @@ -721,12 +721,7 @@ class install_install extends module  				$error[] = $lang['INST_ERR_PASSWORD_TOO_LONG'];  			} -			if ($data['board_email1'] != $data['board_email2'] && $data['board_email1'] != '') -			{ -				$error[] = $lang['INST_ERR_EMAIL_MISMATCH']; -			} - -			if ($data['board_email1'] != '' && !preg_match('/^' . get_preg_expression('email') . '$/i', $data['board_email1'])) +			if ($data['board_email'] != '' && !preg_match('/^' . get_preg_expression('email') . '$/i', $data['board_email']))  			{  				$error[] = $lang['INST_ERR_EMAIL_INVALID'];  			} @@ -1250,11 +1245,11 @@ class install_install extends module  				WHERE config_name = 'server_port'",  			'UPDATE ' . $data['table_prefix'] . "config -				SET config_value = '" . $db->sql_escape($data['board_email1']) . "' +				SET config_value = '" . $db->sql_escape($data['board_email']) . "'  				WHERE config_name = 'board_email'",  			'UPDATE ' . $data['table_prefix'] . "config -				SET config_value = '" . $db->sql_escape($data['board_email1']) . "' +				SET config_value = '" . $db->sql_escape($data['board_email']) . "'  				WHERE config_name = 'board_contact'",  			'UPDATE ' . $data['table_prefix'] . "config @@ -1314,7 +1309,7 @@ class install_install extends module  				WHERE config_name = 'avatar_salt'",  			'UPDATE ' . $data['table_prefix'] . "users -				SET username = '" . $db->sql_escape($data['admin_name']) . "', user_password='" . $db->sql_escape(md5($data['admin_pass1'])) . "', user_ip = '" . $db->sql_escape($user_ip) . "', user_lang = '" . $db->sql_escape($data['default_lang']) . "', user_email='" . $db->sql_escape($data['board_email1']) . "', user_dateformat='" . $db->sql_escape($lang['default_dateformat']) . "', user_email_hash = " . $db->sql_escape(phpbb_email_hash($data['board_email1'])) . ", username_clean = '" . $db->sql_escape(utf8_clean_string($data['admin_name'])) . "' +				SET username = '" . $db->sql_escape($data['admin_name']) . "', user_password='" . $db->sql_escape(md5($data['admin_pass1'])) . "', user_ip = '" . $db->sql_escape($user_ip) . "', user_lang = '" . $db->sql_escape($data['default_lang']) . "', user_email='" . $db->sql_escape($data['board_email']) . "', user_dateformat='" . $db->sql_escape($lang['default_dateformat']) . "', user_email_hash = " . $db->sql_escape(phpbb_email_hash($data['board_email'])) . ", username_clean = '" . $db->sql_escape(utf8_clean_string($data['admin_name'])) . "'  				WHERE username = 'Admin'",  			'UPDATE ' . $data['table_prefix'] . "moderator_cache @@ -1830,7 +1825,7 @@ class install_install extends module  			$messenger->template('installed', $data['language']); -			$messenger->to($data['board_email1'], $data['admin_name']); +			$messenger->to($data['board_email'], $data['admin_name']);  			$messenger->anti_abuse_headers($config, $user); @@ -1889,8 +1884,7 @@ class install_install extends module  			'admin_name'	=> utf8_normalize_nfc(request_var('admin_name', '', true)),  			'admin_pass1'	=> request_var('admin_pass1', '', true),  			'admin_pass2'	=> request_var('admin_pass2', '', true), -			'board_email1'	=> strtolower(request_var('board_email1', '')), -			'board_email2'	=> strtolower(request_var('board_email2', '')), +			'board_email'	=> strtolower(request_var('board_email', '')),  			'img_imagick'	=> request_var('img_imagick', ''),  			'ftp_path'		=> request_var('ftp_path', ''),  			'ftp_user'		=> request_var('ftp_user', ''), @@ -1929,8 +1923,7 @@ class install_install extends module  		'admin_name'			=> array('lang' => 'ADMIN_USERNAME',			'type' => 'text:25:100', 'explain' => true),  		'admin_pass1'			=> array('lang' => 'ADMIN_PASSWORD',			'type' => 'password:25:100', 'explain' => true),  		'admin_pass2'			=> array('lang' => 'ADMIN_PASSWORD_CONFIRM',	'type' => 'password:25:100', 'explain' => false), -		'board_email1'			=> array('lang' => 'CONTACT_EMAIL',				'type' => 'text:25:100', 'explain' => false), -		'board_email2'			=> array('lang' => 'CONTACT_EMAIL_CONFIRM',		'type' => 'text:25:100', 'explain' => false), +		'board_email'			=> array('lang' => 'CONTACT_EMAIL',				'type' => 'text:25:100', 'explain' => false),  	);  	var $advanced_config_options = array(  		'legend1'				=> 'ACP_EMAIL_SETTINGS', diff --git a/phpBB/language/en/common.php b/phpBB/language/en/common.php index 631805afc2..7741ff8d1f 100644 --- a/phpBB/language/en/common.php +++ b/phpBB/language/en/common.php @@ -613,7 +613,6 @@ $lang = array_merge($lang, array(  	'TOO_LONG_USER_PASSWORD'		=> 'The password you entered is too long.',  	'TOO_LONG_USERNAME'				=> 'The username you entered is too long.',  	'TOO_LONG_EMAIL'				=> 'The e-mail address you entered is too long.', -	'TOO_LONG_EMAIL_CONFIRM'		=> 'The e-mail address confirmation you entered is too long.',  	'TOO_LONG_WEBSITE'				=> 'The website address you entered is too long.',  	'TOO_LONG_YIM'					=> 'The Yahoo! Messenger name you entered is too long.', @@ -635,7 +634,6 @@ $lang = array_merge($lang, array(  	'TOO_SHORT_USER_PASSWORD'		=> 'The password you entered is too short.',  	'TOO_SHORT_USERNAME'			=> 'The username you entered is too short.',  	'TOO_SHORT_EMAIL'				=> 'The e-mail address you entered is too short.', -	'TOO_SHORT_EMAIL_CONFIRM'		=> 'The e-mail address confirmation you entered is too short.',  	'TOO_SHORT_WEBSITE'				=> 'The website address you entered is too short.',  	'TOO_SHORT_YIM'					=> 'The Yahoo! Messenger name you entered is too short.', diff --git a/phpBB/language/en/install.php b/phpBB/language/en/install.php index 858065b643..7edc0b03ce 100644 --- a/phpBB/language/en/install.php +++ b/phpBB/language/en/install.php @@ -71,7 +71,6 @@ $lang = array_merge($lang, array(  	'CONFIG_FILE_WRITTEN'		=> 'The configuration file has been written. You may now proceed to the next step of the installation.',  	'CONFIG_PHPBB_EMPTY'		=> 'The phpBB3 config variable for ā%sā is empty.',  	'CONFIG_RETRY'				=> 'Retry', -	'CONTACT_EMAIL_CONFIRM'		=> 'Confirm contact e-mail',  	'CONTINUE_CONVERT'			=> 'Continue conversion',  	'CONTINUE_CONVERT_BODY'		=> 'A previous conversion attempt has been determined. You are now able to choose between starting a new conversion or continuing the conversion.',  	'CONTINUE_LAST'				=> 'Continue last statements', diff --git a/phpBB/language/en/ucp.php b/phpBB/language/en/ucp.php index 264b6ed4d8..aa1e9c27ce 100644 --- a/phpBB/language/en/ucp.php +++ b/phpBB/language/en/ucp.php @@ -122,8 +122,6 @@ $lang = array_merge($lang, array(  	'CLICK_RETURN_FOLDER'		=> '%1$sReturn to your ā%3$sā folder%2$s',  	'CONFIRMATION'				=> 'Confirmation of registration',  	'CONFIRM_CHANGES'			=> 'Confirm changes', -	'CONFIRM_EMAIL'				=> 'Confirm e-mail address', -	'CONFIRM_EMAIL_EXPLAIN'		=> 'You only need to specify this if you are changing your e-mail address.',  	'CONFIRM_EXPLAIN'			=> 'To prevent automated registrations the board requires you to enter a confirmation code. The code is displayed in the image you should see below. If you are visually impaired or cannot otherwise read this code please contact the %sBoard Administrator%s.',  	'VC_REFRESH'				=> 'Refresh confirmation code',  	'VC_REFRESH_EXPLAIN'		=> 'If you cannot read the code you can request a new one by clicking the button.', @@ -282,8 +280,6 @@ $lang = array_merge($lang, array(  	'MOVE_TO_FOLDER'				=> 'Move to folder',  	'MOVE_UP'						=> 'Move up', -	'NEW_EMAIL_CONFIRM_EMPTY'		=> 'You did not enter a confirm e-mail address.', -	'NEW_EMAIL_ERROR'				=> 'The e-mail addresses you entered do not match.',  	'NEW_FOLDER_NAME'				=> 'New folder name',  	'NEW_PASSWORD'					=> 'New password',  	'NEW_PASSWORD_CONFIRM_EMPTY'	=> 'You did not enter a confirm password.', diff --git a/phpBB/styles/prosilver/template/ucp_profile_reg_details.html b/phpBB/styles/prosilver/template/ucp_profile_reg_details.html index 9c3e98d053..9d4a9e3463 100644 --- a/phpBB/styles/prosilver/template/ucp_profile_reg_details.html +++ b/phpBB/styles/prosilver/template/ucp_profile_reg_details.html @@ -20,12 +20,6 @@  		<dt><label for="email">{L_EMAIL_ADDRESS}:</label></dt>  		<dd><!-- IF S_CHANGE_EMAIL --><input type="text" name="email" id="email" maxlength="100" value="{EMAIL}" class="inputbox" title="{L_EMAIL_ADDRESS}" /><!-- ELSE --><strong>{EMAIL}</strong><!-- ENDIF --></dd>  	</dl> -	<!-- IF S_CHANGE_EMAIL --> -		<dl> -			<dt><label for="email_confirm">{L_CONFIRM_EMAIL}:</label><br /><span>{L_CONFIRM_EMAIL_EXPLAIN}</span></dt> -			<dd><input type="text" name="email_confirm" id="email_confirm" maxlength="100" value="{CONFIRM_EMAIL}" class="inputbox" title="{L_CONFIRM_EMAIL}" /></dd> -		</dl> -	<!-- ENDIF -->  	<!-- IF S_CHANGE_PASSWORD -->  		<dl>  			<dt><label for="new_password">{L_NEW_PASSWORD}:</label><br /><span>{L_CHANGE_PASSWORD_EXPLAIN}</span></dt> diff --git a/phpBB/styles/prosilver/template/ucp_register.html b/phpBB/styles/prosilver/template/ucp_register.html index dd0e5ad02a..30ed37eecc 100644 --- a/phpBB/styles/prosilver/template/ucp_register.html +++ b/phpBB/styles/prosilver/template/ucp_register.html @@ -39,10 +39,6 @@  		<dd><input type="text" tabindex="2" name="email" id="email" size="25" maxlength="100" value="{EMAIL}" class="inputbox autowidth" title="{L_EMAIL_ADDRESS}" /></dd>  	</dl>  	<dl> -		<dt><label for="email_confirm">{L_CONFIRM_EMAIL}:</label></dt> -		<dd><input type="text" tabindex="3" name="email_confirm" id="email_confirm" size="25" maxlength="100" value="{EMAIL_CONFIRM}" class="inputbox autowidth" title="{L_CONFIRM_EMAIL}" /></dd> -	</dl> -	<dl>  		<dt><label for="new_password">{L_PASSWORD}:</label><br /><span>{L_PASSWORD_EXPLAIN}</span></dt>  		<dd><input type="password" tabindex="4" name="new_password" id="new_password" size="25" value="{PASSWORD}" class="inputbox autowidth" title="{L_NEW_PASSWORD}" /></dd>  	</dl> diff --git a/phpBB/styles/subsilver2/template/ucp_profile_reg_details.html b/phpBB/styles/subsilver2/template/ucp_profile_reg_details.html index 1b1c28fa3b..96e2e26683 100644 --- a/phpBB/styles/subsilver2/template/ucp_profile_reg_details.html +++ b/phpBB/styles/subsilver2/template/ucp_profile_reg_details.html @@ -22,12 +22,6 @@  	<td class="row1" width="35%"><b class="genmed">{L_EMAIL_ADDRESS}: </b></td>  	<td class="row2"><!-- IF S_CHANGE_EMAIL --><input type="text" class="post" name="email" size="30" maxlength="100" value="{EMAIL}" /><!-- ELSE --><b class="gen">{EMAIL}</b><!-- ENDIF --></td>  </tr> -<!-- IF S_CHANGE_EMAIL --> -	<tr> -		<td class="row1" width="35%"><b class="genmed">{L_CONFIRM_EMAIL}: </b><br /><span class="gensmall">{L_CONFIRM_EMAIL_EXPLAIN}</span></td> -		<td class="row2"><input type="text" class="post" name="email_confirm" size="30" maxlength="100" value="{CONFIRM_EMAIL}" /></td> -	</tr> -<!-- ENDIF -->  <!-- IF S_CHANGE_PASSWORD -->  	<tr>  		<td class="row1" width="35%"><b class="genmed">{L_NEW_PASSWORD}: </b><br /><span class="gensmall">{L_CHANGE_PASSWORD_EXPLAIN}</span></td> diff --git a/phpBB/styles/subsilver2/template/ucp_register.html b/phpBB/styles/subsilver2/template/ucp_register.html index ad6fb8d056..0c3533292d 100644 --- a/phpBB/styles/subsilver2/template/ucp_register.html +++ b/phpBB/styles/subsilver2/template/ucp_register.html @@ -42,10 +42,6 @@  	<td class="row2"><input class="post" type="text" name="email" size="25" maxlength="100" value="{EMAIL}" /></td>  </tr>  <tr> -	<td class="row1"><b class="genmed">{L_CONFIRM_EMAIL}: </b></td> -	<td class="row2"><input class="post" type="text" name="email_confirm" size="25" maxlength="100" value="{EMAIL_CONFIRM}" /></td> -</tr> -<tr>  	<td class="row1"><b class="genmed">{L_PASSWORD}: </b><br /><span class="gensmall">{L_PASSWORD_EXPLAIN}</span></td>  	<td class="row2"><input class="post" type="password" name="new_password" size="25" value="{PASSWORD}" /></td>  </tr> diff --git a/tests/test_framework/phpbb_functional_test_case.php b/tests/test_framework/phpbb_functional_test_case.php index ca52d24b7e..b5e6f7e377 100644 --- a/tests/test_framework/phpbb_functional_test_case.php +++ b/tests/test_framework/phpbb_functional_test_case.php @@ -102,8 +102,7 @@ class phpbb_functional_test_case extends phpbb_test_case  			'admin_name'	=> 'admin',  			'admin_pass1'	=> 'admin',  			'admin_pass2'	=> 'admin', -			'board_email1'	=> 'nobody@example.com', -			'board_email2'	=> 'nobody@example.com', +			'board_email'	=> 'nobody@example.com',  		));  		$parseURL = parse_url(self::$config['phpbb_functional_url']);  | 
