aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--phpBB/phpbb/crypto/manager.php6
-rw-r--r--tests/crypto/manager_test.php3
2 files changed, 8 insertions, 1 deletions
diff --git a/phpBB/phpbb/crypto/manager.php b/phpBB/phpbb/crypto/manager.php
index e314b08865..885bf719bf 100644
--- a/phpBB/phpbb/crypto/manager.php
+++ b/phpBB/phpbb/crypto/manager.php
@@ -196,10 +196,14 @@ class phpbb_crypto_manager
return $this->helper->check_combined_hash($password, $stored_hash_type, $hash);
}
- if ($stored_hash_type->get_type() !== $this->type)
+ if ($stored_hash_type->get_name() !== $this->type)
{
$this->convert_flag = true;
}
+ else
+ {
+ $this->convert_flag = false;
+ }
return $stored_hash_type->check($password, $hash);
}
diff --git a/tests/crypto/manager_test.php b/tests/crypto/manager_test.php
index ceeb45b5b8..c396d092c1 100644
--- a/tests/crypto/manager_test.php
+++ b/tests/crypto/manager_test.php
@@ -126,6 +126,9 @@ class phpbb_crypto_manager_test extends PHPUnit_Framework_TestCase
$password .= $this->pw_characters[mt_rand(0, 66)];
$this->assertEquals(false, $this->manager->check_hash($password, $hash));
}
+
+ // Check if convert_flag is correctly set
+ $this->assertEquals(($hash_type !== 'crypto.driver.bcrypt_2y'), $this->manager->convert_flag);
}