diff options
| author | Nils Adermann <naderman@naderman.de> | 2015-01-21 01:05:13 +0100 |
|---|---|---|
| committer | Nils Adermann <naderman@naderman.de> | 2015-01-21 01:05:13 +0100 |
| commit | eaeb88133f1f028fa06f0ebe5639668436fd469e (patch) | |
| tree | 3d69a230cfc20414a88c154fc97d0031c224ca71 /tests | |
| parent | d17904884ea27905d85c8cdc395821ade7079fa2 (diff) | |
| parent | e34b92882a51dc89da88464b8c751a9d93a03124 (diff) | |
| download | forums-eaeb88133f1f028fa06f0ebe5639668436fd469e.tar forums-eaeb88133f1f028fa06f0ebe5639668436fd469e.tar.gz forums-eaeb88133f1f028fa06f0ebe5639668436fd469e.tar.bz2 forums-eaeb88133f1f028fa06f0ebe5639668436fd469e.tar.xz forums-eaeb88133f1f028fa06f0ebe5639668436fd469e.zip | |
Merge pull request #3316 from bantu/ticket/13531
[ticket/13531] Explicitly disallow trailing paths (e.g. PATH_INFO).
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/security/trailing_path_test.php | 55 |
1 files changed, 55 insertions, 0 deletions
diff --git a/tests/security/trailing_path_test.php b/tests/security/trailing_path_test.php new file mode 100644 index 0000000000..72ec6b8816 --- /dev/null +++ b/tests/security/trailing_path_test.php @@ -0,0 +1,55 @@ +<?php +/** + * + * @package testing + * @copyright (c) 2011 phpBB Group + * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2 + * + */ + +require_once dirname(__FILE__) . '/../../phpBB/includes/startup.php'; + +class phpbb_security_trailing_path_test extends phpbb_test_case +{ + public function data_has_trailing_path() + { + return array( + array(false, '', '', ''), + array(true, '/', '', ''), + array(true, '/foo', '', ''), + array(true, '', '/foo', ''), + array(true, '/foo', '/foo', ''), + array(false, '', '', '/'), + array(false, '', '', '/?/x.php/'), + array(false, '', '', '/index.php'), + array(false, '', '', '/dir.phpisfunny/foo.php'), + array(true, '', '', '/index.php/foo.php'), + array(false, '', '', '/phpBB/viewtopic.php?f=3&t=5'), + array(false, '', '', '/phpBB/viewtopic.php?f=3&t=5/'), + array(false, '', '', '/phpBB/viewtopic.php?f=3&t=5/foo'), + array(true, '/foo', '/foo', '/phpBB/viewtopic.php?f=3&t=5/foo'), + array(false, '', '', '/projects/php.bb/phpBB/viewtopic.php?f=3&t=5/'), + array(false, '', '', '/projects/php.bb/phpBB/viewtopic.php?f=3&t=5'), + array(false, '', '', '/projects/php.bb/phpBB/viewtopic.php?f=3&t=5/foo.php/'), + array(false, '', '', '/projects/php.bb/phpBB/index.php'), + array(true, '', '', '/projects/php.bb/phpBB/index.php/'), + array(true, '', '', '/phpBB/index.php/?foo/a'), + array(true, '', '', '/projects/php.bb/phpBB/index.php/?a=5'), + array(false, '', '', '/projects/php.bb/phpBB/index.php?/a=5'), + ); + } + + /** + * @dataProvider data_has_trailing_path + */ + public function test_has_trailing_path($expected, $path_info, $orig_path_info, $request_uri) + { + global $phpEx; + + $_SERVER['PATH_INFO'] = $path_info; + $_SERVER['ORIG_PATH_INFO'] = $orig_path_info; + $_SERVER['REQUEST_URI'] = $request_uri; + + $this->assertSame($expected, phpbb_has_trailing_path($phpEx)); + } +} |