aboutsummaryrefslogtreecommitdiffstats
path: root/tests/session/garbage_collection_test.php
diff options
context:
space:
mode:
authorMarc Alexander <admin@m-a-styles.de>2019-12-15 20:26:01 +0100
committerMarc Alexander <admin@m-a-styles.de>2019-12-15 20:26:01 +0100
commitbcc90133a88a4d9536ae715c40f0b5d08dbd659d (patch)
tree8ff0e66344fb9e5bb7f6d9d5ccf445874812946c /tests/session/garbage_collection_test.php
parent611b3c4e4641d42ebe5d3225aaa8f7305a3380f9 (diff)
parent7ea063100e23234bf0d6a79fd0411e956a1b6668 (diff)
downloadforums-bcc90133a88a4d9536ae715c40f0b5d08dbd659d.tar
forums-bcc90133a88a4d9536ae715c40f0b5d08dbd659d.tar.gz
forums-bcc90133a88a4d9536ae715c40f0b5d08dbd659d.tar.bz2
forums-bcc90133a88a4d9536ae715c40f0b5d08dbd659d.tar.xz
forums-bcc90133a88a4d9536ae715c40f0b5d08dbd659d.zip
Merge pull request #5728 from rxu/ticket/15294
[ticket/15294] Fix session_gc() selecting expired sessions for unique users
Diffstat (limited to 'tests/session/garbage_collection_test.php')
-rw-r--r--tests/session/garbage_collection_test.php86
1 files changed, 79 insertions, 7 deletions
diff --git a/tests/session/garbage_collection_test.php b/tests/session/garbage_collection_test.php
index d361e022da..ec248b2904 100644
--- a/tests/session/garbage_collection_test.php
+++ b/tests/session/garbage_collection_test.php
@@ -41,19 +41,91 @@ class phpbb_session_garbage_collection_test extends phpbb_session_test_case
);
}
+ public function test_session_gc()
+ {
+ global $config;
+ $config['session_length'] = 3600;
+
+ $this->check_expired_sessions_recent(
+ [
+ [
+ 'session_user_id' => 4,
+ 'recent_time' => 1500000000,
+ ],
+ [
+ 'session_user_id' => 5,
+ 'recent_time' => 1500000000,
+ ],
+ ],
+ 'Before test, should get recent expired sessions only.'
+ );
+
+ $this->check_user_session_data(
+ [
+ [
+ 'username_clean' => 'bar',
+ 'user_lastvisit' => 1400000000,
+ 'user_lastpage' => 'oldpage_user_bar.php',
+ ],
+ [
+ 'username_clean' => 'foo',
+ 'user_lastvisit' => 1400000000,
+ 'user_lastpage' => 'oldpage_user_foo.php',
+ ],
+ ],
+ 'Before test, users session data is not updated yet.'
+ );
+
+ // There is an error unless the captcha plugin is set
+ $config['captcha_plugin'] = 'core.captcha.plugins.nogd';
+ $this->session->session_gc();
+ $this->check_expired_sessions_recent(
+ [],
+ 'After garbage collection, all expired sessions should be removed.'
+ );
+
+ $this->check_user_session_data(
+ [
+ [
+ 'username_clean' => 'bar',
+ 'user_lastvisit' => '1500000000',
+ 'user_lastpage' => 'newpage_user_bar.php',
+ ],
+ [
+ 'username_clean' => 'foo',
+ 'user_lastvisit' => '1500000000',
+ 'user_lastpage' => 'newpage_user_foo.php',
+ ],
+ ],
+ 'After garbage collection, users session data should be updated to the recent expired sessions data.'
+ );
+ }
+
public function test_cleanup_all()
{
$this->check_sessions_equals(
- array(
- array(
+ [
+ [
'session_id' => 'anon_session00000000000000000000',
'session_user_id' => 1,
- ),
- array(
+ ],
+ [
'session_id' => 'bar_session000000000000000000000',
'session_user_id' => 4,
- ),
- ),
+ ],
+ [
+ 'session_id' => 'bar_session000000000000000000002',
+ 'session_user_id' => 4,
+ ],
+ [
+ 'session_id' => 'foo_session000000000000000000000',
+ 'session_user_id' => 5,
+ ],
+ [
+ 'session_id' => 'foo_session000000000000000000002',
+ 'session_user_id' => 5,
+ ],
+ ],
'Before test, should have some sessions.'
);
// Set session length so it clears all
@@ -63,7 +135,7 @@ class phpbb_session_garbage_collection_test extends phpbb_session_test_case
$config['captcha_plugin'] = 'core.captcha.plugins.nogd';
$this->session->session_gc();
$this->check_sessions_equals(
- array(),
+ [],
'After setting session time to 0, should remove all.'
);
}