diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2013-05-28 14:58:40 +0200 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2013-05-28 14:58:40 +0200 |
| commit | f1523944a048e22207d6f200c6d152ecb9fdc136 (patch) | |
| tree | 3ba72958a07f767ea96a46d296ee64615c105a71 /tests/functional/extension_controller_test.php | |
| parent | 467c4d62c44a32a1a60bed2e2a2519b10cdebd33 (diff) | |
| download | forums-f1523944a048e22207d6f200c6d152ecb9fdc136.tar forums-f1523944a048e22207d6f200c6d152ecb9fdc136.tar.gz forums-f1523944a048e22207d6f200c6d152ecb9fdc136.tar.bz2 forums-f1523944a048e22207d6f200c6d152ecb9fdc136.tar.xz forums-f1523944a048e22207d6f200c6d152ecb9fdc136.zip | |
[ticket/develop/11568] Remove unneccessary calls to assert_response_success()
PHPBB3-11568
Diffstat (limited to 'tests/functional/extension_controller_test.php')
| -rw-r--r-- | tests/functional/extension_controller_test.php | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/functional/extension_controller_test.php b/tests/functional/extension_controller_test.php index 7f1decd5b5..1755843398 100644 --- a/tests/functional/extension_controller_test.php +++ b/tests/functional/extension_controller_test.php @@ -91,7 +91,6 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c { $this->phpbb_extension_manager->enable('foo/bar'); $crawler = $this->request('GET', 'app.php?controller=foo/bar'); - $this->assert_response_success(); $this->assertContains("foo/bar controller handle() method", $crawler->filter('body')->text()); $this->phpbb_extension_manager->purge('foo/bar'); } @@ -103,7 +102,6 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c { $this->phpbb_extension_manager->enable('foo/bar'); $crawler = $this->request('GET', 'app.php?controller=foo/template'); - $this->assert_response_success(); $this->assertContains("I am a variable", $crawler->filter('#content')->text()); $this->phpbb_extension_manager->purge('foo/bar'); } @@ -128,7 +126,7 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c public function test_exception_should_result_in_500_status_code() { $this->phpbb_extension_manager->enable('foo/bar'); - $crawler = $this->request('GET', 'app.php?controller=foo/exception'); + $crawler = $this->request('GET', 'app.php?controller=foo/exception', false); $this->assert_response_success(500); $this->assertContains('Exception thrown from foo/exception route', $crawler->filter('body')->text()); $this->phpbb_extension_manager->purge('foo/bar'); @@ -145,7 +143,7 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c */ public function test_error_ext_disabled_or_404() { - $crawler = $this->request('GET', 'app.php?controller=does/not/exist'); + $crawler = $this->request('GET', 'app.php?controller=does/not/exist', false); $this->assert_response_success(404); $this->assertContains('No route found for "GET /does/not/exist"', $crawler->filter('body')->text()); } |