aboutsummaryrefslogtreecommitdiffstats
path: root/tests/dbal
diff options
context:
space:
mode:
authorAndreas Fischer <bantu@phpbb.com>2013-03-27 23:46:39 +0100
committerAndreas Fischer <bantu@phpbb.com>2013-03-28 00:28:50 +0100
commitc909d9602b8a8d91d9c6cd72e01c1ddf21dcf593 (patch)
treefa039dc82d6df66bb4541da785883434f5690954 /tests/dbal
parentb48c4d9549acaff8bbe7846b2390267ccd36d39a (diff)
downloadforums-c909d9602b8a8d91d9c6cd72e01c1ddf21dcf593.tar
forums-c909d9602b8a8d91d9c6cd72e01c1ddf21dcf593.tar.gz
forums-c909d9602b8a8d91d9c6cd72e01c1ddf21dcf593.tar.bz2
forums-c909d9602b8a8d91d9c6cd72e01c1ddf21dcf593.tar.xz
forums-c909d9602b8a8d91d9c6cd72e01c1ddf21dcf593.zip
[ticket/11469] Do not repeat assert_config_count(2). Also move to setUp().
PHPBB3-11469
Diffstat (limited to 'tests/dbal')
-rw-r--r--tests/dbal/sql_insert_buffer_test.php13
1 files changed, 1 insertions, 12 deletions
diff --git a/tests/dbal/sql_insert_buffer_test.php b/tests/dbal/sql_insert_buffer_test.php
index bc6508b30a..4aad852149 100644
--- a/tests/dbal/sql_insert_buffer_test.php
+++ b/tests/dbal/sql_insert_buffer_test.php
@@ -18,6 +18,7 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
$this->db = $this->new_dbal();
$this->buffer = new phpbb_db_sql_insert_buffer($this->db, 'phpbb_config', 2);
+ $this->assert_config_count(2);
}
public function getDataSet()
@@ -29,8 +30,6 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
{
$this->db->multi_insert = false;
- $this->assert_config_count(2);
-
// This call can be buffered
$this->assertTrue($this->buffer->insert($this->get_row(1)));
@@ -49,8 +48,6 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
$this->markTestSkipped('Database does not support multi_insert');
}
- $this->assert_config_count(2);
-
// This call can be buffered
$this->assertFalse($this->buffer->insert($this->get_row(1)));
@@ -66,8 +63,6 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
{
$this->db->multi_insert = false;
- $this->assert_config_count(2);
-
$this->assertTrue($this->buffer->insert($this->get_row(1)));
// This call flushes the values
@@ -83,8 +78,6 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
$this->markTestSkipped('Database does not support multi_insert');
}
- $this->assert_config_count(2);
-
$this->assertFalse($this->buffer->insert($this->get_row(1)));
// This call flushes the values
@@ -97,8 +90,6 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
{
$this->db->multi_insert = false;
- $this->assert_config_count(2);
-
$this->assertTrue($this->buffer->insert_all($this->get_three_rows()));
$this->assert_config_count(5);
@@ -111,8 +102,6 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
$this->markTestSkipped('Database does not support multi_insert');
}
- $this->assert_config_count(2);
-
$this->assertTrue($this->buffer->insert_all($this->get_three_rows()));
$this->assert_config_count(4);