diff options
author | Chris Smith <toonarmy@phpbb.com> | 2008-12-19 20:36:18 +0000 |
---|---|---|
committer | Chris Smith <toonarmy@phpbb.com> | 2008-12-19 20:36:18 +0000 |
commit | a94ed97992ef41c5fe513777aa0d04f57060cbf5 (patch) | |
tree | ce5660c45f6e46f2f3f857f80d699d1f50bf0730 /phpBB | |
parent | cd6e5a85e7fd3b10bf74bfd122b4241daefb7c1e (diff) | |
download | forums-a94ed97992ef41c5fe513777aa0d04f57060cbf5.tar forums-a94ed97992ef41c5fe513777aa0d04f57060cbf5.tar.gz forums-a94ed97992ef41c5fe513777aa0d04f57060cbf5.tar.bz2 forums-a94ed97992ef41c5fe513777aa0d04f57060cbf5.tar.xz forums-a94ed97992ef41c5fe513777aa0d04f57060cbf5.zip |
Missing read permission from calls to phpbb_chmod()
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9208 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB')
-rw-r--r-- | phpBB/docs/CHANGELOG.html | 31 | ||||
-rw-r--r-- | phpBB/includes/acm/acm_file.php | 6 | ||||
-rw-r--r-- | phpBB/includes/functions_messenger.php | 4 | ||||
-rw-r--r-- | phpBB/includes/functions_template.php | 2 |
4 files changed, 25 insertions, 18 deletions
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html index a468ef6976..9b6e9581f1 100644 --- a/phpBB/docs/CHANGELOG.html +++ b/phpBB/docs/CHANGELOG.html @@ -53,6 +53,7 @@ <ol> <li><a href="#changelog">Changelog</a> <ol style="list-style-type: lower-roman;"> + <li><a href="#v304">Changes since 3.0.4</a></li> <li><a href="#v303">Changes since 3.0.3</a></li> <li><a href="#v302">Changes since 3.0.2</a></li> <li><a href="#v301">Changes since 3.0.1</a></li> @@ -83,7 +84,13 @@ <div class="inner"><span class="corners-top"><span></span></span> <div class="content"> - <a name="v303"></a><h3>1.i. Changes since 3.0.3</h3> + <a name="v304"></a><h3>1.i. Changes since 3.0.4</h3> + + <ul> + <li>[Fix] Missing read permission from calls to phpbb_chmod()</li> + </ul> + + <a name="v303"></a><h3>1.ii. Changes since 3.0.3</h3> <ul> <li>[Fix] Allow mixed-case template directories to be inherited (Bug #36725)</li> @@ -115,7 +122,7 @@ <li>[Sec] Ask for forum password if post within passworded forum quoted in private message. (Reported by nickvergessen)</li> </ul> - <a name="v302"></a><h3>1.ii. Changes since 3.0.2</h3> + <a name="v302"></a><h3>1.iii. Changes since 3.0.2</h3> <ul> <li>[Fix] Correctly set topic starter if first post in topic removed (Bug #30575 - Patch by blueray2048)</li> @@ -214,7 +221,7 @@ <li>[Sec Precaution] Stricter validation of the HTTP_HOST header (Thanks to Techie-Micheal et al for pointing out possible issues in derived code)</li> </ul> - <a name="v301"></a><h3>1.iii. Changes since 3.0.1</h3> + <a name="v301"></a><h3>1.iv. Changes since 3.0.1</h3> <ul> <li>[Fix] Ability to set permissions on non-mysql dbms (Bug #24955)</li> @@ -262,7 +269,7 @@ <li>[Sec] Only allow urls gone through redirect() being used within login_box(). (thanks nookieman)</li> </ul> - <a name="v300"></a><h3>1.iv. Changes since 3.0.0</h3> + <a name="v300"></a><h3>1.v. Changes since 3.0.0</h3> <ul> <li>[Change] Validate birthdays (Bug #15004)</li> @@ -333,7 +340,7 @@ <li>[Fix] Find and display colliding usernames correctly when converting from one database to another (Bug #23925)</li> </ul> - <a name="v30rc8"></a><h3>1.v. Changes since 3.0.RC8</h3> + <a name="v30rc8"></a><h3>1.vi. Changes since 3.0.RC8</h3> <ul> <li>[Fix] Cleaned usernames contain only single spaces, so "a_name" and "a__name" are treated as the same name (Bug #15634)</li> @@ -342,7 +349,7 @@ <li>[Fix] Call garbage_collection() within database updater to correctly close connections (affects Oracle for example)</li> </ul> - <a name="v30rc7"></a><h3>1.vi. Changes since 3.0.RC7</h3> + <a name="v30rc7"></a><h3>1.vii. Changes since 3.0.RC7</h3> <ul> <li>[Fix] Fixed MSSQL related bug in the update system</li> @@ -377,7 +384,7 @@ <li>[Fix] No duplication of active topics (Bug #15474)</li> </ul> - <a name="v30rc6"></a><h3>1.vii. Changes since 3.0.RC6</h3> + <a name="v30rc6"></a><h3>1.viii. Changes since 3.0.RC6</h3> <ul> <li>[Fix] Submitting language changes using acp_language (Bug #14736)</li> @@ -387,7 +394,7 @@ <li>[Fix] Able to request new password (Bug #14743)</li> </ul> - <a name="v30rc5"></a><h3>1.viii. Changes since 3.0.RC5</h3> + <a name="v30rc5"></a><h3>1.ix. Changes since 3.0.RC5</h3> <ul> <li>[Feature] Removing constant PHPBB_EMBEDDED in favor of using an exit_handler(); the constant was meant to achive this more or less.</li> @@ -450,7 +457,7 @@ <li>[Sec] New password hashing mechanism for storing passwords (#i42)</li> </ul> - <a name="v30rc4"></a><h3>1.ix. Changes since 3.0.RC4</h3> + <a name="v30rc4"></a><h3>1.x. Changes since 3.0.RC4</h3> <ul> <li>[Fix] MySQL, PostgreSQL and SQLite related database fixes (Bug #13862)</li> @@ -501,7 +508,7 @@ <li>[Fix] odbc_autocommit causing existing result sets to be dropped (Bug #14182)</li> </ul> - <a name="v30rc3"></a><h3>1.x. Changes since 3.0.RC3</h3> + <a name="v30rc3"></a><h3>1.xi. Changes since 3.0.RC3</h3> <ul> <li>[Fix] Fixing some subsilver2 and prosilver style issues</li> @@ -610,7 +617,7 @@ </ul> - <a name="v30rc2"></a><h3>1.xi. Changes since 3.0.RC2</h3> + <a name="v30rc2"></a><h3>1.xii. Changes since 3.0.RC2</h3> <ul> <li>[Fix] Re-allow searching within the memberlist</li> @@ -656,7 +663,7 @@ </ul> - <a name="v30rc1"></a><h3>1.xii. Changes since 3.0.RC1</h3> + <a name="v30rc1"></a><h3>1.xiii. Changes since 3.0.RC1</h3> <ul> <li>[Fix] (X)HTML issues within the templates (Bug #11255, #11255)</li> diff --git a/phpBB/includes/acm/acm_file.php b/phpBB/includes/acm/acm_file.php index f58f925506..d0cb9bd4a7 100644 --- a/phpBB/includes/acm/acm_file.php +++ b/phpBB/includes/acm/acm_file.php @@ -99,7 +99,7 @@ class acm include($phpbb_root_path . 'includes/functions.' . $phpEx); } - phpbb_chmod($this->cache_dir . 'data_global.' . $phpEx, CHMOD_WRITE); + phpbb_chmod($this->cache_dir . 'data_global.' . $phpEx, CHMOD_READ | CHMOD_WRITE); } else { @@ -209,7 +209,7 @@ class acm include($phpbb_root_path . 'includes/functions.' . $phpEx); } - phpbb_chmod($this->cache_dir . "data{$var_name}.$phpEx", CHMOD_WRITE); + phpbb_chmod($this->cache_dir . "data{$var_name}.$phpEx", CHMOD_READ | CHMOD_WRITE); } } else @@ -434,7 +434,7 @@ class acm include($phpbb_root_path . 'includes/functions.' . $phpEx); } - phpbb_chmod($filename, CHMOD_WRITE); + phpbb_chmod($filename, CHMOD_READ | CHMOD_WRITE); $query_result = $query_id; } diff --git a/phpBB/includes/functions_messenger.php b/phpBB/includes/functions_messenger.php index cbec2582a9..17c59e5274 100644 --- a/phpBB/includes/functions_messenger.php +++ b/phpBB/includes/functions_messenger.php @@ -708,7 +708,7 @@ class queue @flock($fp, LOCK_UN); fclose($fp); - phpbb_chmod($this->cache_file, CHMOD_WRITE); + phpbb_chmod($this->cache_file, CHMOD_READ | CHMOD_WRITE); } } @@ -749,7 +749,7 @@ class queue @flock($fp, LOCK_UN); fclose($fp); - phpbb_chmod($this->cache_file, CHMOD_WRITE); + phpbb_chmod($this->cache_file, CHMOD_READ | CHMOD_WRITE); } } } diff --git a/phpBB/includes/functions_template.php b/phpBB/includes/functions_template.php index 15efc7ec00..9f137d9151 100644 --- a/phpBB/includes/functions_template.php +++ b/phpBB/includes/functions_template.php @@ -755,7 +755,7 @@ class template_compile @flock($fp, LOCK_UN); @fclose($fp); - phpbb_chmod($filename, CHMOD_WRITE); + phpbb_chmod($filename, CHMOD_READ | CHMOD_WRITE); } return; |