diff options
| author | Andreas Fischer <bantu@phpbb.com> | 2013-03-27 18:22:59 +0100 |
|---|---|---|
| committer | Andreas Fischer <bantu@phpbb.com> | 2013-03-27 18:22:59 +0100 |
| commit | 8c5fcac2325356bacb72517f6fbd95f9bfdaf16d (patch) | |
| tree | fec43d43ebf03492e397ce2a87f79585ddc625d6 /phpBB | |
| parent | 55fb87ff180ca47a1a39d2714889d170ec368d31 (diff) | |
| download | forums-8c5fcac2325356bacb72517f6fbd95f9bfdaf16d.tar forums-8c5fcac2325356bacb72517f6fbd95f9bfdaf16d.tar.gz forums-8c5fcac2325356bacb72517f6fbd95f9bfdaf16d.tar.bz2 forums-8c5fcac2325356bacb72517f6fbd95f9bfdaf16d.tar.xz forums-8c5fcac2325356bacb72517f6fbd95f9bfdaf16d.zip | |
[ticket/11469] Add benefits over collecting huge insert arrays to class doc.
PHPBB3-11469
Diffstat (limited to 'phpBB')
| -rw-r--r-- | phpBB/includes/db/sql_insert_buffer.php | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/phpBB/includes/db/sql_insert_buffer.php b/phpBB/includes/db/sql_insert_buffer.php index 6b884dd412..4bf0608227 100644 --- a/phpBB/includes/db/sql_insert_buffer.php +++ b/phpBB/includes/db/sql_insert_buffer.php @@ -19,6 +19,18 @@ if (!defined('IN_PHPBB')) * Collects rows for insert into a database until the buffer size is reached. * Then flushes the buffer to the database and starts over again. * +* Benefits over collecting a (possibly huge) insert array and then using +* $db->sql_multi_insert() include: +* +* - Going over max packet size of the database connection is usually prevented +* because the data is submitted in batches. +* +* - Reaching database connection timeout is usually prevented because +* submission of batches talks to the database every now and then. +* +* - Usage of less PHP memory because data no longer needed is discarded on +* buffer flush. +* * Usage: * <code> * $buffer = new phpbb_db_sql_insert_buffer($db, 'test_table', 1234); |