diff options
| author | Marc Alexander <admin@m-a-styles.de> | 2014-11-03 17:14:18 +0100 |
|---|---|---|
| committer | Marc Alexander <admin@m-a-styles.de> | 2014-11-03 17:27:01 +0100 |
| commit | 13b59af1ffd0af652ba0ce3bc3f2594fc448fdb5 (patch) | |
| tree | e9b81e6fce3e55ad107081e6450440bedcbd443c /phpBB | |
| parent | 6fd092b5df6f96530fec8ba1aec426b6d59b822b (diff) | |
| download | forums-13b59af1ffd0af652ba0ce3bc3f2594fc448fdb5.tar forums-13b59af1ffd0af652ba0ce3bc3f2594fc448fdb5.tar.gz forums-13b59af1ffd0af652ba0ce3bc3f2594fc448fdb5.tar.bz2 forums-13b59af1ffd0af652ba0ce3bc3f2594fc448fdb5.tar.xz forums-13b59af1ffd0af652ba0ce3bc3f2594fc448fdb5.zip | |
[ticket/13280] Add additional sanitizer for ampersands in server superglobal
PHPBB3-13280
Diffstat (limited to 'phpBB')
| -rw-r--r-- | phpBB/includes/functions.php | 3 | ||||
| -rw-r--r-- | phpBB/phpbb/symfony_request.php | 6 |
2 files changed, 7 insertions, 2 deletions
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index 56363ed5c0..dc195cebb6 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -2397,8 +2397,7 @@ function build_url($strip_vars = false) global $config, $user, $phpbb_path_helper; $php_ext = $phpbb_path_helper->get_php_ext(); - // Change page back to expected format - $page = str_replace('&', '&', urldecode($user->page['page'])); + $page = str_replace('&', '&', $user->page['page']); // We need to be cautious here. // On some situations, the redirect path is an absolute URL, sometimes a relative path diff --git a/phpBB/phpbb/symfony_request.php b/phpBB/phpbb/symfony_request.php index ad949a35f2..4d357a5c56 100644 --- a/phpBB/phpbb/symfony_request.php +++ b/phpBB/phpbb/symfony_request.php @@ -30,6 +30,11 @@ class symfony_request extends Request $type_cast_helper->set_var($value, $value, gettype($value), true); }; + // This function is meant for additional handling of server variables + $server_sanitizer = function(&$value, $key) { + $value = str_replace('&', '&', $value); + }; + $get_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::GET); $post_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::POST); $server_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::SERVER); @@ -41,6 +46,7 @@ class symfony_request extends Request array_walk_recursive($server_parameters, $sanitizer); array_walk_recursive($files_parameters, $sanitizer); array_walk_recursive($cookie_parameters, $sanitizer); + array_walk_recursive($server_parameters, $server_sanitizer); parent::__construct($get_parameters, $post_parameters, array(), $cookie_parameters, $files_parameters, $server_parameters); } |