diff options
| author | Paul S. Owen <psotfx@users.sourceforge.net> | 2002-01-28 17:25:58 +0000 |
|---|---|---|
| committer | Paul S. Owen <psotfx@users.sourceforge.net> | 2002-01-28 17:25:58 +0000 |
| commit | e46d624c6bf84b8669196e081dff5c434fd0e25a (patch) | |
| tree | 57de42ac1df87cdcf1514316c915f4df307a1f90 /phpBB/viewtopic.php | |
| parent | 4c87b7480ec92755ccf30aaa39a2132b95693e9b (diff) | |
| download | forums-e46d624c6bf84b8669196e081dff5c434fd0e25a.tar forums-e46d624c6bf84b8669196e081dff5c434fd0e25a.tar.gz forums-e46d624c6bf84b8669196e081dff5c434fd0e25a.tar.bz2 forums-e46d624c6bf84b8669196e081dff5c434fd0e25a.tar.xz forums-e46d624c6bf84b8669196e081dff5c434fd0e25a.zip | |
Fix various var not set warnings ... many thanks go to The Horta for pointing out and offering fixes for many of these
git-svn-id: file:///svn/phpbb/trunk@1997 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/viewtopic.php')
| -rw-r--r-- | phpBB/viewtopic.php | 57 |
1 files changed, 30 insertions, 27 deletions
diff --git a/phpBB/viewtopic.php b/phpBB/viewtopic.php index d9e592e818..c61414df34 100644 --- a/phpBB/viewtopic.php +++ b/phpBB/viewtopic.php @@ -176,7 +176,7 @@ $forum_id = $forum_row['forum_id']; // // Start session management // -$userdata = session_pagestart($user_ip, $forum_id, $board_config['session_length']); +$userdata = session_pagestart($user_ip, $forum_id); init_userprefs($userdata); // // End session management @@ -377,6 +377,7 @@ if(!empty($HTTP_POST_VARS['postorder']) || !empty($HTTP_GET_VARS['postorder'])) } else { + $post_order = "asc"; $post_time_order = "ASC"; } @@ -417,11 +418,11 @@ $db->sql_freeresult($result); $sql = "SELECT * FROM " . RANKS_TABLE . " ORDER BY rank_special, rank_min"; -if(!$ranks_result = $db->sql_query($sql)) +if( !($result = $db->sql_query($sql)) ) { message_die(GENERAL_ERROR, "Couldn't obtain ranks information.", "", __LINE__, __FILE__, $sql); } -$ranksrow = $db->sql_fetchrowset($ranksresult); +$ranksrow = $db->sql_fetchrowset($result); // // Define censored word matches @@ -506,31 +507,34 @@ $post_alt = ( $forum_row['forum_status'] == FORUM_LOCKED ) ? $lang['Forum_locked // // Set a cookie for this topic // -$tracking_topics = ( isset($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_t"]) ) ? unserialize($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_t"]) : array(); -$tracking_forums = ( isset($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_f"]) ) ? unserialize($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_f"]) : array(); - -if( !empty($tracking_topics['' . $topic_id . '']) && !empty($tracking_forums['' . $forum_id . '']) ) -{ - $topic_last_read = ( $tracking_topics['' . $topic_id . ''] > $tracking_forums['' . $forum_id . ''] ) ? $tracking_topics['' . $topic_id . ''] : $tracking_forums['' . $forum_id . '']; -} -else if( !empty($tracking_topics['' . $topic_id . '']) || !empty($tracking_forums['' . $forum_id . '']) ) -{ - $topic_last_read = ( !empty($tracking_topics['' . $topic_id . '']) ) ? $tracking_topics['' . $topic_id . ''] : $tracking_forums['' . $forum_id . '']; -} -else +if( $userdata['session_logged_in'] ) { - $topic_last_read = $userdata['session_last_visit']; -} + $tracking_topics = ( isset($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_t"]) ) ? unserialize($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_t"]) : array(); + $tracking_forums = ( isset($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_f"]) ) ? unserialize($HTTP_COOKIE_VARS[$board_config['cookie_name'] . "_f"]) : array(); -if( count($tracking_topics) == 150 && empty($tracking_topics['' . $topic_id . '']) ) -{ - asort($tracking_topics); - unset($tracking_topics[key($tracking_topics)]); -} + if( !empty($tracking_topics['' . $topic_id . '']) && !empty($tracking_forums['' . $forum_id . '']) ) + { + $topic_last_read = ( $tracking_topics['' . $topic_id . ''] > $tracking_forums['' . $forum_id . ''] ) ? $tracking_topics['' . $topic_id . ''] : $tracking_forums['' . $forum_id . '']; + } + else if( !empty($tracking_topics['' . $topic_id . '']) || !empty($tracking_forums['' . $forum_id . '']) ) + { + $topic_last_read = ( !empty($tracking_topics['' . $topic_id . '']) ) ? $tracking_topics['' . $topic_id . ''] : $tracking_forums['' . $forum_id . '']; + } + else + { + $topic_last_read = $userdata['user_lastvisit']; + } -$tracking_topics['' . $topic_id . ''] = time(); + if( count($tracking_topics) == 150 && empty($tracking_topics['' . $topic_id . '']) ) + { + asort($tracking_topics); + unset($tracking_topics[key($tracking_topics)]); + } -setcookie($board_config['cookie_name'] . "_t", serialize($tracking_topics), 0, $board_config['cookie_path'], $board_config['cookie_domain'], $board_config['cookie_secure']); + $tracking_topics['' . $topic_id . ''] = time(); + + setcookie($board_config['cookie_name'] . "_t", serialize($tracking_topics), 0, $board_config['cookie_path'], $board_config['cookie_domain'], $board_config['cookie_secure']); +} // // Dump out the page header and load viewtopic body template @@ -595,12 +599,12 @@ if( $can_watch_topic ) if( $is_watching_topic ) { $s_watching_topic = '<a href="' . append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&unwatch=topic&start=$start") . '">' . $lang['Stop_watching_topic'] . '</a>'; - $s_watching_topic_img = '<a href="' . append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&unwatch=topic&start=$start") . '"><img src="' . $images['Topic_un_watch'] . '" alt="' . $lang['Stop_watching_topic'] . '" title="' . $lang['Stop_watching_topic'] . '" border="0"></a>'; + $s_watching_topic_img = ( isset($images['Topic_un_watch']) ) ? '<a href="' . append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&unwatch=topic&start=$start") . '"><img src="' . $images['Topic_un_watch'] . '" alt="' . $lang['Stop_watching_topic'] . '" title="' . $lang['Stop_watching_topic'] . '" border="0"></a>' : ''; } else { $s_watching_topic = '<a href="' . append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&watch=topic&start=$start") . '">' . $lang['Start_watching_topic'] . '</a>'; - $s_watching_topic_img = '<a href="' . append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&watch=topic&start=$start") . '"><img src="' . $images['Topic_watch'] . '" alt="' . $lang['Stop_watching_topic'] . '" title="' . $lang['Start_watching_topic'] . '" border="0"></a>'; + $s_watching_topic_img = ( isset($images['Topic_watch']) ) ? '<a href="' . append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . "=$topic_id&watch=topic&start=$start") . '"><img src="' . $images['Topic_watch'] . '" alt="' . $lang['Stop_watching_topic'] . '" title="' . $lang['Start_watching_topic'] . '" border="0"></a>' : ''; } } @@ -1136,7 +1140,6 @@ for($i = 0; $i < $total_posts; $i++) "EDIT_IMG" => $edit_img, "QUOTE_IMG" => $quote_img, - "PMSG_IMG" => $pmsg_img, "IP_IMG" => $ip_img, "DELETE_IMG" => $delpost_img, |