diff options
| author | JoshyPHP <s9e.dev@gmail.com> | 2015-07-06 01:57:54 +0200 |
|---|---|---|
| committer | JoshyPHP <s9e.dev@gmail.com> | 2015-07-06 23:45:38 +0200 |
| commit | cf4cdcda586a2371aa92ae452951f9660737ae09 (patch) | |
| tree | 15cab3410c1a38bf7520f9dc7745d8c4056f16b9 /phpBB/phpbb/textreparser/base.php | |
| parent | 7ccb6389124c5e990abaa917a6684fc3f4d072db (diff) | |
| download | forums-cf4cdcda586a2371aa92ae452951f9660737ae09.tar forums-cf4cdcda586a2371aa92ae452951f9660737ae09.tar.gz forums-cf4cdcda586a2371aa92ae452951f9660737ae09.tar.bz2 forums-cf4cdcda586a2371aa92ae452951f9660737ae09.tar.xz forums-cf4cdcda586a2371aa92ae452951f9660737ae09.zip | |
[ticket/13987] Replaced optional parameter with explicit API
Added disable_save() and enable_save() to toggle a dry run
PHPBB3-13987
Diffstat (limited to 'phpBB/phpbb/textreparser/base.php')
| -rw-r--r-- | phpBB/phpbb/textreparser/base.php | 32 |
1 files changed, 26 insertions, 6 deletions
diff --git a/phpBB/phpbb/textreparser/base.php b/phpBB/phpbb/textreparser/base.php index 6a366d659b..3e5ee248a1 100644 --- a/phpBB/phpbb/textreparser/base.php +++ b/phpBB/phpbb/textreparser/base.php @@ -16,6 +16,11 @@ namespace phpbb\textreparser; abstract class base implements reparser_interface { /** + * @var bool Whether to save changes to the database + */ + protected $save_changes = true; + + /** * {@inheritdoc} */ abstract public function get_max_id(); @@ -85,6 +90,22 @@ abstract class base implements reparser_interface } /** + * Disable saving changes to the database + */ + public function disable_save() + { + $this->save_changes = false; + } + + /** + * Enable saving changes to the database + */ + public function enable_save() + { + $this->save_changes = true; + } + + /** * Guess whether given BBCode is in use in given record * * @param array $record @@ -170,21 +191,20 @@ abstract class base implements reparser_interface /** * {@inheritdoc} */ - public function reparse_range($min_id, $max_id, $dry_run = false) + public function reparse_range($min_id, $max_id) { foreach ($this->get_records_by_range($min_id, $max_id) as $record) { - $this->reparse_record($record, $dry_run); + $this->reparse_record($record); } } /** * Reparse given record * - * @param array $record Associative array containing the record's data - * @param integer $dry_run If TRUE, do not save the changes + * @param array $record Associative array containing the record's data */ - protected function reparse_record(array $record, $dry_run) + protected function reparse_record(array $record) { $record = $this->add_missing_fields($record); $flags = ($record['enable_bbcode']) ? OPTION_FLAG_BBCODE : 0; @@ -214,7 +234,7 @@ abstract class base implements reparser_interface ); // Save the new text if it has changed and it's not a dry run - if ($text !== $record['text'] && !$dry_run) + if ($text !== $record['text'] && $this->save_changes) { $record['text'] = $text; $this->save_record($record); |