aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/phpbb/symfony_request.php
diff options
context:
space:
mode:
authorTristan Darricau <github@nicofuma.fr>2014-11-07 11:10:03 +0100
committerTristan Darricau <github@nicofuma.fr>2014-11-07 11:10:03 +0100
commita1b58d05d158ff7afd789c1b27821e17198f8d58 (patch)
tree41c5955e720b462173e78fed5c18c18057e0b62b /phpBB/phpbb/symfony_request.php
parent0e772afb9db640e54e84cfccaddcf74f3edbb3fb (diff)
parentf432193e0789f0182741d1b4a38a8c4cd86dfba4 (diff)
downloadforums-a1b58d05d158ff7afd789c1b27821e17198f8d58.tar
forums-a1b58d05d158ff7afd789c1b27821e17198f8d58.tar.gz
forums-a1b58d05d158ff7afd789c1b27821e17198f8d58.tar.bz2
forums-a1b58d05d158ff7afd789c1b27821e17198f8d58.tar.xz
forums-a1b58d05d158ff7afd789c1b27821e17198f8d58.zip
Merge pull request #3107 from marc1706/ticket/13280
[ticket/13280] Properly format the current page and add sanitizer to tests * marc1706/ticket/13280: [ticket/13280] Remove unneeded str_replace in build_url() [ticket/13280] Only run sanitizer for server superglobal and modify tests [ticket/13280] Seperate server sanitizer call and add comment [ticket/13280] Add additional sanitizer for ampersands in server superglobal [ticket/13280] Correctly format user page for build_url() [ticket/13280] Properly format the current page and add sanitizer to tests
Diffstat (limited to 'phpBB/phpbb/symfony_request.php')
-rw-r--r--phpBB/phpbb/symfony_request.php10
1 files changed, 9 insertions, 1 deletions
diff --git a/phpBB/phpbb/symfony_request.php b/phpBB/phpbb/symfony_request.php
index ad949a35f2..02d22c480f 100644
--- a/phpBB/phpbb/symfony_request.php
+++ b/phpBB/phpbb/symfony_request.php
@@ -30,6 +30,12 @@ class symfony_request extends Request
$type_cast_helper->set_var($value, $value, gettype($value), true);
};
+ // This function is meant for additional handling of server variables
+ $server_sanitizer = function(&$value, $key) use ($sanitizer) {
+ $sanitizer($value, $key);
+ $value = str_replace('&amp;', '&', $value);
+ };
+
$get_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::GET);
$post_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::POST);
$server_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::SERVER);
@@ -38,10 +44,12 @@ class symfony_request extends Request
array_walk_recursive($get_parameters, $sanitizer);
array_walk_recursive($post_parameters, $sanitizer);
- array_walk_recursive($server_parameters, $sanitizer);
array_walk_recursive($files_parameters, $sanitizer);
array_walk_recursive($cookie_parameters, $sanitizer);
+ // Run special sanitizer for server superglobal
+ array_walk_recursive($server_parameters, $server_sanitizer);
+
parent::__construct($get_parameters, $post_parameters, array(), $cookie_parameters, $files_parameters, $server_parameters);
}
}