diff options
| author | Tristan Darricau <github@nicofuma.fr> | 2014-09-06 15:47:30 +0200 |
|---|---|---|
| committer | Tristan Darricau <github@nicofuma.fr> | 2014-09-06 15:47:30 +0200 |
| commit | 297ab5c5260c37bf4db4f220911b4dc8f4ca2674 (patch) | |
| tree | d17f465b423e5a1e1d37c8a85afe425a61b210a8 /phpBB/phpbb/path_helper.php | |
| parent | 6387bf8d1399b9ccf995b8eb5a4b93425d27e873 (diff) | |
| parent | 7b796532dfbdccbca9ad66e1e752950e0c9e84b0 (diff) | |
| download | forums-297ab5c5260c37bf4db4f220911b4dc8f4ca2674.tar forums-297ab5c5260c37bf4db4f220911b4dc8f4ca2674.tar.gz forums-297ab5c5260c37bf4db4f220911b4dc8f4ca2674.tar.bz2 forums-297ab5c5260c37bf4db4f220911b4dc8f4ca2674.tar.xz forums-297ab5c5260c37bf4db4f220911b4dc8f4ca2674.zip | |
Merge pull request #2919 from Senky/ticket/12852
[ticket/12852] Make get_url_parts handle get variable with no value
* Senky/ticket/12852:
[ticket/12852] Add unit tests
[ticket/12852] Add space after if
[ticket/12852] Remove whitespace
[ticket/12852] Make get_url_parts handle get variable with no value
Diffstat (limited to 'phpBB/phpbb/path_helper.php')
| -rw-r--r-- | phpBB/phpbb/path_helper.php | 24 |
1 files changed, 21 insertions, 3 deletions
diff --git a/phpBB/phpbb/path_helper.php b/phpBB/phpbb/path_helper.php index 38dbbab51e..936564d8b6 100644 --- a/phpBB/phpbb/path_helper.php +++ b/phpBB/phpbb/path_helper.php @@ -316,7 +316,7 @@ class path_helper * Glue URL parameters together * * @param array $params URL parameters in the form of array(name => value) - * @return string Returns the glued string, e.g. name1=value1&name2=value2 + * @return string Returns the glued string, e.g. name1=value1&name2&name3=value3 */ public function glue_url_params($params) { @@ -324,7 +324,15 @@ class path_helper foreach ($params as $key => $value) { - $_params[] = $key . '=' . $value; + // some parameters do not have value + if ($value !== null) + { + $_params[] = $key . '=' . $value; + } + else + { + $_params[] = $key; + } } return implode('&', $_params); } @@ -353,7 +361,17 @@ class path_helper { continue; } - list($key, $value) = explode('=', $argument, 2); + + // some parameters don't have value + if (strpos($argument, '=') !== false) + { + list($key, $value) = explode('=', $argument, 2); + } + else + { + $key = $argument; + $value = null; + } if ($key === '') { |