diff options
| author | David Colón <david@davidiq.com> | 2017-02-13 14:03:54 -0500 |
|---|---|---|
| committer | David Colón <david@davidiq.com> | 2017-03-01 23:09:27 -0500 |
| commit | e5eb7025141238a3486a0395c42c55411dafb259 (patch) | |
| tree | 7821b5b89336ab4b6886b627b612406d41b3f47f /phpBB/phpbb/db/tools/tools.php | |
| parent | 9b4d455726babf0385c84817e66477134d8afd3d (diff) | |
| download | forums-e5eb7025141238a3486a0395c42c55411dafb259.tar forums-e5eb7025141238a3486a0395c42c55411dafb259.tar.gz forums-e5eb7025141238a3486a0395c42c55411dafb259.tar.bz2 forums-e5eb7025141238a3486a0395c42c55411dafb259.tar.xz forums-e5eb7025141238a3486a0395c42c55411dafb259.zip | |
[ticket/14992] Add indexes to user_notifications table
[ticket/14992] Change how index length is checked
[ticket/14992] Remove duplicates from user_notifications table
[ticket/14992] Add unique index to user_notifications table
[ticket/14992] Shorten unique index name
[ticket/14992] Shorten another index for user notifications
Diffstat (limited to 'phpBB/phpbb/db/tools/tools.php')
| -rw-r--r-- | phpBB/phpbb/db/tools/tools.php | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/phpBB/phpbb/db/tools/tools.php b/phpBB/phpbb/db/tools/tools.php index 9273d69cd6..4218addb8e 100644 --- a/phpBB/phpbb/db/tools/tools.php +++ b/phpBB/phpbb/db/tools/tools.php @@ -1487,17 +1487,17 @@ class tools implements tools_interface { $statements = array(); - $this->check_index_name_length($table_name, $index_name); - switch ($this->sql_layer) { case 'oracle': case 'sqlite3': + $this->check_index_name_length($table_name, $table_name . '_' . $index_name); $statements[] = 'CREATE UNIQUE INDEX ' . $table_name . '_' . $index_name . ' ON ' . $table_name . '(' . implode(', ', $column) . ')'; break; case 'mysql_40': case 'mysql_41': + $this->check_index_name_length($table_name, $index_name); $statements[] = 'ALTER TABLE ' . $table_name . ' ADD UNIQUE INDEX ' . $index_name . '(' . implode(', ', $column) . ')'; break; } @@ -1512,8 +1512,6 @@ class tools implements tools_interface { $statements = array(); - $this->check_index_name_length($table_name, $index_name); - // remove index length unless MySQL4 if ('mysql_40' != $this->sql_layer) { @@ -1524,6 +1522,7 @@ class tools implements tools_interface { case 'oracle': case 'sqlite3': + $this->check_index_name_length($table_name, $table_name . '_' . $index_name); $statements[] = 'CREATE INDEX ' . $table_name . '_' . $index_name . ' ON ' . $table_name . '(' . implode(', ', $column) . ')'; break; @@ -1539,6 +1538,7 @@ class tools implements tools_interface } // no break case 'mysql_41': + $this->check_index_name_length($table_name, $index_name); $statements[] = 'ALTER TABLE ' . $table_name . ' ADD INDEX ' . $index_name . ' (' . implode(', ', $column) . ')'; break; } @@ -1554,11 +1554,9 @@ class tools implements tools_interface */ protected function check_index_name_length($table_name, $index_name) { - $table_prefix = substr(CONFIG_TABLE, 0, -6); // strlen(config) - if (strlen($table_name . $index_name) - strlen($table_prefix) > 24) + if (strlen($index_name) > 30) { - $max_length = strlen($table_prefix) + 24; - trigger_error("Index name '{$table_name}_$index_name' on table '$table_name' is too long. The maximum is $max_length characters.", E_USER_ERROR); + trigger_error("Index name '$index_name' on table '$table_name' is too long. The maximum is 30 characters.", E_USER_ERROR); } } |