diff options
| author | Matt Friedman <maf675@gmail.com> | 2016-01-27 10:50:22 -0800 |
|---|---|---|
| committer | Matt Friedman <maf675@gmail.com> | 2016-01-27 10:50:22 -0800 |
| commit | 47d8aeebde6f763ec7247daf0df16dd2388b25b6 (patch) | |
| tree | 3fa4bcd6bd3c0a3337639755485f1967af122d83 /phpBB/phpbb/db/migration | |
| parent | 7d2a58e27100e5c776b44223e2cc6837c293db02 (diff) | |
| download | forums-47d8aeebde6f763ec7247daf0df16dd2388b25b6.tar forums-47d8aeebde6f763ec7247daf0df16dd2388b25b6.tar.gz forums-47d8aeebde6f763ec7247daf0df16dd2388b25b6.tar.bz2 forums-47d8aeebde6f763ec7247daf0df16dd2388b25b6.tar.xz forums-47d8aeebde6f763ec7247daf0df16dd2388b25b6.zip | |
[ticket/14434] Extract migration check to a reusable method
PHPBB3-14434
Diffstat (limited to 'phpBB/phpbb/db/migration')
| -rw-r--r-- | phpBB/phpbb/db/migration/schema_generator.php | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/phpBB/phpbb/db/migration/schema_generator.php b/phpBB/phpbb/db/migration/schema_generator.php index 55ab4452ed..dc685bb161 100644 --- a/phpBB/phpbb/db/migration/schema_generator.php +++ b/phpBB/phpbb/db/migration/schema_generator.php @@ -79,14 +79,12 @@ class schema_generator { foreach ($migrations as $key => $migration_class) { - if (class_exists($migration_class)) + // Unset classes that do not exist or do not extend the + // abstract class phpbb\db\migration\migration + if (\phpbb\db\migrator::is_migration($migration_class) === false) { - $reflector = new \ReflectionClass($migration_class); - if (!$reflector->implementsInterface('\phpbb\db\migration\migration_interface') || !$reflector->isInstantiable()) - { - unset($migrations[$key]); - continue; - } + unset($migrations[$key]); + continue; } $open_dependencies = array_diff($migration_class::depends_on(), $tree); |