aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/phpbb/avatar/driver
diff options
context:
space:
mode:
authorRubén Calvo <rubencm@gmail.com>2017-03-20 11:49:34 +0100
committerRubén Calvo <rubencm@gmail.com>2017-03-20 11:49:34 +0100
commit27ab639fbea160af2a003cb6ce3b2394195da297 (patch)
tree9a52f90fdffe3cff4bf4fe928799e608899fda07 /phpBB/phpbb/avatar/driver
parent29ce6e63527e395f086aff7936c8c4f32086956c (diff)
downloadforums-27ab639fbea160af2a003cb6ce3b2394195da297.tar
forums-27ab639fbea160af2a003cb6ce3b2394195da297.tar.gz
forums-27ab639fbea160af2a003cb6ce3b2394195da297.tar.bz2
forums-27ab639fbea160af2a003cb6ce3b2394195da297.tar.xz
forums-27ab639fbea160af2a003cb6ce3b2394195da297.zip
[ticket/15134] Return false if error
PHPBB3-15134
Diffstat (limited to 'phpBB/phpbb/avatar/driver')
-rw-r--r--phpBB/phpbb/avatar/driver/upload.php5
1 files changed, 3 insertions, 2 deletions
diff --git a/phpBB/phpbb/avatar/driver/upload.php b/phpBB/phpbb/avatar/driver/upload.php
index 607db9067c..4effa4c410 100644
--- a/phpBB/phpbb/avatar/driver/upload.php
+++ b/phpBB/phpbb/avatar/driver/upload.php
@@ -286,14 +286,15 @@ class upload extends \phpbb\avatar\driver\driver
try
{
$this->filesystem->remove($filename);
+ return true;
}
catch (\phpbb\filesystem\exception\filesystem_exception $e)
{
- // Do nothing
+ // Fail is covered by return statement below
}
}
- return true;
+ return false;
}
/**