diff options
| author | David M <davidmj@users.sourceforge.net> | 2006-08-11 21:52:46 +0000 |
|---|---|---|
| committer | David M <davidmj@users.sourceforge.net> | 2006-08-11 21:52:46 +0000 |
| commit | 86f3d738a0efbf5c50bdf112841aba2c8b859e85 (patch) | |
| tree | 6c7c34285132704577420d8f6b56545523018c71 /phpBB/install/install_install.php | |
| parent | 9086adad3c5fb9454a6df9149fb3f4ab7987b8ef (diff) | |
| download | forums-86f3d738a0efbf5c50bdf112841aba2c8b859e85.tar forums-86f3d738a0efbf5c50bdf112841aba2c8b859e85.tar.gz forums-86f3d738a0efbf5c50bdf112841aba2c8b859e85.tar.bz2 forums-86f3d738a0efbf5c50bdf112841aba2c8b859e85.tar.xz forums-86f3d738a0efbf5c50bdf112841aba2c8b859e85.zip | |
so.... what does this thing do?
well, the super fast, ultra efficient, massively huge BBCode handling system was implemented differently on each DBMS. Although this provided the best performance, the solution was a bit hacky.
So what does this new thing do? We use base64 encoding to make everything nice and shiny, it turns into nice, safe characters that we can just jam into varchars on essentially any database. This has two implications: we must decode every bitfield we get AND we have slightly fewer IDs to work with. It goes down from 2040 BBCodes to 1512. We lose like a quarter of them :P
P.S. I hope nothing broke :P
git-svn-id: file:///svn/phpbb/trunk@6263 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/install/install_install.php')
| -rwxr-xr-x | phpBB/install/install_install.php | 21 |
1 files changed, 0 insertions, 21 deletions
diff --git a/phpBB/install/install_install.php b/phpBB/install/install_install.php index 9c825a72b0..34e7530b64 100755 --- a/phpBB/install/install_install.php +++ b/phpBB/install/install_install.php @@ -981,11 +981,6 @@ class install_install extends module { $sql_query = preg_replace('/^\);$/m', ') DEFAULT CHARACTER SET latin1;', $sql_query); } - else - { - // versions older than 4.1.2 never had a good, working varbinary. TINYBLOB is just as good. - $sql_query = str_replace(array("varbinary(255) DEFAULT ''", 'varbinary(255) DEFAULT 0x90D8'), "TINYBLOB DEFAULT ''", $sql_query); - } break; @@ -1019,22 +1014,6 @@ class install_install extends module // Deal with any special comments and with MySQL < 4.1.2 switch ($dbms) { - case 'mysql': - case 'mysql4': - if (version_compare(mysql_get_server_info(), '4.1.2', '<')) - { - $bitfield = new bitfield(); - $bitfield->set(0); - $bitfield->set(3); - $bitfield->set(8); - $bitfield->set(9); - $bitfield->set(11); - $bitfield->set(12); - - $sql_query = str_replace("INSERT INTO phpbb_styles_template (template_name, template_copyright, template_path) VALUES ('subSilver', '© phpBB Group', 'subSilver');", "INSERT INTO phpbb_styles_template (template_name, template_copyright, template_path, bbcode_bitfield) VALUES ('subSilver', '© phpBB Group', 'subSilver', '" . $bitfield->data . "');", $sql_query); - } - break; - case 'mssql': case 'mssql_odbc': $sql_query = preg_replace('#\# MSSQL IDENTITY (phpbb_[a-z_]+) (ON|OFF) \##s', 'SET IDENTITY_INSERT \1 \2;', $sql_query); |