diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2010-05-28 13:13:53 +0200 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2010-05-28 13:13:53 +0200 |
| commit | 4637709f0a3701bdc3b44efeb08c919f73a3cb1e (patch) | |
| tree | 1427ac80cdcc921c93aa3ed5f89a860d2089f704 /phpBB/install/database_update.php | |
| parent | 6d7e30ae995fe0791c2bced0974b0445fa769ee9 (diff) | |
| download | forums-4637709f0a3701bdc3b44efeb08c919f73a3cb1e.tar forums-4637709f0a3701bdc3b44efeb08c919f73a3cb1e.tar.gz forums-4637709f0a3701bdc3b44efeb08c919f73a3cb1e.tar.bz2 forums-4637709f0a3701bdc3b44efeb08c919f73a3cb1e.tar.xz forums-4637709f0a3701bdc3b44efeb08c919f73a3cb1e.zip | |
[ticket/9628] _add_module 'after'-parameter does not work correctly.
The modules were grouped by left_id so num_modules is always one (hopefully), but the number of rows is the actual value we'd like to know. Removing the GROUP BY resolves the issue.
PHPBB3-9628
Diffstat (limited to 'phpBB/install/database_update.php')
| -rw-r--r-- | phpBB/install/database_update.php | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/phpBB/install/database_update.php b/phpBB/install/database_update.php index 47d261dc46..145b6b50ae 100644 --- a/phpBB/install/database_update.php +++ b/phpBB/install/database_update.php @@ -685,7 +685,6 @@ function _add_modules($modules_to_install) WHERE module_class = '" . $db->sql_escape($module_data['class']) . "' AND parent_id = {$parent_id} AND left_id BETWEEN {$first_left_id} AND {$module_row['left_id']} - GROUP BY left_id ORDER BY left_id"; $result = $db->sql_query($sql); $steps = (int) $db->sql_fetchfield('num_modules'); |