diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2011-02-16 10:47:41 +0100 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2011-02-16 18:22:31 +0100 |
| commit | d2e2ccf8a49a3d62d3de3145e114d3ed0b255465 (patch) | |
| tree | 499a6e36b378a4fc88ba536b266c7b04932c53bd /phpBB/includes | |
| parent | ad05f32c494d6622eca97c028cbde53e44a54647 (diff) | |
| download | forums-d2e2ccf8a49a3d62d3de3145e114d3ed0b255465.tar forums-d2e2ccf8a49a3d62d3de3145e114d3ed0b255465.tar.gz forums-d2e2ccf8a49a3d62d3de3145e114d3ed0b255465.tar.bz2 forums-d2e2ccf8a49a3d62d3de3145e114d3ed0b255465.tar.xz forums-d2e2ccf8a49a3d62d3de3145e114d3ed0b255465.zip | |
[ticket/9549] Fix some minor issues with descriptions and coding-guidelines.
PHPBB3-9549
Diffstat (limited to 'phpBB/includes')
| -rw-r--r-- | phpBB/includes/group_positions.php | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/phpBB/includes/group_positions.php b/phpBB/includes/group_positions.php index a697d96f66..951014c0c0 100644 --- a/phpBB/includes/group_positions.php +++ b/phpBB/includes/group_positions.php @@ -2,8 +2,7 @@ /** * * @package phpBB3 -* @version $Id$ -* @copyright (c) 2005 phpBB Group +* @copyright (c) 2011 phpBB Group * @license http://opensource.org/licenses/gpl-license.php GNU Public License * */ @@ -125,10 +124,10 @@ class phpbb_group_positions } /** - * Deletes a group by group_id + * Deletes a group by setting the field to self::GROUP_DISABLED and closing the gap in the list. * * @param int $group_id group_id of the group to be deleted - * @param bool $skip_group Skip the group itself, to save the query, when you need to update it anyway. + * @param bool $skip_group Skip setting the group to GROUP_DISABLED, to save the query, when you need to update it anyway. * @return void */ public function delete_group($group_id, $skip_group = false) @@ -177,7 +176,7 @@ class phpbb_group_positions $this->db->sql_query($sql); $sql = 'UPDATE ' . GROUPS_TABLE . ' - SET group_' . $this->field . ' = ' . ($current_value - 1) . ' + SET group_' . $this->field . ' = group_' . $this->field . ' - 1 WHERE group_id = ' . (int) $group_id; $this->db->sql_query($sql); @@ -208,7 +207,7 @@ class phpbb_group_positions { // Only update when we move another one up, otherwise it was the last. $sql = 'UPDATE ' . GROUPS_TABLE . ' - SET group_' . $this->field . ' = ' . ($current_value + 1) . ' + SET group_' . $this->field . ' = group_' . $this->field . ' + 1 WHERE group_id = ' . (int) $group_id; $this->db->sql_query($sql); } |