diff options
| author | 3D-I <marktravai@gmail.com> | 2019-01-22 16:10:52 +0100 |
|---|---|---|
| committer | 3D-I <marktravai@gmail.com> | 2019-01-22 16:12:22 +0100 |
| commit | ca4a98a2de7c20768e794eb62a519c920950823a (patch) | |
| tree | 59526973e8a6be70cb0c7beab233de08edb167e2 /phpBB/includes | |
| parent | 871875d9aa3d0b0a17a0eb1936323d5737a438f5 (diff) | |
| download | forums-ca4a98a2de7c20768e794eb62a519c920950823a.tar forums-ca4a98a2de7c20768e794eb62a519c920950823a.tar.gz forums-ca4a98a2de7c20768e794eb62a519c920950823a.tar.bz2 forums-ca4a98a2de7c20768e794eb62a519c920950823a.tar.xz forums-ca4a98a2de7c20768e794eb62a519c920950823a.zip | |
[ticket/15950] Add SQL transactions to mcp_main.php
PHPBB3-15950
And simultaneously remove a duplicated UPDATE query.
Diffstat (limited to 'phpBB/includes')
| -rw-r--r-- | phpBB/includes/mcp/mcp_main.php | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/phpBB/includes/mcp/mcp_main.php b/phpBB/includes/mcp/mcp_main.php index 196d2f995f..3c838e8d17 100644 --- a/phpBB/includes/mcp/mcp_main.php +++ b/phpBB/includes/mcp/mcp_main.php @@ -414,6 +414,8 @@ function change_topic_type($action, $topic_ids) if (confirm_box(true)) { + $db->sql_transaction('begin'); + $sql = 'UPDATE ' . TOPICS_TABLE . " SET topic_type = $new_topic_type WHERE " . $db->sql_in_set('topic_id', $topic_ids); @@ -425,13 +427,10 @@ function change_topic_type($action, $topic_ids) $sql = 'DELETE FROM ' . TOPICS_TABLE . ' WHERE ' . $db->sql_in_set('topic_moved_id', $topic_ids); $db->sql_query($sql); - - $sql = 'UPDATE ' . TOPICS_TABLE . " - SET topic_type = $new_topic_type - WHERE " . $db->sql_in_set('topic_id', $topic_ids); - $db->sql_query($sql); } + $db->sql_transaction('commit'); + $success_msg = (count($topic_ids) == 1) ? 'TOPIC_TYPE_CHANGED' : 'TOPICS_TYPE_CHANGED'; if (count($topic_ids)) |