aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes
diff options
context:
space:
mode:
authorMeik Sievertsen <acydburn@phpbb.com>2008-09-18 13:22:15 +0000
committerMeik Sievertsen <acydburn@phpbb.com>2008-09-18 13:22:15 +0000
commit76c0e5aa5e6cda11b7fef213c11640e3b3943395 (patch)
tree707aacbad743c4051185dd21d17e4af2abed062b /phpBB/includes
parentd135060c120018f82101bf5a24c63970ec6d2197 (diff)
downloadforums-76c0e5aa5e6cda11b7fef213c11640e3b3943395.tar
forums-76c0e5aa5e6cda11b7fef213c11640e3b3943395.tar.gz
forums-76c0e5aa5e6cda11b7fef213c11640e3b3943395.tar.bz2
forums-76c0e5aa5e6cda11b7fef213c11640e3b3943395.tar.xz
forums-76c0e5aa5e6cda11b7fef213c11640e3b3943395.zip
Do not allow setting forums parent to the forum itself. (Bug #18855)
git-svn-id: file:///svn/phpbb/trunk@8871 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/includes')
-rw-r--r--phpBB/includes/acp/acp_forums.php12
1 files changed, 9 insertions, 3 deletions
diff --git a/phpBB/includes/acp/acp_forums.php b/phpBB/includes/acp/acp_forums.php
index 3bd270e23d..edeac78d22 100644
--- a/phpBB/includes/acp/acp_forums.php
+++ b/phpBB/includes/acp/acp_forums.php
@@ -921,9 +921,8 @@ class acp_forums
$range_test_ary = array(
array('lang' => 'FORUM_TOPICS_PAGE', 'value' => $forum_data['forum_topics_per_page'], 'column_type' => 'TINT:0'),
);
- validate_range($range_test_ary, $errors);
-
+ validate_range($range_test_ary, $errors);
// Set forum flags
// 1 = link tracking
@@ -1205,7 +1204,14 @@ class acp_forums
if ($row['parent_id'] != $forum_data_sql['parent_id'])
{
- $errors = $this->move_forum($forum_data_sql['forum_id'], $forum_data_sql['parent_id']);
+ if ($row['forum_id'] != $forum_data_sql['parent_id'])
+ {
+ $errors = $this->move_forum($forum_data_sql['forum_id'], $forum_data_sql['parent_id']);
+ }
+ else
+ {
+ $forum_data_sql['parent_id'] = $row['parent_id'];
+ }
}
if (sizeof($errors))