diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2013-01-15 13:20:35 +0100 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2013-01-15 13:20:35 +0100 |
| commit | 46b75f4cf925ee0da852beeb6c4932e4fcb37992 (patch) | |
| tree | 9442a9d8049c40887aaf2a759236bfbf3bdabf44 /phpBB/includes | |
| parent | 780a8c98aca5dc54e1b85a79f8ff0f04ce49c5e4 (diff) | |
| download | forums-46b75f4cf925ee0da852beeb6c4932e4fcb37992.tar forums-46b75f4cf925ee0da852beeb6c4932e4fcb37992.tar.gz forums-46b75f4cf925ee0da852beeb6c4932e4fcb37992.tar.bz2 forums-46b75f4cf925ee0da852beeb6c4932e4fcb37992.tar.xz forums-46b75f4cf925ee0da852beeb6c4932e4fcb37992.zip | |
[ticket/10411] Add a comment why we left join the group table
We left join the group table because we want to check that the group
does exist there aswell.
PHPBB3-10411
Diffstat (limited to 'phpBB/includes')
| -rw-r--r-- | phpBB/includes/groupposition/teampage.php | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/phpBB/includes/groupposition/teampage.php b/phpBB/includes/groupposition/teampage.php index a189d5def9..2c488dd8a9 100644 --- a/phpBB/includes/groupposition/teampage.php +++ b/phpBB/includes/groupposition/teampage.php @@ -88,6 +88,7 @@ class phpbb_groupposition_teampage implements phpbb_groupposition_interface */ public function get_group_value($group_id) { + // The join is required to ensure that the group itself exists $sql = 'SELECT g.group_id, t.teampage_position FROM ' . GROUPS_TABLE . ' g LEFT JOIN ' . TEAMPAGE_TABLE . ' t @@ -114,6 +115,7 @@ class phpbb_groupposition_teampage implements phpbb_groupposition_interface */ public function get_group_values($group_id) { + // The join is required to ensure that the group itself exists $sql = 'SELECT * FROM ' . GROUPS_TABLE . ' g LEFT JOIN ' . TEAMPAGE_TABLE . ' t |