aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes
diff options
context:
space:
mode:
authorMarc Alexander <admin@m-a-styles.de>2014-11-21 23:16:22 +0100
committerMarc Alexander <admin@m-a-styles.de>2014-11-21 23:16:22 +0100
commit171837eefe2f8e17597629b108e2aa30c0f4055f (patch)
tree4646873e5041bf5b88e1ebf533d78f358547d1e1 /phpBB/includes
parent352648f173e7b132544bf3eaa494184bec6d5aa2 (diff)
downloadforums-171837eefe2f8e17597629b108e2aa30c0f4055f.tar
forums-171837eefe2f8e17597629b108e2aa30c0f4055f.tar.gz
forums-171837eefe2f8e17597629b108e2aa30c0f4055f.tar.bz2
forums-171837eefe2f8e17597629b108e2aa30c0f4055f.tar.xz
forums-171837eefe2f8e17597629b108e2aa30c0f4055f.zip
[ticket/13358] Do not pass variables by reference
PHPBB3-13358
Diffstat (limited to 'phpBB/includes')
-rw-r--r--phpBB/includes/functions_admin.php10
1 files changed, 6 insertions, 4 deletions
diff --git a/phpBB/includes/functions_admin.php b/phpBB/includes/functions_admin.php
index 6f95bc13bd..0b9ea23fe7 100644
--- a/phpBB/includes/functions_admin.php
+++ b/phpBB/includes/functions_admin.php
@@ -2990,11 +2990,13 @@ function get_remote_file($host, $directory, $filename, &$errstr, &$errno, $port
global $phpbb_container;
// Get file downloader and assign $errstr and $errno
- $file_downloader = $phpbb_container->get('file_downloader')
- ->set_error_string($errstr)
- ->set_error_number($errno);
+ $file_downloader = $phpbb_container->get('file_downloader');
- return $file_downloader->get($host, $directory, $filename, $port, $timeout);
+ $file_data = $file_downloader->get($host, $directory, $filename, $port, $timeout);
+ $errstr = $file_downloader->get_error_string();
+ $errno = $file_downloader->get_error_number();
+
+ return $file_data;
}
/*