aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/session.php
diff options
context:
space:
mode:
authorNils Adermann <naderman@naderman.de>2008-11-24 00:20:33 +0000
committerNils Adermann <naderman@naderman.de>2008-11-24 00:20:33 +0000
commit07e9b83a3de0264916a058b9cf180b91b297604f (patch)
tree386aed44943159d6634f74ee756c4073d5dbab19 /phpBB/includes/session.php
parent8427ae3fd4bd0055931579d18cb9d43d69f72a90 (diff)
downloadforums-07e9b83a3de0264916a058b9cf180b91b297604f.tar
forums-07e9b83a3de0264916a058b9cf180b91b297604f.tar.gz
forums-07e9b83a3de0264916a058b9cf180b91b297604f.tar.bz2
forums-07e9b83a3de0264916a058b9cf180b91b297604f.tar.xz
forums-07e9b83a3de0264916a058b9cf180b91b297604f.zip
- updated all code to use the request class instead of any direct access to
super globals - disabled super globals in common.php. See commit r9101 for more information - cleaned up/simplified a few lines along the way. git-svn-id: file:///svn/phpbb/trunk@9102 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/includes/session.php')
-rw-r--r--phpBB/includes/session.php9
1 files changed, 5 insertions, 4 deletions
diff --git a/phpBB/includes/session.php b/phpBB/includes/session.php
index abbc61cfa8..849affc40a 100644
--- a/phpBB/includes/session.php
+++ b/phpBB/includes/session.php
@@ -240,9 +240,10 @@ class session
}
// Add forum to the page for tracking online users - also adding a "x" to the end to properly identify the number
- $this->page['page'] .= (isset($_REQUEST['f'])) ? ((strpos($this->page['page'], '?') !== false) ? '&' : '?') . '_f_=' . (int) $_REQUEST['f'] . 'x' : '';
+ $forum = request_var('f', 0);
+ $this->page['page'] .= ($forum) ? ((strpos($this->page['page'], '?') !== false) ? '&' : '?') . '_f_=' . $forum . 'x' : '';
- if (isset($_COOKIE[$config['cookie_name'] . '_sid']) || isset($_COOKIE[$config['cookie_name'] . '_u']))
+ if (request::is_set($config['cookie_name'] . '_sid', request::COOKIE) || request::is_set($config['cookie_name'] . '_u', request::COOKIE))
{
$this->cookie_data['u'] = request_var($config['cookie_name'] . '_u', 0, false, true);
$this->cookie_data['k'] = request_var($config['cookie_name'] . '_k', '', false, true);
@@ -287,7 +288,7 @@ class session
}
// Is session_id is set or session_id is set and matches the url param if required
- if (!empty($this->session_id) && (!defined('NEED_SID') || (isset($_GET['sid']) && $this->session_id === $_GET['sid'])))
+ if (!empty($this->session_id) && (!defined('NEED_SID') || $this->session_id === request::variable('sid', '', false, request::GET)))
{
$sql = 'SELECT u.*, s.*
FROM ' . SESSIONS_TABLE . ' s, ' . USERS_TABLE . " u
@@ -1496,7 +1497,7 @@ class user extends session
$this->add_lang($lang_set);
unset($lang_set);
- if (!empty($_GET['style']) && $auth->acl_get('a_styles'))
+ if (request::variable('style', false, false, request::GET) && $auth->acl_get('a_styles'))
{
global $SID, $_EXTRA_URL;