diff options
| author | Bart van Bragt <bartvb@users.sourceforge.net> | 2002-01-11 12:38:34 +0000 |
|---|---|---|
| committer | Bart van Bragt <bartvb@users.sourceforge.net> | 2002-01-11 12:38:34 +0000 |
| commit | b3c8f779d6b6181a81444b9d1d6ba87a8e8370d9 (patch) | |
| tree | d7f01fe1b7c45ecf8cd0356778a05b61b21a50af /phpBB/includes/page_header.php | |
| parent | 5461b1bd62a695e2b0a589375ff5a2cf867c8fdb (diff) | |
| download | forums-b3c8f779d6b6181a81444b9d1d6ba87a8e8370d9.tar forums-b3c8f779d6b6181a81444b9d1d6ba87a8e8370d9.tar.gz forums-b3c8f779d6b6181a81444b9d1d6ba87a8e8370d9.tar.bz2 forums-b3c8f779d6b6181a81444b9d1d6ba87a8e8370d9.tar.xz forums-b3c8f779d6b6181a81444b9d1d6ba87a8e8370d9.zip | |
Cleaned up the viewonline code, wasnt giving correct output if you where admin
git-svn-id: file:///svn/phpbb/trunk@1843 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/includes/page_header.php')
| -rw-r--r-- | phpBB/includes/page_header.php | 37 |
1 files changed, 13 insertions, 24 deletions
diff --git a/phpBB/includes/page_header.php b/phpBB/includes/page_header.php index ac7b26cec1..e05930804e 100644 --- a/phpBB/includes/page_header.php +++ b/phpBB/includes/page_header.php @@ -89,11 +89,12 @@ $s_last_visit = ( $userdata['session_logged_in'] ) ? create_date($board_config[' // Get basic (usernames + totals) online // situation // -$sql = "SELECT u.username, u.user_id, u.user_allow_viewonline, s.session_logged_in, s.session_ip +$sql = "SELECT u.username, u.user_id, u.user_allow_viewonline, s.session_logged_in, s.session_ip, count(*) as online_count FROM ".USERS_TABLE." u, ".SESSIONS_TABLE." s WHERE u.user_id = s.session_user_id AND ( s.session_time >= ".( time() - 300 ) . " - OR u.user_session_time >= " . ( time() - 300 ) . " ) + OR u.user_session_time >= " . ( time() - 300 ) . " ) + GROUP BY u.user_id ORDER BY u.username ASC"; $result = $db->sql_query($sql); if(!$result) @@ -113,42 +114,30 @@ while( $row = $db->sql_fetchrow($result) ) { if( $row['user_allow_viewonline'] ) { - $userlist_ary[] = "<a href=\"" . append_sid("profile.$phpEx?mode=viewprofile&" . POST_USERS_URL . "=" . $row['user_id']) . "\">" . $row['username'] . "</a>"; - $userlist_visible[] = 1; + $user_online_link = "<a href=\"" . append_sid("profile.$phpEx?mode=viewprofile&" . POST_USERS_URL . "=" . $row['user_id']) . "\">" . $row['username'] . "</a>"; + $logged_visible_online++; } else { - $userlist_ary[] = "<a href=\"" . append_sid("profile.$phpEx?mode=viewprofile&" . POST_USERS_URL . "=" . $row['user_id']) . "\">" . $row['username'] . "</a>"; - $userlist_visible[] = 0; + $user_online_link = "<a href=\"" . append_sid("profile.$phpEx?mode=viewprofile&" . POST_USERS_URL . "=" . $row['user_id']) . "\"><i>" . $row['username'] . "</i></a>"; + $logged_hidden_online++; + } + + if( $row['user_allow_viewonline'] || $userdata['user_level'] == ADMIN ) + { + $online_userlist .= ($online_userlist != "") ? ", " . $user_online_link : $user_online_link; } } else { - $guests_online++; + $guests_online += $row['online_count']; } } -$online_userlist = ""; -for($i = 0; $i < count($userlist_ary); $i++) -{ - if( !strstr($online_userlist, $userlist_ary[$i]) ) - { - if( $userlist_visible[$i] || $userdata['user_level'] == ADMIN ) - { - $online_userlist .= ($online_userlist != "") ? ", " . $userlist_ary[$i] : $userlist_ary[$i]; - $logged_visible_online++; - } - else - { - $logged_hidden_online++; - } - } -} $online_userlist = $lang['Registered_users'] . " " . $online_userlist; $total_online_users = $logged_visible_online + $logged_hidden_online + $guests_online; - if( $total_online_users == 0 ) { $l_t_user_s = $lang['Online_users_zero_total']; |