aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/mcp/mcp_reports.php
diff options
context:
space:
mode:
authorDrae <paul@starstreak.net>2012-07-04 23:19:59 +0100
committerDrae <paul@starstreak.net>2012-07-18 14:30:20 +0100
commit922147f05a75d5a0e00b34f0102bc014583df984 (patch)
tree29f003d8e803ec8994ecf660d03c12514084040b /phpBB/includes/mcp/mcp_reports.php
parentb176b86f111a05338ed3c74026bcf19d42ec0ee3 (diff)
downloadforums-922147f05a75d5a0e00b34f0102bc014583df984.tar
forums-922147f05a75d5a0e00b34f0102bc014583df984.tar.gz
forums-922147f05a75d5a0e00b34f0102bc014583df984.tar.bz2
forums-922147f05a75d5a0e00b34f0102bc014583df984.tar.xz
forums-922147f05a75d5a0e00b34f0102bc014583df984.zip
[ticket/10968] Render pagination within the template
Since phpBB 2 pagination has been rendered mostly within the source. This limits just what designers can do with pagination. The current form is also questionable in terms of "best practice". The aim is to move rendering completely to the template via the use of a block element. Enabling S_ template vars also allows for control over specific aspects of the pagination output such as next, previous, active and ellipsis. Related to this - merging the capabilities of the topic_generate_pagination with generate_pagination removes an element of duplication. PHPBB3-10968
Diffstat (limited to 'phpBB/includes/mcp/mcp_reports.php')
-rw-r--r--phpBB/includes/mcp/mcp_reports.php3
1 files changed, 2 insertions, 1 deletions
diff --git a/phpBB/includes/mcp/mcp_reports.php b/phpBB/includes/mcp/mcp_reports.php
index 69c6a4cfff..3c5f51ee05 100644
--- a/phpBB/includes/mcp/mcp_reports.php
+++ b/phpBB/includes/mcp/mcp_reports.php
@@ -411,6 +411,8 @@ class mcp_reports
unset($report_ids, $row);
}
+ generate_pagination($this->u_action . "&amp;f=$forum_id&amp;t=$topic_id&amp;st=$sort_days&amp;sk=$sort_key&amp;sd=$sort_dir", $total, $config['topics_per_page'], $start);
+
// Now display the page
$template->assign_vars(array(
'L_EXPLAIN' => ($mode == 'reports') ? $user->lang['MCP_REPORTS_OPEN_EXPLAIN'] : $user->lang['MCP_REPORTS_CLOSED_EXPLAIN'],
@@ -421,7 +423,6 @@ class mcp_reports
'S_FORUM_OPTIONS' => $forum_options,
'S_CLOSED' => ($mode == 'reports_closed') ? true : false,
- 'PAGINATION' => generate_pagination($this->u_action . "&amp;f=$forum_id&amp;t=$topic_id&amp;st=$sort_days&amp;sk=$sort_key&amp;sd=$sort_dir", $total, $config['topics_per_page'], $start),
'PAGE_NUMBER' => on_page($total, $config['topics_per_page'], $start),
'TOPIC_ID' => $topic_id,
'TOTAL' => $total,