diff options
author | Joas Schilling <nickvergessen@gmx.de> | 2014-03-11 10:38:53 +0100 |
---|---|---|
committer | Joas Schilling <nickvergessen@gmx.de> | 2014-03-13 11:25:45 +0100 |
commit | eb1dd47e394702460e182d82990b828aa629fc1b (patch) | |
tree | 26598e8e5f042a45c8e09e1a1d5316260215efda /phpBB/includes/functions_module.php | |
parent | cf468bcc09ac8c4893abf9695aa0a4dcd9bef105 (diff) | |
download | forums-eb1dd47e394702460e182d82990b828aa629fc1b.tar forums-eb1dd47e394702460e182d82990b828aa629fc1b.tar.gz forums-eb1dd47e394702460e182d82990b828aa629fc1b.tar.bz2 forums-eb1dd47e394702460e182d82990b828aa629fc1b.tar.xz forums-eb1dd47e394702460e182d82990b828aa629fc1b.zip |
[ticket/11581] Hide categories when they have no visible children
PHPBB3-11581
Diffstat (limited to 'phpBB/includes/functions_module.php')
-rw-r--r-- | phpBB/includes/functions_module.php | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/phpBB/includes/functions_module.php b/phpBB/includes/functions_module.php index 28af7994c8..4d0f7205b4 100644 --- a/phpBB/includes/functions_module.php +++ b/phpBB/includes/functions_module.php @@ -125,8 +125,17 @@ class p_master // Clean up module cache array to only let survive modules the user can access $right_id = false; + + $hide_categories = array(); foreach ($this->module_cache['modules'] as $key => $row) { + // When the module has no mode (category) we check whether it has visible children + // before listing it as well. + if (!$row['module_mode']) + { + $hide_categories[(int) $row['module_id']] = $key; + } + // Not allowed to view module? if (!$this->module_auth_self($row['module_auth'])) { @@ -161,6 +170,22 @@ class p_master $right_id = $row['right_id']; continue; } + + if ($row['module_mode']) + { + // The parent category has a visible child + // So remove it and all its parents from the hide array + unset($hide_categories[(int) $row['parent_id']]); + foreach ($this->module_cache['parents'][$row['module_id']] as $module_id => $row_id) + { + unset($hide_categories[$module_id]); + } + } + } + + foreach ($hide_categories as $module_id => $row_id) + { + unset($this->module_cache['modules'][$row_id]); } // Re-index (this is needed, else we are not able to array_slice later) |