diff options
| author | Callum Macrae <callum@macr.ae> | 2015-05-28 18:05:07 +0200 |
|---|---|---|
| committer | Callum Macrae <callum@macr.ae> | 2015-05-28 18:05:07 +0200 |
| commit | be1d1c7d05a0b0dec259da967e2ed277fb8f632f (patch) | |
| tree | d57555e08c1014e690661848c644d145dab2b497 /phpBB/includes/functions.php | |
| parent | 44fcdd007fd82dbedf3188a035075416818161ab (diff) | |
| download | forums-be1d1c7d05a0b0dec259da967e2ed277fb8f632f.tar forums-be1d1c7d05a0b0dec259da967e2ed277fb8f632f.tar.gz forums-be1d1c7d05a0b0dec259da967e2ed277fb8f632f.tar.bz2 forums-be1d1c7d05a0b0dec259da967e2ed277fb8f632f.tar.xz forums-be1d1c7d05a0b0dec259da967e2ed277fb8f632f.zip | |
[ticket/13882] Lazy load the notification avatars.
This moves them further down the waterfall, making the page load
quicker.
PHPBB3-13882
Diffstat (limited to 'phpBB/includes/functions.php')
| -rw-r--r-- | phpBB/includes/functions.php | 23 |
1 files changed, 21 insertions, 2 deletions
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index d460497669..b3da9c4e5d 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -4809,10 +4809,11 @@ function phpbb_get_group_avatar($user_row, $alt = 'GROUP_AVATAR', $ignore_config * @param array $row Row cleaned by \phpbb\avatar\manager::clean_row * @param string $alt Optional language string for alt tag within image, can be a language key or text * @param bool $ignore_config Ignores the config-setting, to be still able to view the avatar in the UCP +* @param bool $lazy If true, will be lazy loaded (requires JS) * * @return string Avatar html */ -function phpbb_get_avatar($row, $alt, $ignore_config = false) +function phpbb_get_avatar($row, $alt, $ignore_config = false, $lazy = false) { global $user, $config, $cache, $phpbb_root_path, $phpEx; global $request; @@ -4850,7 +4851,25 @@ function phpbb_get_avatar($row, $alt, $ignore_config = false) if (!empty($avatar_data['src'])) { - $html = '<img src="' . $avatar_data['src'] . '" ' . + if ($lazy) { + // Determine board url - we may need it later + $board_url = generate_board_url() . '/'; + // This path is sent with the base template paths in the assign_vars() + // call below. We need to correct it in case we are accessing from a + // controller because the web paths will be incorrect otherwise. + $phpbb_path_helper = $phpbb_container->get('path_helper'); + $corrected_path = $phpbb_path_helper->get_web_root_path(); + + $web_path = (defined('PHPBB_USE_BOARD_URL_PATH') && PHPBB_USE_BOARD_URL_PATH) ? $board_url : $corrected_path; + + $theme = "{$web_path}styles/" . rawurlencode($user->style['style_path']) . '/theme'; + + $src = 'src="' . $theme . '/images/no_avatar.gif" data-src="' . $avatar_data['src'] . '"'; + } else { + $src = 'src="' . $avatar_data['src'] . '"'; + } + + $html = '<img class="avatar" ' . $src . ($avatar_data['width'] ? ('width="' . $avatar_data['width'] . '" ') : '') . ($avatar_data['height'] ? ('height="' . $avatar_data['height'] . '" ') : '') . 'alt="' . ((!empty($user->lang[$alt])) ? $user->lang[$alt] : $alt) . '" />'; |